Hi, Following are the notes taken at the code review conducted.
- Addressing URL's should not be hard coded. Extract them using util methods. - Do not assert for the output which is given same as the input. Always try to check different string in the expected request. - Put descriptive assertion messages. - Sample test cases should follow the same naming convention. - Always recommended to use assert equal. - Always try to send more than 1 message in testing scenarios. - Put JIRA's for changes and bugs found - Add test group in test cases. - When using log viewer client try to clear logs before run test methods. - When accessing file paths use set env as STAND_ALONE. BR, On Fri, Jul 4, 2014 at 3:04 PM, [email protected] <[email protected]> wrote: > This event has been changed. > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=NTRubHRjb3BtM2xqanQwbG5jdTlsOTFqYnMgZGV2QHdzbzIub3Jn&tok=MTYjd2FydW5hcEB3c28yLmNvbWQ1OGVmNGQwNjA0NWEzZDc3ZGE2NjA2NzAxZWMyNGM3NTg0M2UzNjc&ctz=Asia/Colombo&hl=en> > Code Review - ESB sample Test cases > Waruna And Amalka Doing the code review > *When* > Fri Jul 4, 2014 3pm – 4pm Colombo > *Where* > *Changed: *LK 3rd Floor Meeting Room - Kernel (map > <http://maps.google.lk/maps?q=LK+3rd+Floor+Meeting+Room+-+Kernel&hl=en>) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/warunap > <https://plus.google.com/hangouts/_/wso2.com/warunap?hceid=d2FydW5hcEB3c28yLmNvbQ.54nltcopm3ljjt0lncu9l91jbs> > *Calendar* > Waruna Perera > *Who* > • > Waruna Perera - organizer > • > Amalka Subasinghe > • > Nuwan Wimalasekara > • > Dimuthu De Lanerolle > • > Krishantha Samaraweera > • > Malintha Adikari > • > [email protected] > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=NTRubHRjb3BtM2xqanQwbG5jdTlsOTFqYnMgZGV2QHdzbzIub3Jn&rst=1&tok=MTYjd2FydW5hcEB3c28yLmNvbWQ1OGVmNGQwNjA0NWEzZDc3ZGE2NjA2NzAxZWMyNGM3NTg0M2UzNjc&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=NTRubHRjb3BtM2xqanQwbG5jdTlsOTFqYnMgZGV2QHdzbzIub3Jn&rst=3&tok=MTYjd2FydW5hcEB3c28yLmNvbWQ1OGVmNGQwNjA0NWEzZDc3ZGE2NjA2NzAxZWMyNGM3NTg0M2UzNjc&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=NTRubHRjb3BtM2xqanQwbG5jdTlsOTFqYnMgZGV2QHdzbzIub3Jn&rst=2&tok=MTYjd2FydW5hcEB3c28yLmNvbWQ1OGVmNGQwNjA0NWEzZDc3ZGE2NjA2NzAxZWMyNGM3NTg0M2UzNjc&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=NTRubHRjb3BtM2xqanQwbG5jdTlsOTFqYnMgZGV2QHdzbzIub3Jn&tok=MTYjd2FydW5hcEB3c28yLmNvbWQ1OGVmNGQwNjA0NWEzZDc3ZGE2NjA2NzAxZWMyNGM3NTg0M2UzNjc&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this courtesy email at the account [email protected] because > you are an attendee of this event. > > To stop receiving future notifications for this event, decline this event. > Alternatively you can sign up for a Google account at > https://www.google.com/calendar/ and control your notification settings > for your entire calendar. > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Waruna Perera Senior Software Engineer - Test Automation Mobile: +94 77 3867037 WSO2, Inc.; http://wso2.com/ lean . enterprise . middlewear.
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
