Code review notes: Tracking code validation in the APIMgtHandler.java class need to be changed. (Hash calculation need to be defined in a generic method and use in tracking code generation & validation. use String hash function instead of defining own hash algorithm)
Move the stream version and stream definition names to take from a config file. This is useful if the stream definition got changed in later version. getSubscriberCountByAPIs() should not be a public method. (or add user check @ the top, so that anonymous users could not access it via the API call) Graphs need to be separate into multiple pages pages without loading them all in a single page. Regards, Dinusha. On Tue, Jul 8, 2014 at 6:07 PM, Rajeeva Uthayasangar <[email protected]> wrote: > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=ZXF1YmV2bnBtYXYxZzBndGNqdXRjZ2g3MjQgZGludXNoYUB3c28yLmNvbQ&tok=MTYjcmFqZWV2YUB3c28yLmNvbTk2Zjg0OThiMDE3NGQ1MzJkYTI1MTgyNGEwYzE3NjM0Y2VlYjljODA&ctz=Asia/Colombo&hl=en> > Publishing APP Manager Runtime Statistics - Code Review > *When* > Wed Jul 9, 2014 3pm – 3:30pm Colombo > *Video call* > https://plus.google.com/hangouts/_/wso2.com/publishing-app > <https://plus.google.com/hangouts/_/wso2.com/publishing-app?hceid=cmFqZWV2YUB3c28yLmNvbQ.equbevnpmav1g0gtcjutcgh724> > *Calendar* > Dinusha Senanayaka > *Who* > • > Rajeeva Uthayasangar - organizer > • > Nuwan Dias > • > Dinusha Senanayaka > • > [email protected] > • > Ruwan Yatawara > • > Kasun Dissanayake > • > Rushmin Fernando > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=ZXF1YmV2bnBtYXYxZzBndGNqdXRjZ2g3MjQgZGludXNoYUB3c28yLmNvbQ&rst=1&tok=MTYjcmFqZWV2YUB3c28yLmNvbTk2Zjg0OThiMDE3NGQ1MzJkYTI1MTgyNGEwYzE3NjM0Y2VlYjljODA&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=ZXF1YmV2bnBtYXYxZzBndGNqdXRjZ2g3MjQgZGludXNoYUB3c28yLmNvbQ&rst=3&tok=MTYjcmFqZWV2YUB3c28yLmNvbTk2Zjg0OThiMDE3NGQ1MzJkYTI1MTgyNGEwYzE3NjM0Y2VlYjljODA&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=ZXF1YmV2bnBtYXYxZzBndGNqdXRjZ2g3MjQgZGludXNoYUB3c28yLmNvbQ&rst=2&tok=MTYjcmFqZWV2YUB3c28yLmNvbTk2Zjg0OThiMDE3NGQ1MzJkYTI1MTgyNGEwYzE3NjM0Y2VlYjljODA&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=ZXF1YmV2bnBtYXYxZzBndGNqdXRjZ2g3MjQgZGludXNoYUB3c28yLmNvbQ&tok=MTYjcmFqZWV2YUB3c28yLmNvbTk2Zjg0OThiMDE3NGQ1MzJkYTI1MTgyNGEwYzE3NjM0Y2VlYjljODA&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for invitations on calendar Dinusha Senanayaka. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- Dinusha Dilrukshi Senior Software Engineer WSO2 Inc.: http://wso2.com/ Mobile: +94725255071 Blog: http://dinushasblog.blogspot.com/
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
