Hi KasunG,
On Wed, Jul 9, 2014 at 12:02 PM, Kasun Gajasinghe <[email protected]> wrote: > Hi Gayashan, > > > On Wed, Jul 9, 2014 at 12:09 AM, Gayashan Amarasinghe <[email protected]> > wrote: > >> Hi Dushan, >> >> My question is related to the version range for twitter4j-core dependency >> here. It says <version>*[4.0,)*</version> which means to include the >> latest dependency version which is >=4.0 >> >> > You are correct. This would probably cause issues when twitter4j new > release versions has API incompatibilities. Having version range like this > in maven dependencies should not be done. > +1 My point exactly. @Buddhima: So shall we remove the version range from the dependency and make it a fixed version, say 4.0.0? (if we are keeping this in the orbit) > > > >> For an example lets assume that twitter4j-core has released a latest >> version 5.0.0 with API changes. And if anyone to build the orbit themselves >> now, the twitter4j 4.0.0.wso2v1 bundle would contain the latest 5.0.0 >> twitter4j-core library. And if that same twitter4j 4.0.0.wso2v1 bundle is >> used to build the Twitter-Connector which expects the twitter4j-core 4.0.0 >> (but has twitter4j-core 5.0.0 instead) it would result in a build failure. >> [This is also assuming that there's no downloads from nexus repo.] >> >> Is it possible? Any clarification is much appreciated. >> >> Thanks. >> >> /Gayashan >> >> >> On Tue, Jul 8, 2014 at 11:50 PM, Dushan Abeyruwan <[email protected]> >> wrote: >> >>> There will be multiple connector versions if any API changes happen >>> also we will maintaining API version in use at the connector store as meta >>> info >>> >>> On Tuesday, July 8, 2014, Gayashan Amarasinghe <[email protected]> >>> wrote: >>> >>>> Small correction in line. >>>> >>>> Thanks. >>>> >>>> >>>> On Tue, Jul 8, 2014 at 11:14 PM, Gayashan Amarasinghe < >>>> [email protected]> wrote: >>>> >>>>> Hi KasunG, >>>>> >>>>> Assuming that we keep this in the orbit i have a question. >>>>> >>>>> Since we are having a version range in the twitter4j dependency here, >>>>> wouldn't it create an issue with the possible [API] changes of the future >>>>> versions of the library? And also in terms of our orbit bundle naming >>>>> convention? >>>>> >>>>> <dependency> <groupId>org.twitter4j</groupId> >>>>> <artifactId>twitter4j-core</artifactId> <version>*[4.0,)*</version> >>>>> </dependency> >>>>> >>>>> For an example, anyone who builds the orbit [and not download the >>>>> dependency from the nexus] later may get a new twitter4j dependency and >>>>> might cause build failures if there are API changes within the dependency? >>>>> >>>> >>>> Should be changed to, might cause build failures within >>>> "Twitter-Connector" or any other project which depends on twitter4j >>>> 4.0.0.wso2v1 bundle, if there are API changes within the dependency. >>>> >>>> >>>>> Is it possible or am i understanding it wrong here? >>>>> >>>>> Thanks. >>>>> >>>>> /Gayashan >>>>> >>>>> >>>>> >>>>> On Tue, Jul 8, 2014 at 5:46 PM, Kasun Gajasinghe <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Buddhima, >>>>>> >>>>>> Your parent pom reference needs to be updated. You also need to add >>>>>> distributionManagement configuration. Then, work with Maheshika to get >>>>>> this >>>>>> orbit released. >>>>>> >>>>>> Regards, >>>>>> KasunG >>>>>> >>>>>> >>>>>> >>>>>> On Tue, Jul 8, 2014 at 5:35 PM, Buddhima Wijeweera <[email protected] >>>>>> > wrote: >>>>>> >>>>>>> Hi Sagara, >>>>>>> >>>>>>> Thank you for the information. >>>>>>> >>>>>>> I sent a pull request to wso2-orbit with this change. >>>>>>> Link: https://github.com/wso2/orbit/pull/5 >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Tue, Jul 8, 2014 at 4:37 PM, Sagara Gunathunga <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Jul 8, 2014 at 4:34 PM, Buddhima Wijeweera < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Currently some operations relate to Twitter-Connector are not >>>>>>>>> functioning. >>>>>>>>> Eg: >>>>>>>>> getFriendsIds >>>>>>>>> getFriends >>>>>>>>> getFollowersIds >>>>>>>>> getFollowers >>>>>>>>> >>>>>>>>> To fix that it is essential to change the version of Twitter4J >>>>>>>>> which is currently in use at here: >>>>>>>>> >>>>>>>>> https://svn.wso2.org/repos/wso2/carbon/orbit/branches/4.0.0/twitter/ >>>>>>>>> >>>>>>>>> I have locally made the change and tested. After the change all >>>>>>>>> those operations are working as expect. >>>>>>>>> >>>>>>>>> I would like to know how can I fix that in the above mentioned >>>>>>>>> location. >>>>>>>>> >>>>>>>> If the Orbit bundle is released you can't change it, you have to >>>>>>>> create new version of Orbit bundle. >>>>>>>> >>>>>>>> Thanks ! >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Thank You! >>>>>>>>> -- >>>>>>>>> Buddhima Wijeweera >>>>>>>>> Software Engineer; WSO2 Inc.; http://wso2.com , >>>>>>>>> >>>>>>>>> Email: [email protected] >>>>>>>>> Blog: https://buddhimawijeweera.wordpress.com >>>>>>>>> GitHub Profile: https://github.com/Buddhima >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Dev mailing list >>>>>>>>> [email protected] >>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sagara Gunathunga >>>>>>>> >>>>>>>> Senior Technical Lead; WSO2, Inc.; http://wso2.com >>>>>>>> V.P Apache Web Services; http://ws.apache.org/ >>>>>>>> Linkedin; http://www.linkedin.com/in/ssagara >>>>>>>> Blog ; http://ssagara.blogspot.com >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Buddhima Wijeweera >>>>>>> Software Engineer; WSO2 Inc.; http://wso2.com , >>>>>>> >>>>>>> Email: [email protected] >>>>>>> Blog: https://buddhimawijeweera.wordpress.com >>>>>>> GitHub Profile: https://github.com/Buddhima >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Dev mailing list >>>>>>> [email protected] >>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> *Kasun Gajasinghe* >>>>>> Senior Software Engineer, WSO2 Inc. >>>>>> email: kasung AT spamfree wso2.com >>>>>> linked-in: http://lk.linkedin.com/in/gajasinghe >>>>>> blog: http://kasunbg.org >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Dev mailing list >>>>>> [email protected] >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Gayashan Amarasinghe* >>>>> Software Engineer | Platform TG >>>>> WSO2, Inc. | http://wso2.com >>>>> lean. enterprise. middleware >>>>> >>>>> Mobile : +94718314517 >>>>> Blog : gayashan-a.blogspot.com >>>>> >>>> >>>> >>>> >>>> >>>> -- >>>> *Gayashan Amarasinghe* >>>> Software Engineer | Platform TG >>>> WSO2, Inc. | http://wso2.com >>>> lean. enterprise. middleware >>>> >>>> Mobile : +94718314517 >>>> Blog : gayashan-a.blogspot.com >>>> >>> >>> >>> -- >>> Dushan Abeyruwan | Associate Tech Lead >>> Integration Technologies Team >>> PMC Member Apache Synpase >>> WSO2 Inc. http://wso2.com/ >>> Blog:http://dushansview.blogspot.com/ >>> Mobile:(0094)713942042 >>> >>> >>> >> >> >> -- >> *Gayashan Amarasinghe* >> Software Engineer | Platform TG >> WSO2, Inc. | http://wso2.com >> lean. enterprise. middleware >> >> Mobile : +94718314517 >> Blog : gayashan-a.blogspot.com >> > > > > -- > > *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. > email: kasung AT spamfree wso2.com > linked-in: http://lk.linkedin.com/in/gajasinghe > blog: http://kasunbg.org > > > Thanks. /Gayashan -- *Gayashan Amarasinghe* Software Engineer | Platform TG WSO2, Inc. | http://wso2.com lean. enterprise. middleware Mobile : +94718314517 Blog : gayashan-a.blogspot.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
