Hi all, Project with raised concerns fixed is available at [1].
Thank you, SameeraK. [1] https://github.com/sameerak/emailMonitor-UI On Fri, Sep 12, 2014 at 2:03 PM, Sameera Kannangara <[email protected]> wrote: > Hi all, > > A code review was organized to review the jaggery app written as front end > of the email monitoring system that was created as the fast track training > project. > > Following are the notes taken in the Code Review - Email Monitor - Jaggery > App. > > Date - 2014-09-12 > Participants- > Subash,Eranda,Pulasthi,Danesh,Denuwanthi,Heshani,Suho,SameeraM,Ruchira > > Notes - > > - Move the logic in landing page, for retrieving the queries to a js file > - The utility.jag should be renamed to a utility.js > - You can use a single method which checks for the presence of parameters > in a json object > - The error message is found in the jxHR object > - Use the request.getAllParameters() instead of getting parameters > individually > -There is no need to stringify the json object before printing it > - The file reading should happen inside a try,catch and finally > - The location must be tracked when performing the login > - Put license headers for each page > - Put copyright details for each page > - Code needs to be formatted > > Please add any thing I've missed. > > Thank you, > SameeraK. > > -- > *Sameera Kannangara* > Software Engineer > Platform TG; WSO2 Inc. http://wso2.com > Contact: > phone: +94719541577 > Lean . Enterprise . Middleware > -- *Sameera Kannangara* Software Engineer Platform TG; WSO2 Inc. http://wso2.com Contact: phone: +94719541577 Lean . Enterprise . Middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
