And, yeah, as Rajith mentioned, I've reviewed the changes in the last
version.

Cheers,
Anjana.

On Wed, Sep 17, 2014 at 3:51 PM, Rajith Vitharana <[email protected]> wrote:

> Hi Sameera,
>
> Attached here with is the reviewed diff file and in [1] is the relevant
> pull request for the carban4-kernel
>
> [1] - https://github.com/wso2-dev/carbon4-kernel/pull/103
>
> Thanks
>
> On Fri, Sep 12, 2014 at 3:04 PM, Anjana Fernando <[email protected]> wrote:
>
>> Hi Sameera,
>>
>> Sure. I reviewed an earlier version of the code, then I told to do some
>> changes. Will check the latest changes.
>>
>> Cheers,
>> Anjana.
>>
>> On Fri, Sep 12, 2014 at 2:58 PM, Sameera Jayasoma <[email protected]>
>> wrote:
>>
>>> Thanks Manoj.
>>>
>>> Anjana, Can you please review this pull request?
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Sep 11, 2014 at 9:22 PM, Manoj Kumara <[email protected]> wrote:
>>>
>>>> Hi Team,
>>>>
>>>> Hence this is a new feature this has some API additions. Please review
>>>> this and commit.
>>>>
>>>> Thanks
>>>> Manoj
>>>>
>>>>
>>>> *Manoj Kumara*
>>>> Software Engineer
>>>> WSO2 Inc. http://wso2.com/
>>>> *lean.enterprise.middleware*
>>>> Mobile: +94713448188
>>>>
>>>> On Thu, Sep 11, 2014 at 3:17 AM, Rajith Vitharana <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> please find the pull request for the carbon4-kernal git repository for
>>>>> above changes in [1]
>>>>>
>>>>> [1] - https://github.com/wso2-dev/carbon4-kernel/pull/95
>>>>>
>>>>> Thanks,
>>>>>
>>>>> On Tue, Jul 29, 2014 at 6:12 PM, Rajith Vitharana <[email protected]>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have attached the new diff file for the data source deployer
>>>>>> feature. I have added the password encryption support so the datasource 
>>>>>> xml
>>>>>> files can have encrypted passwords. Sample car file is also attached here
>>>>>> with. Please review and commit.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>>
>>>>>> On Mon, Jul 28, 2014 at 11:48 AM, Rajith Vitharana <[email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Jasintha,Sohani,
>>>>>>>
>>>>>>> Thanks for the quick response. The "type" defined in "artifact.xml"
>>>>>>> should be "datasource/datasource" for it to be picked up by the 
>>>>>>> datasource
>>>>>>> deployment handler and get deployed. Below is a sample
>>>>>>>
>>>>>>> <?xml version="1.0" encoding="UTF-8"?>
>>>>>>> <artifact name="DataSourceA" version="1.0.0"
>>>>>>> type="datasource/datasource" serverRole="ApplicationServer">
>>>>>>>     <file>DataSource.xml</file>
>>>>>>> </artifact>
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Jul 28, 2014 at 11:37 AM, Sohani Weerasinghe <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I am working on implementing the Datasource editor in DevS.
>>>>>>>>
>>>>>>>>  Thanks,
>>>>>>>> Sohani
>>>>>>>>
>>>>>>>> Sohani Weerasinghe
>>>>>>>> Software Engineer
>>>>>>>> WSO2, Inc: http://wso2.com
>>>>>>>>
>>>>>>>> Mobile  : +94 716439774
>>>>>>>> Blog     :http://christinetechtips.blogspot.com/
>>>>>>>> Twitter  : https://twitter.com/sohanichristine
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Jul 28, 2014 at 11:04 AM, Jasintha Dasanayake <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> We can provide a single page form editor in DevS to edit this
>>>>>>>>> config
>>>>>>>>>
>>>>>>>>> Thanks and regards
>>>>>>>>> /Jasintha
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Jul 28, 2014 at 10:36 AM, Rajith Vitharana <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Kasun,
>>>>>>>>>>
>>>>>>>>>> Yes these datasources only provides a read-only view. and they
>>>>>>>>>> won't be saved in the registry. other than that they are same as the
>>>>>>>>>> datasources which we can create using UI.
>>>>>>>>>>
>>>>>>>>>> Hi Nirmal,
>>>>>>>>>>
>>>>>>>>>> noted. I'll try out encryption of passwords and to get DevS
>>>>>>>>>> support
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Mon, Jul 28, 2014 at 10:28 AM, Nirmal Fernando <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Thanks Rajith. Seems like for this feature, we need DevS support
>>>>>>>>>>> (data source resource type) before deployed in a production 
>>>>>>>>>>> environment.
>>>>>>>>>>> Also, this feature should ideally support encryption of passwords.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Jul 28, 2014 at 10:21 AM, Rajith Vitharana <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi Nirmal,
>>>>>>>>>>>>
>>>>>>>>>>>> This is a Appdeployment handler which will pickup datasources
>>>>>>>>>>>> deployed as carbon application and register them as datasources.
>>>>>>>>>>>> since datasource xml file is already in car app this feature
>>>>>>>>>>>> wont save it to the registry to avoid duplication.
>>>>>>>>>>>> datasources deployed as car apps can't be edited using UI.
>>>>>>>>>>>> Editing them should be done by redeploying the car app.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Mon, Jul 28, 2014 at 9:49 AM, Nirmal Fernando <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Rajith,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Can you please also mention what new improvements this patch
>>>>>>>>>>>>> brings?
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Mon, Jul 28, 2014 at 9:39 AM, Rajith Vitharana <
>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Attached here with the diff for datasource deployer feature
>>>>>>>>>>>>>> for org.wso2.carbon.ndatasource.core and a sample car file. 
>>>>>>>>>>>>>> please review
>>>>>>>>>>>>>> and commit
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Rajith Vitharana
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Software Engineer,
>>>>>>>>>>>>>> WSO2 Inc. : wso2.com
>>>>>>>>>>>>>> Mobile : +94715883223
>>>>>>>>>>>>>> Blog : http://lankavitharana.blogspot.com/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>>>> Dev mailing list
>>>>>>>>>>>>>> [email protected]
>>>>>>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks & regards,
>>>>>>>>>>>>> Nirmal
>>>>>>>>>>>>>
>>>>>>>>>>>>> Senior Software Engineer- Platform Technologies Team, WSO2 Inc.
>>>>>>>>>>>>> Mobile: +94715779733
>>>>>>>>>>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Rajith Vitharana
>>>>>>>>>>>>
>>>>>>>>>>>> Software Engineer,
>>>>>>>>>>>> WSO2 Inc. : wso2.com
>>>>>>>>>>>> Mobile : +94715883223
>>>>>>>>>>>> Blog : http://lankavitharana.blogspot.com/
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>>
>>>>>>>>>>> Thanks & regards,
>>>>>>>>>>> Nirmal
>>>>>>>>>>>
>>>>>>>>>>> Senior Software Engineer- Platform Technologies Team, WSO2 Inc.
>>>>>>>>>>> Mobile: +94715779733
>>>>>>>>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Rajith Vitharana
>>>>>>>>>>
>>>>>>>>>> Software Engineer,
>>>>>>>>>> WSO2 Inc. : wso2.com
>>>>>>>>>> Mobile : +94715883223
>>>>>>>>>> Blog : http://lankavitharana.blogspot.com/
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>>
>>>>>>>>> *Jasintha Dasanayake *
>>>>>>>>>
>>>>>>>>> *Senior Software EngineerWSO2 Inc. | http://wso2.com
>>>>>>>>> <http://wso2.com/> lean . enterprise . middleware*
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> *mobile :- 0711368118 <0711368118> *
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Dev mailing list
>>>>>>>>> [email protected]
>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Rajith Vitharana
>>>>>>>
>>>>>>> Software Engineer,
>>>>>>> WSO2 Inc. : wso2.com
>>>>>>> Mobile : +94715883223
>>>>>>> Blog : http://lankavitharana.blogspot.com/
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Rajith Vitharana
>>>>>>
>>>>>> Software Engineer,
>>>>>> WSO2 Inc. : wso2.com
>>>>>> Mobile : +94715883223
>>>>>> Blog : http://lankavitharana.blogspot.com/
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Rajith Vitharana
>>>>>
>>>>> Software Engineer,
>>>>> WSO2 Inc. : wso2.com
>>>>> Mobile : +94715883223
>>>>> Blog : http://lankavitharana.blogspot.com/
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Sameera Jayasoma,
>>> Software Architect,
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: [email protected]
>>> blog: http://sameera.adahas.org
>>> twitter: https://twitter.com/sameerajayasoma
>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>> Mobile: 0094776364456
>>>
>>> Lean . Enterprise . Middleware
>>>
>>>
>>
>>
>> --
>> *Anjana Fernando*
>> Senior Technical Lead
>> WSO2 Inc. | http://wso2.com
>> lean . enterprise . middleware
>>
>
>
>
> --
> Rajith Vitharana
>
> Software Engineer,
> WSO2 Inc. : wso2.com
> Mobile : +94715883223
> Blog : http://lankavitharana.blogspot.com/
>



-- 
*Anjana Fernando*
Senior Technical Lead
WSO2 Inc. | http://wso2.com
lean . enterprise . middleware
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to