Hi Bhathiya, Harsha,

Yes, you are right in saying that the file is already installed with the
feature to proper location of carbon. I think when copying via the bin.xml,
we are selectively picking up configuration files and including which leads
to omission of any newly introduced errors. I was under the impression that
inside the bin.xml we were copying the repository/conf/etc/ directory
completely and excluding any files not needed (if any).

I wonder why we are using the exclude all/include selectively approach for
the bin.xml conf files rather than the converse approach. If we are not
copying all the files installed by p2-profile-gen phase, the feature
developer would have the responsibility to go and update the product
bin.xml files in all the products where the feature is used. I guess there
are pros/cons for both approaches.

Any idea why the current exclude-all/include-selectively approach is used
over the other?

Thanks,
Lasantha


On 24 September 2014 23:58, Harsha Kumara <[email protected]> wrote:

> On Wed, Sep 24, 2014 at 10:59 PM, Bhathiya Jayasekara <[email protected]>
> wrote:
>
>> Hi Lasantha/Harsha,
>>
>> On Wed, Sep 24, 2014 at 10:31 PM, Harsha Kumara <[email protected]> wrote:
>>
>>>
>>> On Wed, Sep 24, 2014 at 10:15 PM, Lasantha Fernando <[email protected]>
>>> wrote:
>>>
>>>>
>>>>
>>>> On 24 September 2014 22:05, Harsha Kumara <[email protected]> wrote:
>>>>
>>>>> Hi Prassanna,
>>>>>
>>>>> Cassandra environments are introduce as a new feature of Storage
>>>>> Server recently which was done by Bhathiya. So cassandra-enviornments.xml
>>>>> xml needs to be added to the product distribution.
>>>>>
>>>>
>>>> Can't we add this file when installing the feature itself, rather than
>>>> copying it through product bin.xml? You can find a similar example in [3].
>>>>
>>>> In general, it is better practice to add the related configuration
>>>> files with the feature, unless there is a particular reason that this
>>>> approach cannot be followed.
>>>>
>>>
>>> +1 for this approach. I think there are no product specific
>>> configurations. Will add this to the feature itself. Thanks Lasantha for
>>> pointing out this.
>>>
>>
>> We already do this. When the product distribution is being built, and
>> features being installed, this config is copied to proper location of
>> carbon. But product (greg in this case) has the responsibility to copy the
>> config from carbon to product. AFAIK, that's the standard practice. Please
>> correct me if I'm wrong.
>>
>> @Bhathiya, as Lasantha mentioned, if we can copy the configuration at
> feature installation without copy it from the bin file from a product,
> wouldn't it be good? If one needs to install a feature separately, wouldn't
> that needs to be there unless there is product specific configuration
> modification. I'm not exactly sure about copying configuration on feature
> installing.
>
>> Thanks,
>> Bhathiya
>>
>>
>>>
>>>>
>>>>> If you copy the [2] to repository/conf/etc folder this error should
>>>>> disappear.But this needs to be added to the product distribution.
>>>>>
>>>>> @Bhathiya
>>>>> Can you confirm this?
>>>>>
>>>>> I'm adding Pulasthi to notify about this configuration.
>>>>>
>>>>> [1] -
>>>>> https://github.com/wso2-dev/product-ss/blob/master/modules/distribution/src/main/assembly/bin.xml
>>>>> (product-ss bin file with the configuration)
>>>>> Thanks,
>>>>> Harsha
>>>>>
>>>>
>>>> [3]
>>>> https://github.com/wso2-dev/carbon-event-processing/blob/master/features/event-processor/org.wso2.carbon.event.processor.server.feature/resources/p2.inf
>>>>
>>>> Thanks,
>>>> Lasantha
>>>>
>>>>>
>>>>> On Wed, Sep 24, 2014 at 9:20 PM, Shiva Balachandran <[email protected]>
>>>>> wrote:
>>>>>
>>>>>> Hi Prasanna,
>>>>>>
>>>>>> Please check if the file "cassandra-enviornments.xml" exists in the
>>>>>> given directory path. (Users/prasanna/workspace/
>>>>>> wso2/greg/git/prasanna/product-greg/modules/
>>>>>> distribution/target/wso2greg-5.0.0-SNAPSHOT/repository/conf/etc).
>>>>>>
>>>>>> The error is made cause of an missing file which is used
>>>>>> to initialize the environment. Try obtaining a fresh pack.
>>>>>>
>>>>>> Thank you,
>>>>>>
>>>>>> Regards
>>>>>> Shiva Balachandran
>>>>>>
>>>>>> On Wed, Sep 24, 2014 at 6:52 PM, Prasanna Dangalla <[email protected]
>>>>>> > wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Following error occurs when running the wso2server.sh.
>>>>>>>
>>>>>>> ERROR {org.wso2.carbon.cassandra.mgt.environment.EnvironmentManager}
>>>>>>> -  Exception Occurred while initializing Cassandra environments
>>>>>>> org.wso2.carbon.cassandra.mgt.CassandraServerManagementException:
>>>>>>> Error occurred while parsing file, while converting to a
>>>>>>> org.w3c.dom.Document :
>>>>>>> /Users/prasanna/workspace/wso2/greg/git/prasanna/product-greg/modules/distribution/target/wso2greg-5.0.0-SNAPSHOT/repository/conf/etc/cassandra-environments.xml
>>>>>>> (No such file or directory)
>>>>>>>         at
>>>>>>> org.wso2.carbon.cassandra.mgt.util.CassandraManagementUtils.convertToDocument(CassandraManagementUtils.java:164)
>>>>>>>         at
>>>>>>> org.wso2.carbon.cassandra.mgt.environment.EnvironmentManager.initEnvironments(EnvironmentManager.java:74)
>>>>>>>         at
>>>>>>> org.wso2.carbon.cassandra.mgt.internal.CassandraAdminDSComponent.activate(CassandraAdminDSComponent.java:54)
>>>>>>>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>>>>>>> Method)
>>>>>>>         at
>>>>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>>>>>         at
>>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>>>>>         at java.lang.reflect.Method.invoke(Method.java:597)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.model.ServiceComponent.activate(ServiceComponent.java:260)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.activate(ServiceComponentProp.java:146)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.build(ServiceComponentProp.java:347)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.InstanceProcess.buildComponent(InstanceProcess.java:620)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.InstanceProcess.buildComponents(InstanceProcess.java:197)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.Resolver.getEligible(Resolver.java:343)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.SCRManager.serviceChanged(SCRManager.java:222)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:107)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.internal.core.BundleContextImpl.dispatchEvent(BundleContextImpl.java:861)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:819)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:771)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.register(ServiceRegistrationImpl.java:130)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.registerService(ServiceRegistry.java:214)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:433)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:451)
>>>>>>>         at
>>>>>>> org.wso2.carbon.core.init.CarbonServerManager.initializeCarbon(CarbonServerManager.java:517)
>>>>>>>         at
>>>>>>> org.wso2.carbon.core.init.CarbonServerManager.start(CarbonServerManager.java:219)
>>>>>>>         at
>>>>>>> org.wso2.carbon.core.internal.CarbonCoreServiceComponent.activate(CarbonCoreServiceComponent.java:81)
>>>>>>>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>>>>>>> Method)
>>>>>>>         at
>>>>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>>>>>         at
>>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>>>>>         at java.lang.reflect.Method.invoke(Method.java:597)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.model.ServiceComponent.activate(ServiceComponent.java:260)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.activate(ServiceComponentProp.java:146)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.build(ServiceComponentProp.java:347)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.InstanceProcess.buildComponent(InstanceProcess.java:620)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.InstanceProcess.buildComponents(InstanceProcess.java:197)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.Resolver.getEligible(Resolver.java:343)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.internal.ds.SCRManager.serviceChanged(SCRManager.java:222)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:107)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.internal.core.BundleContextImpl.dispatchEvent(BundleContextImpl.java:861)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:819)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:771)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.register(ServiceRegistrationImpl.java:130)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.registerService(ServiceRegistry.java:214)
>>>>>>>         at
>>>>>>> org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:433)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.http.servlet.internal.Activator.registerHttpService(Activator.java:81)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.http.servlet.internal.Activator.addProxyServlet(Activator.java:60)
>>>>>>>         at
>>>>>>> org.eclipse.equinox.http.servlet.internal.ProxyServlet.init(ProxyServlet.java:40)
>>>>>>>         at
>>>>>>> org.wso2.carbon.tomcat.ext.servlet.DelegationServlet.init(DelegationServlet.java:38)
>>>>>>>         at
>>>>>>> org.apache.catalina.core.StandardWrapper.initServlet(StandardWrapper.java:1279)
>>>>>>>         at
>>>>>>> org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1192)
>>>>>>>         at
>>>>>>> org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:1087)
>>>>>>>         at
>>>>>>> org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:5210)
>>>>>>>         at
>>>>>>> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5493)
>>>>>>>         at
>>>>>>> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
>>>>>>>         at
>>>>>>> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1559)
>>>>>>>         at
>>>>>>> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1549)
>>>>>>>         at
>>>>>>> java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
>>>>>>>         at java.util.concurrent.FutureTask.run(FutureTask.java:138)
>>>>>>>         at
>>>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
>>>>>>>         at
>>>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
>>>>>>>         at java.lang.Thread.run(Thread.java:695)
>>>>>>> Caused by: java.io.FileNotFoundException:
>>>>>>> /Users/prasanna/workspace/wso2/greg/git/prasanna/product-greg/modules/distribution/target/wso2greg-5.0.0-SNAPSHOT/repository/conf/etc/cassandra-environments.xml
>>>>>>> (No such file or directory)
>>>>>>>         at java.io.FileInputStream.open(Native Method)
>>>>>>>         at java.io.FileInputStream.<init>(FileInputStream.java:120)
>>>>>>>         at java.io.FileInputStream.<init>(FileInputStream.java:79)
>>>>>>>         at
>>>>>>> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:70)
>>>>>>>         at
>>>>>>> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:161)
>>>>>>>         at
>>>>>>> org.apache.xerces.impl.XMLEntityManager.setupCurrentEntity(Unknown 
>>>>>>> Source)
>>>>>>>         at
>>>>>>> org.apache.xerces.impl.XMLVersionDetector.determineDocVersion(Unknown
>>>>>>> Source)
>>>>>>>         at
>>>>>>> org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
>>>>>>>         at
>>>>>>> org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
>>>>>>>         at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>>>>>>>         at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
>>>>>>>         at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown
>>>>>>> Source)
>>>>>>>         at javax.xml.parsers.DocumentBuilder.parse(Unknown Source)
>>>>>>>         at
>>>>>>> org.wso2.carbon.cassandra.mgt.util.CassandraManagementUtils.convertToDocument(CassandraManagementUtils.java:162)
>>>>>>>         ... 63 more
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Do we need to remove Cassandra dependencies ?
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> --
>>>>>>> Prasanna Dangalla
>>>>>>> Software Engineer, WSO2, Inc.; http://wso2.com/
>>>>>>> lean.enterprise.middleware
>>>>>>>
>>>>>>> cell: +94 777 55 80 30 | +94 718 11 27 51
>>>>>>> twitter: @prasa77
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Dev mailing list
>>>>>>> [email protected]
>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Shiva Balachandran
>>>>>> Software Engineer
>>>>>> WSO2 Inc.
>>>>>>
>>>>>> Mobile - +94 774445788
>>>>>>
>>>>>> _______________________________________________
>>>>>> Dev mailing list
>>>>>> [email protected]
>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Harsha Kumara
>>>>> Software Engineer, WSO2 Inc.
>>>>> Mobile: +94775505618
>>>>> Blog:harshcreationz.blogspot.com
>>>>>
>>>>> _______________________________________________
>>>>> Dev mailing list
>>>>> [email protected]
>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> *Lasantha Fernando*
>>>> Software Engineer - Data Technologies Team
>>>> WSO2 Inc. http://wso2.com
>>>>
>>>> email: [email protected]
>>>> mobile: (+94) 71 5247551
>>>>
>>>
>>>
>>>
>>> --
>>> Harsha Kumara
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94775505618
>>> Blog:harshcreationz.blogspot.com
>>>
>>> _______________________________________________
>>> Dev mailing list
>>> [email protected]
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> *Bhathiya Jayasekara*
>> *Software Engineer,*
>> *WSO2 inc., http://wso2.com <http://wso2.com>*
>>
>> *Phone: +94715478185 <%2B94715478185>*
>> *LinkedIn: http://www.linkedin.com/in/bhathiyaj
>> <http://www.linkedin.com/in/bhathiyaj>*
>> *Twitter: https://twitter.com/bhathiyax <https://twitter.com/bhathiyax>*
>> *Blog: http://movingaheadblog.blogspot.com
>> <http://movingaheadblog.blogspot.com/>*
>>
>
>
>
> --
> Harsha Kumara
> Software Engineer, WSO2 Inc.
> Mobile: +94775505618
> Blog:harshcreationz.blogspot.com
>



-- 
*Lasantha Fernando*
Software Engineer - Data Technologies Team
WSO2 Inc. http://wso2.com

email: [email protected]
mobile: (+94) 71 5247551
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to