What do you meant by a service ? An OSGI service? +1 Go ahead with the solution #2.
Thanks & Regards Danushka Fernando Software Engineer WSO2 inc. http://wso2.com/ Mobile : +94716332729 On Tue, Oct 21, 2014 at 3:29 PM, Mahesh Chinthaka <[email protected]> wrote: > Hi all, > Im working on [1] > > In here we have to consider 3 classes > > 1. org.wso2.carbon.appfactory.repository.mgt.client > .AppfacotryRepositoryClient > 2. org.wso2.carbon.appfactory.core.deploy.AppfacotryRepositoryClient > 3. org.wso2.carbon.appfactory.deployers.clients > .AppfacotryRepositoryClient > > > > *org.wso2.carbon.appfactory.repository.mgt.client.AppfacotryRepositoryClient* > has already integrated with JGit plugin via *JGitAgent* class. > > Still *org.wso2.carbon.appfactory.core.deploy.AppfacotryRepositoryClient* > and > *org.wso2.carbon.appfactory.deployers.clients.AppfacotryRepositoryClient* > use *GitSCMClient*. Now we need to remove SCM plugin and integrate JGit > plugin to these two classes as well. > I see following approaches, > > 1. Implement same functionality which is in > *org.wso2.carbon.appfactory.repository.mgt.client.AppfacotryRepositoryClient* > for above both places. But this will cause code redundancy, I guess. > 2. Make > *org.wso2.carbon.appfactory.repository.mgt.client.AppfacotryRepositoryClient* > as a service and make it available to use in other two places. > > Please advise me in way forward. Suggest me a better approach please. > Thanks > > [1] - https://wso2.org/jira/browse/APPFAC-2328 > > -- > *Mahesh Chinthaka Vidanagama* | Software Engineer > WSO2, Inc | lean. enterprise. middleware. > #20, Palm Grove, Colombo 03, Sri Lanka > Mobile: +94 71 63 63 083 | Work: +94 112 145 345 > Email: [email protected] | Web: www.wso2.com >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
