Hi, In order to save the repetition, we can have ONE job-configuraitons inbuilt. Idea is, if an app type is added without a job this job configuration is taken as the default. We have to pick the most generic one in this case. I believe the interpreter language building would be the most generic case.
thanks, dimuthu On Tue, Nov 4, 2014 at 10:36 AM, Kasun De Silva <[email protected]> wrote: > Hi Danushka, > > Yes, that would be more generic, I will proceed with the above approach. > > Thanks, > Kasun > > *Kasun de Silva* > Software Engineer | *WSO2 Inc.*; http://wso2.com > lean.enterprise.middleware > > email : [email protected] > mobile : +94 77 794 4260 > > > On Tue, Nov 4, 2014 at 11:07 AM, Danushka Fernando <[email protected]> > wrote: > >> IIRC what Dimuthu asked for is to move all build configuration. No point >> of moving it just for one apptype. >> On Nov 4, 2014 9:38 AM, "Kasun De Silva" <[email protected]> wrote: >> >>> Hi Danushka, >>> >>> Are you suggesting to move all the jenkins job configurations currently >>> we have in to apptype processors, what my impression was we are doing that >>> for non maven and buildable apptypes like ASP.NET. Should we refactor >>> that improvement for maven apptype and other apptypes as well ? Dimuthu >>> WDYT ? >>> >>> Thanks, >>> Kasun >>> >>> *Kasun de Silva* >>> Software Engineer | *WSO2 Inc.*; http://wso2.com >>> lean.enterprise.middleware >>> >>> email : [email protected] >>> mobile : +94 77 794 4260 >>> >>> >>> On Sun, Nov 2, 2014 at 9:59 PM, Danushka Fernando <[email protected]> >>> wrote: >>> >>>> Since we are just replacing some values of this and we are passing it >>>> to jenkins I think we can do that. And with this I think we can get rid of >>>> the code we check for freestyle or maven type jobs and we can minimize the >>>> changes we do to the configuration from the code as well. So while work on >>>> this refactor the code as well. >>>> >>>> >>>> Thanks & Regards >>>> Danushka Fernando >>>> Software Engineer >>>> WSO2 inc. http://wso2.com/ >>>> Mobile : +94716332729 >>>> >>>> On Sun, Nov 2, 2014 at 8:34 PM, Kasun De Silva <[email protected]> wrote: >>>> >>>>> Hi All, >>>>> >>>>> I'm working on the $subject. I'm thinking that we can include the >>>>> jenkins job configuration inside the apptype as buildconfiguration.xml, >>>>> similar to apptype.xml for non maven and buildable apptypes, and while >>>>> deploying the apptype we can add the job configuration to application type >>>>> bean. So that we can access it when it needed from the jenkins job >>>>> configurator. WDYT of this approach ? >>>>> >>>>> Thanks, >>>>> Kasun >>>>> >>>>> *Kasun de Silva* >>>>> Software Engineer | *WSO2 Inc.*; http://wso2.com >>>>> lean.enterprise.middleware >>>>> >>>>> email : [email protected] >>>>> mobile : +94 77 794 4260 >>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>> > -- Dimuthu Leelarathne Architect & Product Lead of App Factory WSO2, Inc. (http://wso2.com) email: [email protected] Mobile : 0773661935 Lean . Enterprise . Middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
