Hi , Following are the code review notes. Provide more meaningful error messages when logging errors. Properly configure Intellij idea for short cut keys and disable OS level short cuts. Use template for generate WSO2-License files.
Introduce Manager level class which is outside from HTTP inbound endpoint implementation to start and stop IO reactor. Introduce API in passthru transport level to reuse codes in Passthru transport code. Remove deprecated methods and upgrade to HttpCore newer version. On Fri, Nov 7, 2014 at 1:50 PM, Isuru Ranawaka <[email protected]> wrote: > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=NnZ2cmIxZHE0NzA4bTMzYWIxbWxsZWdraDQgZGV2QHdzbzIub3Jn&tok=MTUjaXN1cnVyQHdzbzIuY29tYmE5NzRjYjVmM2M2ZmJjZTNhYzFkZjVjMDkzMTI3MTVlYjgyN2M0NQ&ctz=Asia/Colombo&hl=en> > Http Inbound Endpoint Code Review -Part 2 > *When* > Mon Nov 10, 2014 2pm – 3pm Colombo > *Where* > 1 st Floor Meeting Room (map > <https://maps.google.lk/maps?q=1+st+Floor+Meeting+Room&hl=en>) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/http-inbound > <https://plus.google.com/hangouts/_/wso2.com/http-inbound?hceid=aXN1cnVyQHdzbzIuY29t.6vvrb1dq4708m33ab1mllegkh4> > *Calendar* > Isuru Ranawaka > *Who* > • > Isuru Ranawaka - organizer > • > Srinath Perera > • > Ravi Undupitiya > • > Afkham Azeez > • > Shafreen Anfar > • > Ishan Jayawardena > • > Isuru Udana > • > Sandamal Weerasinghe > • > Malaka Silva > • > Chanaka Fernando > • > Jeewantha Dharmaparakrama > • > Kasun Indrasiri > • > Ravindra Ranwala > • > [email protected] > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=NnZ2cmIxZHE0NzA4bTMzYWIxbWxsZWdraDQgZGV2QHdzbzIub3Jn&rst=1&tok=MTUjaXN1cnVyQHdzbzIuY29tYmE5NzRjYjVmM2M2ZmJjZTNhYzFkZjVjMDkzMTI3MTVlYjgyN2M0NQ&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=NnZ2cmIxZHE0NzA4bTMzYWIxbWxsZWdraDQgZGV2QHdzbzIub3Jn&rst=3&tok=MTUjaXN1cnVyQHdzbzIuY29tYmE5NzRjYjVmM2M2ZmJjZTNhYzFkZjVjMDkzMTI3MTVlYjgyN2M0NQ&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=NnZ2cmIxZHE0NzA4bTMzYWIxbWxsZWdraDQgZGV2QHdzbzIub3Jn&rst=2&tok=MTUjaXN1cnVyQHdzbzIuY29tYmE5NzRjYjVmM2M2ZmJjZTNhYzFkZjVjMDkzMTI3MTVlYjgyN2M0NQ&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=NnZ2cmIxZHE0NzA4bTMzYWIxbWxsZWdraDQgZGV2QHdzbzIub3Jn&tok=MTUjaXN1cnVyQHdzbzIuY29tYmE5NzRjYjVmM2M2ZmJjZTNhYzFkZjVjMDkzMTI3MTVlYjgyN2M0NQ&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this courtesy email at the account [email protected] because > you are an attendee of this event. > > To stop receiving future updates for this event, decline this event. > Alternatively you can sign up for a Google account at > https://www.google.com/calendar/ and control your notification settings > for your entire calendar. > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Best Regards Isuru Ranawaka M: +94714629880 Blog : http://isurur.blogspot.com/
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
