Applied the patch. On a side note, don't resolve the jira until the fix is applied and verified.
On Fri, Nov 28, 2014 at 3:40 PM, Thushara Ranawaka <[email protected]> wrote: > Hi Kishanthan, > > Corrected the formatting issues. Kindly apply the patch attached in > Jira[1]. > Note: removed the newline > > [1] https://wso2.org/jira/browse/CARBON-15092 > > Thanks, > > On Fri, Nov 28, 2014 at 3:16 PM, Kishanthan Thangarajah < > [email protected]> wrote: > >> Thusara, I'm still seeing some formatting issues with this patch. >> >> On Thu, Nov 27, 2014 at 3:02 PM, Thushara Ranawaka <[email protected]> >> wrote: >> >>> Hi Kishanthan, >>> >>> Corrected the formatting issues. Kindly apply the patch attached in >>> Jira[1]. >>> >>> [1] https://wso2.org/jira/browse/CARBON-15092 >>> >>> Thanks, >>> >>> >>> On Thu, Nov 27, 2014 at 12:27 PM, Kishanthan Thangarajah < >>> [email protected]> wrote: >>> >>>> This fix is adding a deprecated tag for a public API. Any reason for >>>> this? Also this patch has some formatting issues. Please fix that and send >>>> it again. >>>> >>>> + @Deprecated >>>> public void shutdown() throws ClusteringFault { >>>> try { >>>> Hazelcast.shutdownAll(); >>>> >>>> >>>> On Wed, Nov 26, 2014 at 4:52 PM, Thushara Ranawaka <[email protected]> >>>> wrote: >>>> >>>>> Hi Kishanthan/Manoj, >>>>> >>>>> Kindly apply the patch attached in Jira[1]. >>>>> >>>>> [1] https://wso2.org/jira/browse/CARBON-15092 >>>>> >>>>> Thanks, >>>>> -- >>>>> Thushara Kasun Ranawaka >>>>> Software Engineer >>>>> WSO2 Inc.; <http://www.wso2.com> >>>>> lean.enterprise.middleware >>>>> Mobile : *+94 (0) 773438949 <%2B94%20%280%29%20773438949>* >>>>> *[email protected] <[email protected]>* >>>>> >>>> >>>> >>>> >>>> -- >>>> *Kishanthan Thangarajah* >>>> Senior Software Engineer, >>>> Platform Technologies Team, >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - +94773426635 >>>> Blog - *http://kishanthan.wordpress.com >>>> <http://kishanthan.wordpress.com>* >>>> Twitter - *http://twitter.com/kishanthan >>>> <http://twitter.com/kishanthan>* >>>> >>> >>> >>> >>> -- >>> Thushara Kasun Ranawaka >>> Software Engineer >>> WSO2 Inc.; <http://www.wso2.com> >>> lean.enterprise.middleware >>> Mobile : *+94 (0) 773438949 <%2B94%20%280%29%20773438949>* >>> *[email protected] <[email protected]>* >>> >> >> >> >> -- >> *Kishanthan Thangarajah* >> Senior Software Engineer, >> Platform Technologies Team, >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - +94773426635 >> Blog - *http://kishanthan.wordpress.com >> <http://kishanthan.wordpress.com>* >> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* >> > > > > -- > Thushara Kasun Ranawaka > Software Engineer > WSO2 Inc.; <http://www.wso2.com> > lean.enterprise.middleware > Mobile : *+94 (0) 773438949 <%2B94%20%280%29%20773438949>* > *[email protected] <[email protected]>* > -- *Kishanthan Thangarajah* Senior Software Engineer, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
