In this case it's only needs the configuration and no need of depend on the other feature. Is there any possibility of separating this configuration? I didn't check on how the configuration is use by both of these features. I think we should depend on primary feature if other feature required components of primary feature. IMO Depend on primary feature to only get the configuration file will not be appropriate.
On Tue, Dec 2, 2014 at 11:25 PM, Chan <[email protected]> wrote: > In Git - the is no version controlling for files - it's for a repository. > Unless we can make that file a repo of it's own, we can't use git modules. > I am +1 for Kicha's solution. Primary feature owns the file and other > features that uses the file needs to add the primary feature as a > dependency. > > Cheers~ > > On Tue, Dec 2, 2014 at 5:59 AM, Johann Nallathamby <[email protected]> > wrote: > >> IMHO sharing a single configuration file among multiple features is not >> that bad compared to maintaining different versions of the same file in >> different products. That's what creates problems. E.g. identity.xml is >> maintained by API Manager separately and that creates problems. >> >> I don't think we have ruled out, multiple features sharing the same file. >> E.g. identity.xml is the main configuration file shared by all identity >> features. If we are going to maintain separate files for each feature that >> is going to be a difficult for users. >> >> The svn externals solution was a clean way of doing this in svn. We need >> to find similar solution in Git. If you are going to say one file per >> feature that rule needs to be implemented strictly in all features. >> >> On Tue, Dec 2, 2014 at 6:07 PM, Kishanthan Thangarajah < >> [email protected]> wrote: >> >>> There can be only one feature which own a specific resources (es : a >>> configuration file). If another feature is trying to include this resource >>> then it is wrong. >>> >>> We can make the second feature depend on the first, so that when second >>> gets installed, first one also gets installed and available (during which >>> the relevant resources also gets copied) >>> Or merge these two features and make a single feature. >>> >>> On Tue, Dec 2, 2014 at 12:47 PM, Johann Nallathamby <[email protected]> >>> wrote: >>> >>>> It is actually coming from application-authentication-framework >>>> feature. Not from product level. In svn the ideal way would be to have svn >>>> externals. But in Git I am not sure how we handle this. Duplicating this >>>> file will be a nightmare. AFAIK in Git there is a similar way to do this. >>>> >>>> On Tue, Dec 2, 2014 at 12:40 PM, Harsha Kumara <[email protected]> >>>> wrote: >>>> >>>>> Hi All, >>>>> >>>>> In Storage Server we are using application management server feature >>>>> for custom permission implementation. But application management feature >>>>> requires application-authentication.xml which is not bundled with the >>>>> feature. I think it's not appropriate to keep configuration in product >>>>> itself. This configuration is coming from application authentication >>>>> framework feature. Is it Ok to include this xml in application management >>>>> feature as well? If else, what would be the approach to do it? >>>>> >>>>> Thanks, >>>>> Harsha >>>>> >>>>> -- >>>>> Harsha Kumara >>>>> Software Engineer, WSO2 Inc. >>>>> Mobile: +94775505618 >>>>> Blog:harshcreationz.blogspot.com >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> >>>> *Johann Dilantha Nallathamby* >>>> Associate Technical Lead & Product Lead of WSO2 Identity Server >>>> Integration Technologies Team >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - *+94777776950* >>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>> >>> >>> >>> >>> -- >>> *Kishanthan Thangarajah* >>> Senior Software Engineer, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >> >> >> >> -- >> Thanks & Regards, >> >> *Johann Dilantha Nallathamby* >> Associate Technical Lead & Product Lead of WSO2 Identity Server >> Integration Technologies Team >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - *+94777776950* >> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >> > > > > -- > Chan (Dulitha Wijewantha) > Software Engineer - Mobile Development > WSO2 Inc > Lean.Enterprise.Mobileware > * ~Email [email protected] <[email protected]>* > * ~Mobile +94712112165 <%2B94712112165>* > * ~Website dulitha.me <http://dulitha.me>* > * ~Twitter @dulitharw <https://twitter.com/dulitharw>* > *~Github @dulichan <https://github.com/dulichan>* > *~SO @chan <http://stackoverflow.com/users/813471/chan>* > -- Harsha Kumara Software Engineer, WSO2 Inc. Mobile: +94775505618 Blog:harshcreationz.blogspot.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
