Hi Kishanthan, As per the discussion had with you, I removed @Deprecated and attached the diff to jira, will send the pull request with @Deprecated.
Thanks Godwin On Thu, Dec 4, 2014 at 2:07 PM, Kishanthan Thangarajah <[email protected]> wrote: > What is the reason to deprecate these two methods? We don't deprecate > API's when patching. > > + @Deprecated > protected String createAdminEntry(String dnOfUserContext, Tenant > tenant, > DirContext initialDirContext) > throws UserStoreException { > @@ -394,6 +397,7 @@ > return userDN; > } > > + @Deprecated > protected void createAdminGroup(String dnOfGroupContext, String > adminUserDN, > DirContext initialDirContext) > throws UserStoreException { > > On Wed, Dec 3, 2014 at 12:53 PM, Godwin Amila Shrimal <[email protected]> > wrote: > >> Hi Carbon Team, >> >> Please commit the diff attached with [1] >> >> >> [1] - https://wso2.org/jira/browse/IDENTITY-2915 >> >> >> Thanks >> Godwin >> >> >> -- >> *Godwin Amila Shrimal* >> Senior Software Engineer >> WSO2 Inc.; http://wso2.com >> lean.enterprise.middleware >> >> mobile: *+94772264165* >> linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* >> twitter: https://twitter.com/godwinamila >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Kishanthan Thangarajah* > Senior Software Engineer, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > -- *Godwin Amila Shrimal* Senior Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: *+94772264165* linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* twitter: https://twitter.com/godwinamila
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
