Please find code review notes below.
Participants: Suho, Lasantha, Sachini, Damith, Chanika, Ramindu
1. Make mappings configs configurable to user
2. Remove DB name from general mappings
3. change mapping config as
<mapping>
<key>...</key>
<value>...</value>
</mapping>
4. Close xml stream only if not null in RdbmsEventAdaptorType
5. Return resolved mappings at TypeManager without exposing resolver
6. Log if message type is not message in RdbmsEventAdaptorType
7. Remove database name attribute from TableInfo
8. Add further improvements/features and perform another code review later
this week.
Thanks,
Tishan
On Sun, Dec 7, 2014 at 5:01 PM, Damith Wickramasinghe <[email protected]>
wrote:
> more details »
> <https://www.google.com/calendar/event?action=VIEW&eid=MmpkMzRmdmFuZDNsYWZhcXZsNTVhazh2cWsgdGlzaGFuQHdzbzIuY29t&tok=MTYjZGFtaXRobkB3c28yLmNvbTFiYzEzZjA1YjlhODAyMWExYzMwMDhkNmQwZTg1ZTRiMDk0OWFkNWU&ctz=Asia/Colombo&hl=en>
> RDBMS Output Adapter Code Review
> *When*
> Mon Dec 8, 2014 2pm – 3pm Colombo
> *Where*
> LK 3rd Floor Meeting Room - Kernel (map
> <https://maps.google.lk/maps?q=LK+3rd+Floor+Meeting+Room+-+Kernel&hl=en>)
> *Video call*
> https://plus.google.com/hangouts/_/wso2.com/rdbms-output
> <https://plus.google.com/hangouts/_/wso2.com/rdbms-output?hceid=ZGFtaXRobkB3c28yLmNvbQ.2jd34fvand3lafaqvl55ak8vqk>
> *Calendar*
> Tishan Dahanayakage
> *Who*
> •
> Damith Wickramasinghe - organizer
> •
> Rajeev Sampath
> •
> Sriskandarajah Suhothayan
> •
> Sachini Jayasekara
> •
> Lasantha Fernando
> •
> [email protected]
> •
> Tishan Dahanayakage
> •
> Mohanadarshan Vivekanandalingam
>
> Going? *Yes
> <https://www.google.com/calendar/event?action=RESPOND&eid=MmpkMzRmdmFuZDNsYWZhcXZsNTVhazh2cWsgdGlzaGFuQHdzbzIuY29t&rst=1&tok=MTYjZGFtaXRobkB3c28yLmNvbTFiYzEzZjA1YjlhODAyMWExYzMwMDhkNmQwZTg1ZTRiMDk0OWFkNWU&ctz=Asia/Colombo&hl=en>
> - Maybe
> <https://www.google.com/calendar/event?action=RESPOND&eid=MmpkMzRmdmFuZDNsYWZhcXZsNTVhazh2cWsgdGlzaGFuQHdzbzIuY29t&rst=3&tok=MTYjZGFtaXRobkB3c28yLmNvbTFiYzEzZjA1YjlhODAyMWExYzMwMDhkNmQwZTg1ZTRiMDk0OWFkNWU&ctz=Asia/Colombo&hl=en>
> - No
> <https://www.google.com/calendar/event?action=RESPOND&eid=MmpkMzRmdmFuZDNsYWZhcXZsNTVhazh2cWsgdGlzaGFuQHdzbzIuY29t&rst=2&tok=MTYjZGFtaXRobkB3c28yLmNvbTFiYzEzZjA1YjlhODAyMWExYzMwMDhkNmQwZTg1ZTRiMDk0OWFkNWU&ctz=Asia/Colombo&hl=en>*
> more options »
> <https://www.google.com/calendar/event?action=VIEW&eid=MmpkMzRmdmFuZDNsYWZhcXZsNTVhazh2cWsgdGlzaGFuQHdzbzIuY29t&tok=MTYjZGFtaXRobkB3c28yLmNvbTFiYzEzZjA1YjlhODAyMWExYzMwMDhkNmQwZTg1ZTRiMDk0OWFkNWU&ctz=Asia/Colombo&hl=en>
>
> Invitation from Google Calendar <https://www.google.com/calendar/>
>
> You are receiving this email at the account [email protected] because you
> are subscribed for invitations on calendar Tishan Dahanayakage.
>
> To stop receiving these emails, please log in to
> https://www.google.com/calendar/ and change your notification settings
> for this calendar.
>
--
Tishan Dahanayakage
Software Engineer
WSO2, Inc.
Mobile:+94 716481328
Disclaimer: This communication may contain privileged or other confidential
information and is intended exclusively for the addressee/s. If you are not
the intended recipient/s, or believe that you may have received this
communication in error, please reply to the sender indicating that fact and
delete the copy you received and in addition, you should not print, copy,
re-transmit, disseminate, or otherwise use the information contained in
this communication. Internet communications cannot be guaranteed to be
timely, secure, error or virus-free. The sender does not accept liability
for any errors or omissions.
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev
