+1 for make it withing the class, if convert to lowercase is must to have for stratos cartridge alias.
harshat@mobile On Dec 10, 2014 7:33 AM, "Danushka Fernando" <[email protected]> wrote: > Hi All > AF is subscribing to stratos cartridges in two places. > > 1. For multi tenant cartridges at tenant creation > 2. For single tenant cartridges at app creation > > Earlier for appserver cartridges for three stages we name them as asdev, > astest, asprod. But with the implementation of separating runtimes we need > change them to append stage to the given prefix in runtime config. (for > eg:- as). So they will be asDevelopment, asProduction, asTesting. However > we need to have all small letters in alias and cartridge type. So we need > to change them to asdevelopment, astesting, asproduction. In code level we > need to convert this alias and type to lowercase. > > In the implementation we have implemented a class named StratosRestService to > subscribe to the cartridge using stratos rest service. This class will call > the rest service with given parameters. So where should this toLowerCase > should call from following option. > > 1. Within the StratosRestService which will cause to do it one place. > 2. The places that calling StratosRestService which will cause to do it > in multiple places. > > IMO this is about whats the StratosRestService class's responsibilities. > WDYT? > > Thanks & Regards > Danushka Fernando > Software Engineer > WSO2 inc. http://wso2.com/ > Mobile : +94716332729 >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
