+1 for keep this JenkinsStratosUndeployer class withing Jenkins plugin.
*Harsha Thirimanna* Senior Software Engineer; WSO2, Inc.; http://wso2.com * <http://www.apache.org/>* *email: **[email protected]* <[email protected]>* cell: +94 71 5186770 , +94 * *774617784twitter: **http://twitter.com/ <http://twitter.com/afkham_azeez>* *harshathirimannlinked-in: **http: <http://lk.linkedin.com/in/afkhamazeez>**//www.linkedin.com/pub/harsha-thirimanna/10/ab8/122 <http://www.linkedin.com/pub/harsha-thirimanna/10/ab8/122>* *Lean . Enterprise . Middleware* On Tue, Dec 16, 2014 at 10:17 AM, Manjula Rathnayake <[email protected]> wrote: > > Hi Danushka, > > +1 for separating out APIs and implementations into multiple bundles. But > this org.wso2.carbon.appfactory.deployers contains other implementations > such as StratosDeployer too. So we need to re-factor these classes too. > Hence it is ok to keep JenkinsStratosUndeployer as it is, without > introducing major re-factoring at this stage(completing the alpha features > first and attend to these tasks later). > > thank you. > > On Mon, Dec 15, 2014 at 7:31 PM, Danushka Fernando <[email protected]> > wrote: >> >> Hi AF devs, >> IIRC deployers package contains all interfaces and abstract classes and >> what ever connector we write to a deploy system we should write an >> implementation. Correct me if I am wrong. >> In that case IMO JenkinsStratosUndeployer should go in to the jenkins >> plugins not in to the deployers package. WDYT? >> >> >> Thanks & Regards >> Danushka Fernando >> Software Engineer >> WSO2 inc. http://wso2.com/ >> Mobile : +94716332729 >> > > > -- > Manjula Rathnayaka > Software Engineer > WSO2, Inc. > Mobile:+94 77 743 1987 > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
