Please find code review notes below. Participants: Suho, Damith, Lasantha, Sachini, Ramindu
1. Update tool tip used for field 'composite key columns' specifying to use commas when multiple attributes are used (this is only needed for update or insert mode) 2. Move "execution mode" filed before the "composite key columns" 3. Change insert or update to update or insert in "execution mode" field. 4. Make the variable executionInfo a local variable, Don't create hash map again and again, instead create it once and use it 5. Rename variable insertColumnList to insertQueryColumOrder 6. Without checking the execution mode again and again use the variable to get the mode 7. In executeProcessAction method : create a new variable called nextConnectionTime and use it for if conditions 8. Implement reomoveConnectionInfo method and remove message configs and other cleanup tasks should be done there. Thanks On Tue, Dec 16, 2014 at 12:14 PM, Damith Wickramasinghe <[email protected]> wrote: > > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=czRxa2lkNHRoNmxsNzhsa2U3bThoMDk5MTggc2FjaGluaWpAd3NvMi5jb20&tok=MTYjZGFtaXRobkB3c28yLmNvbWQwZGZmMWE2NWJlNTgwZTY0OWYwZmI0MjU1M2ZhYmI3NmEyODdkOTY&ctz=Asia/Colombo&hl=en> > RDBMS Output Adapter Code Review > *When* > Tue Dec 16, 2014 1pm – 1:30pm Colombo > *Where* > LK 6th Floor Meeting Room - Dijkstra (map > <https://maps.google.lk/maps?q=LK+6th+Floor+Meeting+Room+-+Dijkstra&hl=en> > ) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/rdbms-output > <https://plus.google.com/hangouts/_/wso2.com/rdbms-output?hceid=ZGFtaXRobkB3c28yLmNvbQ.s4qkid4th6ll78lke7m8h09918> > *Calendar* > Sachini Jayasekara > *Who* > • > Damith Wickramasinghe - organizer > • > Lasantha Fernando > • > [email protected] > • > Tishan Dahanayakage > • > Ramindu De Silva > • > Sriskandarajah Suhothayan > • > Sachini Jayasekara > • > Rajeev Sampath > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=czRxa2lkNHRoNmxsNzhsa2U3bThoMDk5MTggc2FjaGluaWpAd3NvMi5jb20&rst=1&tok=MTYjZGFtaXRobkB3c28yLmNvbWQwZGZmMWE2NWJlNTgwZTY0OWYwZmI0MjU1M2ZhYmI3NmEyODdkOTY&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=czRxa2lkNHRoNmxsNzhsa2U3bThoMDk5MTggc2FjaGluaWpAd3NvMi5jb20&rst=3&tok=MTYjZGFtaXRobkB3c28yLmNvbWQwZGZmMWE2NWJlNTgwZTY0OWYwZmI0MjU1M2ZhYmI3NmEyODdkOTY&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=czRxa2lkNHRoNmxsNzhsa2U3bThoMDk5MTggc2FjaGluaWpAd3NvMi5jb20&rst=2&tok=MTYjZGFtaXRobkB3c28yLmNvbWQwZGZmMWE2NWJlNTgwZTY0OWYwZmI0MjU1M2ZhYmI3NmEyODdkOTY&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=czRxa2lkNHRoNmxsNzhsa2U3bThoMDk5MTggc2FjaGluaWpAd3NvMi5jb20&tok=MTYjZGFtaXRobkB3c28yLmNvbWQwZGZmMWE2NWJlNTgwZTY0OWYwZmI0MjU1M2ZhYmI3NmEyODdkOTY&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for invitations on calendar Sachini Jayasekara. > > To stop receiving these emails, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- *Thanks & Regards,Sachini JayasekaraSoftware Engineer; **WSO2 Inc. * *lean . enterprise . middleware | http://wso2.com <http://wso2.com> *
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
