Hi Sameera, I have updated the pull request and replied to the comments. Please review and merge.
Thanks, Harsha On Fri, Dec 19, 2014 at 7:39 PM, Sameera Jayasoma <[email protected]> wrote: > I put some comments to the PR. Please check and reply. > > Thanks, > Sameera. > > On Fri, Dec 19, 2014 at 5:25 PM, Ramith Jayasinghe <[email protected]> > wrote: >> >> Hi Sameera, >> Could we have this reviewed and merged? >> regards >> Ramith >> >> On Thu, Dec 18, 2014 at 4:02 PM, Harsha Kumara <[email protected]> wrote: >> >>> Hi Ramith/Prabath, >>> >>> Asitha and myself tested the CQL upgrade and found that there a is a >>> dependency issue with hector as it required cassandra thrift dependency. >>> Previously, older version of CQL needed Cassandra as a dependency which >>> includes thrift. With the latest upgrade, we CQL does not depend on >>> Cassandra and can be used as it is because of it's already a OSGi bundle. >>> Since cassandra thrift needed for hector, I have created orbit bundle for >>> cassandra-thrift version 1.2.13.wso2v4. Previous versions of cassandra >>> thrift has some issues with their dependencies. >>> >>> Pull request in [1] needs to merge and deploy before upgrading the CQL >>> version in data reader component. >>> >>> [1] - https://github.com/wso2/orbit/pull/46/files >>> >>> Thanks, >>> Harsha >>> >>> On Wed, Dec 10, 2014 at 4:08 PM, Ramith Jayasinghe <[email protected]> >>> wrote: >>>> >>>> we need to test a new driver on cassandra ring (with a MB load test). >>>> >>>> On Wed, Dec 10, 2014 at 3:55 PM, Harsha Kumara <[email protected]> >>>> wrote: >>>> >>>>> Hi All, >>>>> >>>>> Since there are number of improvements made for the latest CQL driver, >>>>> we are going to upgrade CQL driver to the latest version which also need >>>>> for MB as well. Current version is 1.0.8.wso2v1 which we added as orbit >>>>> bundle due to dependency conflicts in OSGi environment. With the latest >>>>> release, they have removed cassandra and jackson dependencies from CQL >>>>> driver. We most probably can update the CQL driver to the 2.1.3 without a >>>>> orbit bundle. >>>>> >>>>> Since there are some API changes, we will needs to fix them. Please >>>>> find [1] and [2] as upgrade instructions from datastax. >>>>> >>>>> We are now testing the cql upgrade with latest version from >>>>> https://github.com/wso2-dev/carbon-storage-management/tree/cql_upgrade >>>>> branch, >>>>> >>>>> @Asitha,Madhawa can you update the thread whether data reader feature >>>>> with the latest CQL driver works as expected in MB? >>>>> >>>>> [1] -hhttps:// >>>>> github.com/datastax/java-driver/blob/2.0/driver-core/Upgrade_guide_to_2.0.rst >>>>> [2] - >>>>> https://github.com/datastax/java-driver/blob/2.1/driver-core/Upgrade_guide_to_2.1.rst >>>>> [3] -https://github.com/datastax/java-driver >>>>> >>>>> Thanks, >>>>> Harsha >>>>> >>>>> -- >>>>> Harsha Kumara >>>>> Software Engineer, WSO2 Inc. >>>>> Mobile: +94775505618 >>>>> Blog:harshcreationz.blogspot.com >>>>> >>>> >>>> >>>> >>>> -- >>>> Ramith Jayasinghe >>>> Technical Lead >>>> WSO2 Inc., http://wso2.com >>>> lean.enterprise.middleware >>>> >>>> E: [email protected] >>>> P: +94 777542851 >>>> >>>> >>> >>> -- >>> Harsha Kumara >>> Software Engineer, WSO2 Inc. >>> Mobile: +94775505618 >>> Blog:harshcreationz.blogspot.com >>> >> >> >> >> -- >> Ramith Jayasinghe >> Technical Lead >> WSO2 Inc., http://wso2.com >> lean.enterprise.middleware >> >> E: [email protected] >> P: +94 777542851 >> >> > > -- > Sameera Jayasoma, > Software Architect, > > WSO2, Inc. (http://wso2.com) > email: [email protected] > blog: http://sameera.adahas.org > twitter: https://twitter.com/sameerajayasoma > flickr: http://www.flickr.com/photos/sameera-jayasoma/collections > Mobile: 0094776364456 > > Lean . Enterprise . Middleware > > -- Harsha Kumara Software Engineer, WSO2 Inc. Mobile: +94775505618 Blog:harshcreationz.blogspot.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
