Hi Malaka,

As per our new orbit guidelines (Which are yet to be documented), I noticed
following issue in the orbit bundle.

1)  Empty Import-Package header. We need to properly put the list of
packages to be imported.

+ <Import-Package>+ *;resolution:=optional + </Import-Package>

2) Embedding of Rhino dependency. I believe we have a Rhino orbit bundle.
Can we use that instead of embedding Rhino?

3) Please put version when exporting packages in the Export-Package section.

4) Usage of the DynamicImport-Package. We need to check whether we need
this header.

Thanks,
Sameera.


On Mon, Jan 5, 2015 at 5:16 PM, Malaka Silva <[email protected]> wrote:

> Hi Maheshika,
>
> Please merge [1]
>
> There was an issue with org.apache.bsf version 3.0.0.wso2v3 pom.xml
>
> I have fixed this with version 3.0.0.wso2v4
>
> [1] https://github.com/wso2/orbit/pull/45
>
>
>
> On Thu, Dec 18, 2014 at 3:43 PM, Malaka Silva <[email protected]> wrote:
>
>> Hi Carbon Team,
>>
>> Please merge the pull request [1]
>>
>> [1] https://github.com/wso2/orbit/pull/45
>>
>> Best Regards,
>>
>> Malaka Silva
>> Senior Tech Lead
>> M: +94 777 219 791
>> Tel : 94 11 214 5345
>> Fax :94 11 2145300
>> Skype : malaka.sampath.silva
>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
>> Blog : http://mrmalakasilva.blogspot.com/
>>
>> WSO2, Inc.
>> lean . enterprise . middleware
>> http://www.wso2.com/
>> http://www.wso2.com/about/team/malaka-silva/
>> <http://wso2.com/about/team/malaka-silva/>
>>
>> Save a tree -Conserve nature & Save the world for your future. Print this
>> email only if it is absolutely necessary.
>>
>
>
>
> --
>
> Best Regards,
>
> Malaka Silva
> Senior Tech Lead
> M: +94 777 219 791
> Tel : 94 11 214 5345
> Fax :94 11 2145300
> Skype : malaka.sampath.silva
> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
> Blog : http://mrmalakasilva.blogspot.com/
>
> WSO2, Inc.
> lean . enterprise . middleware
> http://www.wso2.com/
> http://www.wso2.com/about/team/malaka-silva/
> <http://wso2.com/about/team/malaka-silva/>
>
> Save a tree -Conserve nature & Save the world for your future. Print this
> email only if it is absolutely necessary.
>



-- 
Sameera Jayasoma,
Software Architect,

WSO2, Inc. (http://wso2.com)
email: [email protected]
blog: http://sameera.adahas.org
twitter: https://twitter.com/sameerajayasoma
flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
Mobile: 0094776364456

Lean . Enterprise . Middleware
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to