Hi Azeez, On Fri, Jan 9, 2015 at 5:26 PM, Afkham Azeez <[email protected]> wrote:
> Put the debug check condition always. Follow it religiously. > Why do we need to do this for single lines of debug logs? Any particular reason or just as a convention? Thanks, Bhathiya > > On Fri, Jan 9, 2015 at 5:09 PM, Gayan Gunawardana <[email protected]> wrote: > >> Hi All, >> >> Currently I am going through user core exception handling and identifying >> changes required to do. >> >> In user core [1] there are couple of places debug logs exists without >> isDebugEnabled check. >> >> Ex:getSearchBaseDirectoryContext(), setUserClaims() >> >> Is there any rule for places where we can ignore isDebugEnabled check or >> should we do isDebugEnabled check always? >> >> [1] >> https://github.com/wso2-dev/carbon4-kernel/blob/master/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/ldap/ReadWriteLDAPUserStoreManager.java >> -- >> Gayan Gunawardana >> Software Engineer; WSO2 Inc.; http://wso2.com/ >> Email: [email protected] >> Mobile: +94 (71) 8020933 >> > > > > -- > *Afkham Azeez* > Director of Architecture; WSO2, Inc.; http://wso2.com > Member; Apache Software Foundation; http://www.apache.org/ > * <http://www.apache.org/>* > *email: **[email protected]* <[email protected]> > * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * > *http://blog.afkham.org* <http://blog.afkham.org> > *twitter: **http://twitter.com/afkham_azeez* > <http://twitter.com/afkham_azeez> > *linked-in: **http://lk.linkedin.com/in/afkhamazeez > <http://lk.linkedin.com/in/afkhamazeez>* > > *Lean . Enterprise . Middleware* > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Bhathiya Jayasekara* *Software Engineer,* *WSO2 inc., http://wso2.com <http://wso2.com>* *Phone: +94715478185* *LinkedIn: http://www.linkedin.com/in/bhathiyaj <http://www.linkedin.com/in/bhathiyaj>* *Twitter: https://twitter.com/bhathiyax <https://twitter.com/bhathiyax>* *Blog: http://movingaheadblog.blogspot.com <http://movingaheadblog.blogspot.com/>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
