A gentle reminder! On Tue, Nov 18, 2014 at 10:24 PM, Gayan Gunawardana <[email protected]> wrote:
> Hi Sagara, > > New pull request [1]. > > [1] https://github.com/wso2-dev/carbon-deployment/pull/45/files > > Thanks, > Gayan > > On Thu, Aug 14, 2014 at 9:51 PM, Sagara Gunathunga <[email protected]> > wrote: > >> >> >> Hi Gayan, >> >> While I'm building carbon-deployment project with your PR I'm getting >> following compilation issues. Please make sure you can build both >> carbon-deployment and product-as with your change. >> >> [ERROR] >> /Users/sagara/dev/code/wso2/wso2-dev/carbon-deployment/components/webapp-mgt/org.wso2.carbon.cxf.ext/src/main/java/org/wso2/carbon/webapp/ext/jaxrs/designator/Patch.java:[32,9] >> class PATCH is public, should be declared in a file named PATCH.java >> >> [ERROR] >> /Users/sagara/dev/code/wso2/wso2-dev/carbon-deployment/components/webapp-mgt/org.wso2.carbon.cxf.ext/src/main/java/org/wso2/carbon/webapp/ext/jaxrs/designator/Patch.java:[22,19] >> package javax.ws.rs does not exist >> >> Thanks ! >> >> >> >> On Wed, Jul 30, 2014 at 11:49 AM, Gayan Gunawardana <[email protected]> >> wrote: >> >>> Hi, >>> >>> Please find [1]. I couldn't mention in the previous mail. >>> >>> [1] https://github.com/wso2-dev/product-as/pull/19 >>> <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fwso2-dev%2Fproduct-as%2Fpull%2F19&sa=D&sntz=1&usg=AFQjCNFOYnhXm0GYbpzmCxh0bK1lGinM6w> >>> >>> >>> On Tue, Jul 29, 2014 at 11:55 PM, Sagara Gunathunga <[email protected]> >>> wrote: >>> >>>> >>>> >>>> Hi Gayan, >>>> >>>> I couldn't find any PR related to a test case, can you please attend to >>>> needful ? >>>> >>>> Thanks ! >>>> >>>> On Tue, Jul 29, 2014 at 2:33 PM, Gayan Gunawardana <[email protected]> >>>> wrote: >>>> >>>>> Hi All, >>>>> >>>>> Please review and merge [1] >>>>> >>>>> [1] https://github.com/wso2-dev/carbon-deployment/pull/13 >>>>> >>>>> Thanks, >>>>> Gayan >>>>> >>>>> >>>>> On Fri, Jul 25, 2014 at 9:54 PM, Prabath Siriwardena <[email protected] >>>>> > wrote: >>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Jul 25, 2014 at 9:52 PM, Sagara Gunathunga <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Jul 25, 2014 at 5:37 PM, Gayan Gunawardana <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi All, >>>>>>>> >>>>>>>> I have added custom implementation for PATCH as mention in [1]. >>>>>>>> What is the package naming convention we can use for this >>>>>>>> implementation. >>>>>>>> Will it be fine something like "org.wso2.identity.annotations" ? >>>>>>>> >>>>>>>> [1] >>>>>>>> http://cxf.apache.org/docs/jax-rs-basics.html#JAX-RSBasics-HTTPMethod >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> In case if you want to move this class into cxf.ext[1] component you >>>>>>> could use "org.wso2.carbon.webapp.ext.jaxrs.designator" package name, >>>>>>> this[2] may help you to write test cases for this. >>>>>>> >>>>>> >>>>>> +1 >>>>>> >>>>>> Thanks & regards, >>>>>> -Prabath >>>>>> >>>>>> >>>>>>> >>>>>>> [1] - >>>>>>> https://github.com/wso2-dev/carbon-deployment/tree/master/components/webapp-mgt/org.wso2.carbon.cxf.ext >>>>>>> [2] - >>>>>>> https://github.com/wso2-dev/product-as/tree/master/modules/integration/tests-integration/src/test/java/org/wso2/appserver/integration/tests/webapp/classloading >>>>>>> >>>>>>> Thanks ! >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Jul 7, 2014 at 12:22 PM, Gayan Gunawardana <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Thanks Ishara & Supun. >>>>>>>>> >>>>>>>>> Will proceed accordingly. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Gayan >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Jul 7, 2014 at 12:11 PM, Supun Malinga <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> yeah. it looks like patch method is not supported OOTB, since as >>>>>>>>>> per the spec[5] patch method is not specified. So the usual practice >>>>>>>>>> seems >>>>>>>>>> to be implementing it by the user.. >>>>>>>>>> >>>>>>>>>> [5] >>>>>>>>>> http://download.oracle.com/otndocs/jcp/jaxrs-2_0-fr-eval-spec/index.html >>>>>>>>>> >>>>>>>>>> thanks, >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Mon, Jul 7, 2014 at 12:01 PM, Ishara Karunarathna < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Gayan, >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Mon, Jul 7, 2014 at 11:46 AM, Gayan Gunawardana < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi All, >>>>>>>>>>>> >>>>>>>>>>>> The requirement based on [1]. Since wso2 identity server can >>>>>>>>>>>> act as a SCIM provider, it exposes REST end points with standard >>>>>>>>>>>> http >>>>>>>>>>>> methods (GET, POST, PUT, DELETE). How ever according to [2] http >>>>>>>>>>>> PATCH >>>>>>>>>>>> method also require to do patch operation. The idea of patch >>>>>>>>>>>> operation is, >>>>>>>>>>>> suppose we need to add new user to existing group, with update >>>>>>>>>>>> operation we >>>>>>>>>>>> can update entire list of users in a particular group so we have >>>>>>>>>>>> to send >>>>>>>>>>>> complete set of users. Patch operation supports merging of >>>>>>>>>>>> existing users >>>>>>>>>>>> with new users. >>>>>>>>>>>> >>>>>>>>>>>> The bottleneck to implement patch operation is currently [3] >>>>>>>>>>>> does not support http PATCH method directly. But according to [4] >>>>>>>>>>>> it allows >>>>>>>>>>>> custom annotation such as @Update or @Patch. >>>>>>>>>>>> >>>>>>>>>>>> WDYT? >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> +1, >>>>>>>>>>> You will have to do the custom implementation to get PATCH >>>>>>>>>>> support. >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> [1] https://wso2.org/jira/browse/IDENTITY-1891 >>>>>>>>>>>> >>>>>>>>>>>> [2] >>>>>>>>>>>> http://tools.ietf.org/html/draft-ietf-scim-api-02#section-3.3.1 >>>>>>>>>>>> >>>>>>>>>>>> [3] http://cxf.apache.org/docs/jax-rs.html >>>>>>>>>>>> >>>>>>>>>>>> [4] >>>>>>>>>>>> http://cxf.apache.org/docs/jax-rs-basics.html#JAX-RSBasics-HTTPMethod >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Gayan >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Gayan Gunawardana >>>>>>>>>>>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>>>>>> Email: [email protected] >>>>>>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Ishara Karunarathna >>>>>>>>>>> Senior Software Engineer >>>>>>>>>>> WSO2 Inc. - lean . enterprise . middleware | wso2.com >>>>>>>>>>> >>>>>>>>>>> email: [email protected], blog: isharaaruna.blogspot.com, >>>>>>>>>>> mobile: +94 718211678 >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Supun Malinga, >>>>>>>>>> >>>>>>>>>> Senior Software Engineer, >>>>>>>>>> WSO2 Inc. >>>>>>>>>> http://wso2.com >>>>>>>>>> email: [email protected] <[email protected]> >>>>>>>>>> mobile: +94 (0)71 56 91 321 >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Gayan Gunawardana >>>>>>>>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>>> Email: [email protected] >>>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Gayan Gunawardana >>>>>>>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>> Email: [email protected] >>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Sagara Gunathunga >>>>>>> >>>>>>> Senior Technical Lead; WSO2, Inc.; http://wso2.com >>>>>>> V.P Apache Web Services; http://ws.apache.org/ >>>>>>> Linkedin; http://www.linkedin.com/in/ssagara >>>>>>> Blog ; http://ssagara.blogspot.com >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks & Regards, >>>>>> Prabath >>>>>> >>>>>> Twitter : @prabath >>>>>> LinkedIn : http://www.linkedin.com/in/prabathsiriwardena >>>>>> >>>>>> Mobile : +94 71 809 6732 >>>>>> >>>>>> http://blog.facilelogin.com >>>>>> http://blog.api-security.org >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Gayan Gunawardana >>>>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>> Email: [email protected] >>>>> Mobile: +94 (71) 8020933 >>>>> >>>> >>>> >>>> >>>> -- >>>> Sagara Gunathunga >>>> >>>> Senior Technical Lead; WSO2, Inc.; http://wso2.com >>>> V.P Apache Web Services; http://ws.apache.org/ >>>> Linkedin; http://www.linkedin.com/in/ssagara >>>> Blog ; http://ssagara.blogspot.com >>>> >>>> >>> >>> >>> -- >>> Gayan Gunawardana >>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>> Email: [email protected] >>> Mobile: +94 (71) 8020933 >>> >> >> >> >> -- >> Sagara Gunathunga >> >> Senior Technical Lead; WSO2, Inc.; http://wso2.com >> V.P Apache Web Services; http://ws.apache.org/ >> Linkedin; http://www.linkedin.com/in/ssagara >> Blog ; http://ssagara.blogspot.com >> >> > > > -- > Gayan Gunawardana > Software Engineer; WSO2 Inc.; http://wso2.com/ > Email: [email protected] > Mobile: +94 (71) 8020933 > -- Gayan Gunawardana Software Engineer; WSO2 Inc.; http://wso2.com/ Email: [email protected] Mobile: +94 (71) 8020933
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
