Sure. Will merge. Don't have access to a computer atm. Give me a couple of hours.
Regards, Ruwan On 17 Jan 2015 11:46, "Nuwan Dias" <[email protected]> wrote: > @Ruwan, can you have a quick look and merge? > > On Sat, Jan 17, 2015 at 8:47 AM, Roshan Wijesena <[email protected]> wrote: > >> Hi NuwanD, >> >> Please review and merge https://github.com/wso2-dev/carbon-apimgt/pull/16 >> pull request to wso2-dev carbon-apimgt. >> >> Regards >> Roshan. >> >> On Sat, Jan 17, 2015 at 12:28 AM, Pulasthi Supun <[email protected]> >> wrote: >> >>> Hi Roshan, >>> >>> Could you get someone from the API manager team to review it and merge >>> it as soon as possible. the governance lcm stub structure should be >>> accurate. >>> >>> Best Regards, >>> Pulasthi >>> >>> On Fri, Jan 16, 2015 at 10:03 PM, Roshan Wijesena <[email protected]> >>> wrote: >>> >>>> Hi Pulasthi, >>>> >>>> I have made a pull request for above concern [1] Please have a review >>>> on it. >>>> >>>> But I am not clear about one thing which is , "*The package structure >>>> does not have "stub*"" could you please clarify more on the same?. >>>> Furthermore if below given pull request is wrong would it be possible to >>>> share a correct service stub repo for us to follow the same structure?. >>>> However I already followed [2] repo structure to create my pull request. >>>> >>>> [1] https://github.com/wso2-dev/carbon-apimgt/pull/16 >>>> [2] >>>> https://github.com/wso2-dev/carbon-governance/tree/master/service-stubs/governance/org.wso2.carbon.governance.lcm.stub >>>> >>>> Thanks. >>>> >>>> Regards >>>> Roshan. >>>> >>>> On Fri, Jan 16, 2015 at 7:56 PM, Pulasthi Supun <[email protected]> >>>> wrote: >>>> >>>>> Hi APIM team >>>>> >>>>> After further looking into this with sameera. we found out that the " >>>>> org.wso2.carbon.apimgt.keymgt.stub" structure and exports are wrong. >>>>> The package structure does not have "stub" hence it exports >>>>> "org.wso2.carbon.apimgt.impl.dto.xsd" >>>>> which should be "org.wso2.carbon.apimgt.stub.impl.dto.xsd. >>>>> >>>>> And the bundle exports "org.wso2.carbon.apimgt.*" and this should be >>>>> "org.wso2.carbon.apimgt.stub*" since this is a stub bundle. >>>>> >>>>> Can someone from the API Manager team look into this an provide the >>>>> necessary changes as soon as possible since this is blocking the Greg >>>>> 5.0.0 >>>>> M1 release. >>>>> >>>>> Regards, >>>>> Pulasthi >>>>> >>>>> >>>>> On Thu, Jan 15, 2015 at 5:09 PM, Prasanna Dangalla <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi apim team, >>>>>> >>>>>> Greg server hangs for several minutes after printing >>>>>> >>>>>> JAVA_HOME environment variable is set to >>>>>> /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home >>>>>> CARBON_HOME environment variable is set to >>>>>> /Users/prasanna/workspace/wso2/greg/git/prasanna/product-greg/modules/distribution/target/wso2greg-5.0.0-SNAPSHOT >>>>>> >>>>>> We debug in osgi console. Then we found following two apimanager osgi >>>>>> bundles were not started. >>>>>> >>>>>> 161 INSTALLED org.wso2.carbon.apimgt.core_4.3.0.SNAPSHOT >>>>>> 165 INSTALLED org.wso2.carbon.apimgt.interceptor_4.3.0.SNAPSHOT >>>>>> >>>>>> diag 161 and diag 165 describes the following >>>>>> >>>>>> osgi> diag 161 >>>>>> reference:file:../plugins/org.wso2.carbon.apimgt.core_4.3.0.SNAPSHOT.jar >>>>>> [161] >>>>>> Package uses conflict: Import-Package: org.wso2.carbon.apimgt.impl; >>>>>> version="0.0.0" >>>>>> Package uses conflict: Import-Package: >>>>>> org.wso2.carbon.apimgt.impl.utils; version="0.0.0" >>>>>> Direct constraints which are unresolved: >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.authenticate_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.gateway_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.internal_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.throttle_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.usage_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.throttle.core_4.3.0.SNAPSHOT. >>>>>> >>>>>> >>>>>> osgi> diag 165 >>>>>> reference:file:../plugins/org.wso2.carbon.apimgt.interceptor_4.3.0.SNAPSHOT.jar >>>>>> [165] >>>>>> Package uses conflict: Import-Package: >>>>>> org.wso2.carbon.apimgt.impl.dao; version="0.0.0" >>>>>> Package uses conflict: Import-Package: >>>>>> org.wso2.carbon.apimgt.impl.dto; version="0.0.0" >>>>>> Package uses conflict: Import-Package: >>>>>> org.wso2.carbon.apimgt.impl.utils; version="0.0.0" >>>>>> Direct constraints which are unresolved: >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.authenticate_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.gateway_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.throttle_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.core.usage_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.interceptor_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.interceptor.handler_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.interceptor.utils_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.interceptor.valve_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.apimgt.usage.publisher.internal_0.0.0. >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.throttle.core_4.3.0.SNAPSHOT. >>>>>> Leaf constraints in the dependency chain which are unresolved: >>>>>> >>>>>> reference:file:../plugins/org.wso2.carbon.apimgt.core_4.3.0.SNAPSHOT.jar >>>>>> [161] >>>>>> Missing optionally imported package >>>>>> org.wso2.carbon.throttle.core_4.3.0.SNAPSHOT. >>>>>> >>>>>> >>>>>> We also found that in repository/components/plugins >>>>>> org.wso2.carbon.apimgt.impl is contained in two jars as follows >>>>>> >>>>>> Binary file org.wso2.carbon.apimgt.impl_4.3.0.SNAPSHOT.jar matches >>>>>> Binary file org.wso2.carbon.apimgt.keymgt.stub_4.3.0.SNAPSHOT.jar >>>>>> matches >>>>>> >>>>>> Then we removed >>>>>> repository/components/plugins/org.wso2.carbon.apimgt.impl_4.3.0.SNAPSHOT.jar >>>>>> Then the server start up lag was not there and server starts up quickly, >>>>>> but several osgi bundles were not starting properly. >>>>>> >>>>>> Thanks >>>>>> -- >>>>>> Prasanna Dangalla >>>>>> Software Engineer, WSO2, Inc.; http://wso2.com/ >>>>>> lean.enterprise.middleware >>>>>> >>>>>> cell: +94 777 55 80 30 | +94 718 11 27 51 >>>>>> twitter: @prasa77 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> -- >>>>> Pulasthi Supun >>>>> Software Engineer; WSO2 Inc.; http://wso2.com, >>>>> Email: [email protected] >>>>> Mobile: +94 (71) 9258281 >>>>> Blog : http://pulasthisupun.blogspot.com/ >>>>> Git hub profile: https://github.com/pulasthi >>>>> >>>> >>>> >>>> >>>> -- >>>> Roshan Wijesena. >>>> Senior Software Engineer-WSO2 Inc. >>>> Mobile: *+94719154640 <%2B94719154640>* >>>> Email: [email protected] >>>> *WSO2, Inc. :** wso2.com <http://wso2.com/>* >>>> lean.enterprise.middleware. >>>> >>> >>> >>> >>> -- >>> -- >>> Pulasthi Supun >>> Software Engineer; WSO2 Inc.; http://wso2.com, >>> Email: [email protected] >>> Mobile: +94 (71) 9258281 >>> Blog : http://pulasthisupun.blogspot.com/ >>> Git hub profile: https://github.com/pulasthi >>> >> >> >> >> -- >> Roshan Wijesena. >> Senior Software Engineer-WSO2 Inc. >> Mobile: *+94719154640 <%2B94719154640>* >> Email: [email protected] >> *WSO2, Inc. :** wso2.com <http://wso2.com/>* >> lean.enterprise.middleware. >> > > > > -- > Nuwan Dias > > Associate Tech Lead - WSO2, Inc. http://wso2.com > email : [email protected] > Phone : +94 777 775 729 >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
