I don't agree to the solution. After we move to Carbon 4.3.0 we should follow these protocols. But as per now at-least we have to build those kernel patches before building AF code. With this solution we will be adding carbon user core 4.3.0 jar to the AF pack and that could cause issues. We shouldn't have add api changes to kernel with patches. But since we have already done that I guess we have to live with the building the patch option.
Thanks & Regards Danushka Fernando Software Engineer WSO2 inc. http://wso2.com/ Mobile : +94716332729 On Mon, Jan 26, 2015 at 1:10 PM, Roshan Deniyage <[email protected]> wrote: > Actually, the problem arise in the "org.wso2.carbon.appfactory.ext" > package and the dependent package was "org.wso2.carbon.user.core". Hence, > we kept the version as "4.2.0" in the parent pom file and made the version > in the component pom file as "4.3.0" (although this is not the recommended > version setting). And the feature version was kept as "4.2.0". > > There is no build error in this setting but at run time we need to copy > the dependent kernel patches to the relevant place. AFAIK, > "org.wso2.carbon.appfactory.ext" package is copied to appserver > (cartridge), the kernel patches need to be copied to the appserver. > > > Thanks, > > Roshan Deniyage > Associate Technical Lead > WSO2, Inc: http://wso2.com > > Mobile : +94 777636406 > Twitter : *https://twitter.com/roshku <https://twitter.com/roshku>* > LinkedIn : https://www.linkedin.com/in/roshandeniyage > > > On Fri, Jan 23, 2015 at 9:37 AM, Punnadi Gunarathna <[email protected]> > wrote: > >> hi Danushka, >> >> >> We cannot use those patches in GitHub. As a temporary solution, we have >> pointed Carbon 4.3.0 version for respective kernel components to get rid of >> compiler errors. >> >> On Wed, Jan 21, 2015 at 10:52 PM, Danushka Fernando <[email protected]> >> wrote: >> >>> That's why its recommended to not to do API changes in kernel patches. >>> Since we have already done it we have to live with it. So needs to build >>> kernel patches. >>> >>> Thanks & Regards >>> Danushka Fernando >>> Software Engineer >>> WSO2 inc. http://wso2.com/ >>> Mobile : +94716332729 >>> >>> On Wed, Jan 21, 2015 at 12:29 AM, Punnadi Gunarathna <[email protected]> >>> wrote: >>> >>>> Hi All, >>>> >>>> AF is currently on carbon 4.2.0 >>>> >>>> On Wed, Jan 21, 2015 at 1:46 PM, Roshan Deniyage <[email protected]> >>>> wrote: >>>> >>>>> Hi all, >>>>> We are in the process of moving AppFactory to GitHub. Some of the >>>>> components in appfactory has carbon kernel dependencies which actual has >>>>> been ship as carbon kernel patches. >>>>> >>>>> AFAIK, after moving products to GitHub, we are not suppose to build >>>>> any dependent code locally, but get from the nexus repository as >>>>> dependencies. But, the nexus repo doesn't have those patches as jars. >>>>> >>>>> So, does anyone know how to handle carbon kernel patches with GitHub >>>>> repositories? >>>>> >>>>> >>>>> Thanks, >>>>> Roshan Deniyage >>>>> Associate Technical Lead >>>>> WSO2, Inc: http://wso2.com >>>>> >>>>> Mobile : +94 777636406 >>>>> Twitter : *https://twitter.com/roshku >>>>> <https://twitter.com/roshku>* >>>>> LinkedIn : https://www.linkedin.com/in/roshandeniyage >>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> >>>> Punnadi Gunarathna >>>> Senior Software Engineer, >>>> WSO2, Inc.; http://wso2.com <http://wso2> >>>> Blog: http://hi-my-world.blogspot.com/ >>>> Tel : 94 11 214 5345 >>>> Fax :94 11 2145300 >>>> >>>> >>>> >>>> <http://lalajisureshika.blogspot.com/> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >> >> >> -- >> Thanks and Regards, >> >> Punnadi Gunarathna >> Senior Software Engineer, >> WSO2, Inc.; http://wso2.com <http://wso2> >> Blog: http://hi-my-world.blogspot.com/ >> Tel : 94 11 214 5345 >> Fax :94 11 2145300 >> >> >> >> <http://lalajisureshika.blogspot.com/> >> > >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
