[moving the discussion back to dev@, at some point it has dropped from dev@]
On Thu, Feb 12, 2015 at 9:59 AM, Kasun Gajasinghe <[email protected]> wrote: > Why is this private? Please move to dev. > > > On Feb 12, 2015, at 2:03 AM, Kalpa Welivitigoda <[email protected]> wrote: > > Hi Kasun, > > Based on the offline chat we had yesterday, I went through the jxws xsd > [1] and found that none of the attributes defined for either endpoint or > servers are mandatory (we set the "use" attribute to "required" [2] to make > the attribute mandatory). > > This means that there's a chance that the serviceClass (in the case of > server) and the implementor (in the case of endpoints) may not be defined > in the cxf-servlet.xml. In such a scenario, our suggestion to find the > serviceClass/implementor from the cxf-servlet.xml (without parsing all the > classes) fails. So I think to cater all possible scenarios, we better stick > with the current implementation of scanning all the classes (inside > WEB-INF/classes) for the @WebService annotation. WDYT? > > With regard to the name of the services/endpoints, I tried deploying > without a serviceName defined either in the cxf-servlet.xml or in the > service class, in this case the service name is set as "implementation > class name + 'Service'" - ex: HelloWorldImplService. I think we are good to > follow a similar approach, i.e. if the serviceName is defined either in > cxf-servlet.xml or in the service class itself, use "context path - > serviceName" as the name of the service or else use "context path - service > implementation class name" > > [1] http://cxf.apache.org/schemas/jaxws.xsd > [2] http://www.w3schools.com/schema/schema_simple_attributes.asp > > On Wed, Feb 11, 2015 at 8:08 AM, Kalpa Welivitigoda <[email protected]> > wrote: > >> Hi Pubudu, >> >> I'll continue with the improvements and will ping you if anything to be >> clarified. >> >> On Tuesday, February 10, 2015, Pubudu Dissanayake <[email protected]> >> wrote: >> >>> Sorry for the delay, I'm on study leave till this friday. Therefore I >>> won't be able to do any improvements on that task. If it is urgent please >>> hand over it to somebody else >>> >>> Thanks >>> Pubudu >>> >>> On Tue, Feb 10, 2015 at 11:46 AM, KasunG Gajasinghe <[email protected]> >>> wrote: >>> >>>> Adding Kalpa. >>>> >>>> On Mon, Jan 19, 2015 at 12:25 PM, KasunG Gajasinghe <[email protected]> >>>> wrote: >>>> >>>>> Hi Pubudu, >>>>> >>>>> This feature is in a working state, so you can test it out how it >>>>> works. Following are the improvements needed for this feature. >>>>> >>>>> 1. Instead of traversing the whole WEB-INF/classes for jax-ws services >>>>> with @WebService annotation, we should read the cxf-servlet.xml to find >>>>> out >>>>> the resource classes. >>>>> >>>>> I have used a library called scannotation to traverse, but with the >>>>> above change, we don't need to depend on that. >>>>> >>>>> 2. Support ws-discovery for webapps with multiple jax-ws services. >>>>> >>>>> 3. Test the ws-discovery bye message when a webapp is deleted. This >>>>> doesn't seem to work since we currently try to read the webapp folder to >>>>> gather some details. >>>>> >>>>> The code can be found here [1] >>>>> >>>>> [1] >>>>> https://github.com/wso2/carbon-deployment/tree/master/components/webapp-mgt/org.wso2.carbon.discovery.cxf >>>>> >>>>> Regards, >>>>> KasunG >>>>> >>>>> >>>>> -- >>>>> >>>>> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >>>>> email: kasung AT spamfree wso2.com >>>>> linked-in: http://lk.linkedin.com/in/gajasinghe >>>>> blog: http://kasunbg.org >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >>>> email: kasung AT spamfree wso2.com >>>> linked-in: http://lk.linkedin.com/in/gajasinghe >>>> blog: http://kasunbg.org >>>> >>>> >>>> >>> >>> >>> >>> -- >>> *Pubudu Dissanayake* >>> Software Engineer >>> >>> WSO2 Inc.; http://wso2.com >>> lean.enterprise.middleware >>> Mob: + 94 775 503 304 >>> >>> Blog: http://geekdetected.wordpress.com/ >>> Linkedin: *http://lk.linkedin.com/in/pubududissanayake* >>> <http://lk.linkedin.com/in/pubududissanayake> >>> Flickr : https://www.flickr.com/photos/pubudufx/ >>> Twitter: https://twitter.com/GeekInAction >>> >>> >> >> -- >> Best Regards, >> >> Kalpa Welivitigoda >> Software Engineer, WSO2 Inc. http://wso2.com >> Email: [email protected] >> Mobile: +94776509215 >> >> > > > -- > Best Regards, > > Kalpa Welivitigoda > Software Engineer, WSO2 Inc. http://wso2.com > Email: [email protected] > Mobile: +94776509215 > > -- Best Regards, Kalpa Welivitigoda Software Engineer, WSO2 Inc. http://wso2.com Email: [email protected] Mobile: +94776509215
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
