Noted. On Mon, Feb 16, 2015 at 4:49 PM, Johann Nallathamby <[email protected]> wrote:
> Hi Chanuka, > > Since it is shown in the listing page lets remove it from the properties. > Only in the backend it will be among the optional properties. > > On Mon, Feb 16, 2015 at 4:25 PM, Chanuka Dissanayake <[email protected]> > wrote: > >> Hi, >> >> Noted. With the fix, "Disable" property is getting listed under the optional >> properties. >> >> Thanks. >> >> On Mon, Feb 16, 2015 at 4:17 PM, Pushpalanka Jayawardhana <[email protected] >> > wrote: >> >>> >>> >>> Pushpalanka. >>> -- >>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>> Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>> Mobile: +94779716248 >>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>> lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka >>> >>> >>> On Mon, Feb 16, 2015 at 4:04 PM, Johann Nallathamby <[email protected]> >>> wrote: >>> >>>> But what about the backend? I guess it is still needed and we can have >>>> it under optional properties right ? >>>> >>>> On Mon, Feb 16, 2015 at 3:48 PM, Pushpalanka Jayawardhana < >>>> [email protected]> wrote: >>>> >>>>> Hi All, >>>>> >>>>> We have taken disable/enable functionality for user stores out into >>>>> Listing space. >>>>> Hence we can totally remove this property from listing in UI under >>>>> properties. (Still we need the above modification) >>>>> >>>> Yes, exactly that's what I wanted to mean here. >>> >>>> >>>>> Thanks, >>>>> Pushpalanka. >>>>> -- >>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>> Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>>> Mobile: +94779716248 >>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>>>> lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka >>>>> >>>>> >>>>> On Mon, Feb 16, 2015 at 3:36 PM, Chanuka Dissanayake <[email protected] >>>>> > wrote: >>>>> >>>>>> Hi Johann, >>>>>> >>>>>> Following diff is the fix in user.core, and UI will be automatically >>>>>> populated accordingly. >>>>>> >>>>>> - >>>>>> setMandatoryProperty(UserStoreConfigConstants.disabled,"Disabled","false",UserStoreConfigConstants.disabledDescription, >>>>>> false); >>>>>> >>>>>> + >>>>>> setProperty(UserStoreConfigConstants.disabled,"Disabled","false", >>>>>> UserStoreConfigConstants.disabledDescription); >>>>>> >>>>>> Above fix was done only for >>>>>> org.wso2.carbon.user.core.ReadWriteLDAPUserStoreManager, >>>>>> same can be done for ReadOnlyLDAPUserStoreManager. >>>>>> >>>>>> Apart from that same issue is there in >>>>>> org.wso2.carbon.user.core.ldap.ActiveDirectoryUserStoreManager and >>>>>> org.wso2.carbon.identity.user.store.remote.CarbonRemoteUserStoreManager. >>>>>> Along with this, I will fix those as well and send the pull request. >>>>>> >>>>>> Thanks, >>>>>> Chanuka. >>>>>> >>>>>> On Mon, Feb 16, 2015 at 1:13 PM, Johann Nallathamby <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> [adding Pushpalanka to the thread] >>>>>>> >>>>>>> Why is disabled in mandadatory list in the backend. It can be >>>>>>> optional. Default is 'enabled'. >>>>>>> >>>>>>> Can you explain. If there is not proper reason I think we can fix >>>>>>> backend as well as front end correctly. >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Mon, Feb 16, 2015 at 12:55 PM, Chanuka Dissanayake < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi Johann, >>>>>>>> >>>>>>>> I looked into this issue and found the followings, >>>>>>>> >>>>>>>> This "Disabled" property is in a property list named "mandatories" >>>>>>>> in the userstore-config.jsp file in >>>>>>>> org.wso2.carbon.identity.user.store.configuration.ui component. It >>>>>>>> retrieves the mandatory properties list by calling >>>>>>>> the >>>>>>>> UserStoreManagerRegistry.getUserStoreProperties(userStoreClass).getMandatoryProperties() >>>>>>>> method in user.core. >>>>>>>> >>>>>>>> In the backend, this "Disabled" property is a mandatory property >>>>>>>> and it is correct. In the UI, having the red color asterisk for the >>>>>>>> checkbox may confuse the user where it suggests like it is mandatory to >>>>>>>> select the checkbox. >>>>>>>> >>>>>>>> However we don't need to change the backend code since it is >>>>>>>> correct. In UI, in order to remove the asterisk, a solution would be to >>>>>>>> remove this property from mandatory properties list and adding it to >>>>>>>> optional properties list. Should we proceed with this approach ? >>>>>>>> >>>>>>>> Thanks >>>>>>>> Chanuka >>>>>>>> >>>>>>>> On Fri, Feb 13, 2015 at 10:36 PM, Tharindu Edirisinghe < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi Nirodha, >>>>>>>>> >>>>>>>>> Thanks for pointing this out. We'll get this fixed. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> TharinduE >>>>>>>>> >>>>>>>>> On Fri, Feb 13, 2015 at 5:53 PM, Nirodha Pramod <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Please see the jira [1]. In the secondary userstore UI , the user >>>>>>>>>> is sort of asked to mark the newly created userstore as disabled, by >>>>>>>>>> making >>>>>>>>>> it mandatory with a checkbox. Usually in UI forms a single checkbox >>>>>>>>>> field >>>>>>>>>> is not marked as mandatory which makes no sense. So this disabled >>>>>>>>>> parameter >>>>>>>>>> should go as an optional. >>>>>>>>>> >>>>>>>>>> [1] https://wso2.org/jira/browse/IDENTITY-3048 >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Nirodha >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> >>>>>>>>>> *Nirodha Gallage* >>>>>>>>>> Senior Software Engineer, QA. >>>>>>>>>> WSO2 Inc.: http://wso2.com/ >>>>>>>>>> Mobile: +94716429078 >>>>>>>>>> >>>>>>>>>> _______________________________________________ >>>>>>>>>> Dev mailing list >>>>>>>>>> [email protected] >>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Tharindu Edirisinghe >>>>>>>>> Software Engineer | WSO2 Inc >>>>>>>>> Identity Server Team >>>>>>>>> mobile : +94 775 181586 >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Dev mailing list >>>>>>>>> [email protected] >>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Chanuka Dissanayake >>>>>>>> *Software Engineer | **WSO2 Inc.*; http://wso2.com >>>>>>>> >>>>>>>> Mobile: +94 71 33 63 596 >>>>>>>> Email: [email protected] >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> *Johann Dilantha Nallathamby* >>>>>>> Associate Technical Lead & Product Lead of WSO2 Identity Server >>>>>>> Integration Technologies Team >>>>>>> WSO2, Inc. >>>>>>> lean.enterprise.middleware >>>>>>> >>>>>>> Mobile - *+94777776950* >>>>>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Chanuka Dissanayake >>>>>> *Software Engineer | **WSO2 Inc.*; http://wso2.com >>>>>> >>>>>> Mobile: +94 71 33 63 596 >>>>>> Email: [email protected] >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> >>>> *Johann Dilantha Nallathamby* >>>> Associate Technical Lead & Product Lead of WSO2 Identity Server >>>> Integration Technologies Team >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - *+94777776950* >>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>> >>> >>> >> >> >> -- >> Chanuka Dissanayake >> *Software Engineer | **WSO2 Inc.*; http://wso2.com >> >> Mobile: +94 71 33 63 596 >> Email: [email protected] >> > > > > -- > Thanks & Regards, > > *Johann Dilantha Nallathamby* > Associate Technical Lead & Product Lead of WSO2 Identity Server > Integration Technologies Team > WSO2, Inc. > lean.enterprise.middleware > > Mobile - *+94777776950* > Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* > -- Chanuka Dissanayake *Software Engineer | **WSO2 Inc.*; http://wso2.com Mobile: +94 71 33 63 596 Email: [email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
