Thanks for the comments. I added the optional tag. And I couldn't find any requirement for the dynamic import, I added in the previous pull because I found it in the rabbitmq-client-3.3.4 orbit version [1].
Anyway I removed it now, and the pull request is updated. [1]. https://github.com/wso2/orbit/blob/master/rabbit-mq/3.3.4.wso2v1/pom.xml <https://github.com/wso2/orbit/blob/master/rabbit-mq/3.3.4.wso2v1/pom.xml> Thank you! On Mon, Feb 16, 2015 at 8:17 PM, Kishanthan Thangarajah <[email protected] > wrote: > I have added some comments on this PR. Please look into them. > > On Fri, Feb 13, 2015 at 11:49 AM, Eranda Rajapakshe <[email protected]> > wrote: > >> Hi, >> >> Please review the pull request [1]. >> >> [1]. https://github.com/wso2/orbit/pull/61 >> >> Thank you! >> >> >> -- >> *Eranda Rajapakshe* >> Software Engineering intern >> WSO2 Inc. www.wso2.com >> Tel : +94784822608 >> Email : [email protected] >> > > > > -- > *Kishanthan Thangarajah* > Senior Software Engineer, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > -- *Eranda Rajapakshe* Software Engineering intern WSO2 Inc. www.wso2.com Tel : +94784822608 Email : [email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
