Hi Kishanthan, Sure. I'll send a new PR for "java8support" branch.
Thanks Godwin On Wed, Mar 4, 2015 at 2:47 PM, Kishanthan Thangarajah <[email protected]> wrote: > Hi Godwin, > > We need to update this PR by fixing merge conflicts. Also its better if > you can send this PR for "java8support" branch as our current development > is happening in there. This branch will become the 4.4.0 release branch. > > On Tue, Mar 3, 2015 at 4:59 PM, Godwin Amila Shrimal <[email protected]> > wrote: > >> Hi Kishanthan, >> >> I moved jira [1] to carbon team as per the discussion had with mail >> thread [2]. Can you please commit this to Carbon 4.4.0 ? >> >> [1] https://wso2.org/jira/browse/IDENTITY-2915 >> [2] [Dev] Tenant creation issue with Active Directory >> >> >> Thanks >> Godwin >> >> >> >> >> On Mon, Dec 8, 2014 at 5:03 PM, Kishanthan Thangarajah < >> [email protected]> wrote: >> >>> Applied to patch0010. Pull will be merged. >>> >>> On Mon, Dec 8, 2014 at 3:15 PM, Johann Nallathamby <[email protected]> >>> wrote: >>> >>>> Reviewed. >>>> >>>> Thanks, >>>> Johann. >>>> >>>> On Thu, Dec 4, 2014 at 4:23 PM, Kishanthan Thangarajah < >>>> [email protected]> wrote: >>>> >>>>> IS Team, >>>>> >>>>> Can you review this fix? >>>>> >>>>> >>>>> On Thu, Dec 4, 2014 at 2:26 PM, Godwin Amila Shrimal <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Kishanthan, >>>>>> >>>>>> As per the discussion had with you, I removed @Deprecated and >>>>>> attached the diff to jira, will send the pull request with @Deprecated. >>>>>> >>>>>> >>>>>> Thanks >>>>>> Godwin >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Thu, Dec 4, 2014 at 2:07 PM, Kishanthan Thangarajah < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> What is the reason to deprecate these two methods? We don't >>>>>>> deprecate API's when patching. >>>>>>> >>>>>>> + @Deprecated >>>>>>> protected String createAdminEntry(String dnOfUserContext, >>>>>>> Tenant tenant, >>>>>>> DirContext initialDirContext) >>>>>>> throws UserStoreException { >>>>>>> @@ -394,6 +397,7 @@ >>>>>>> return userDN; >>>>>>> } >>>>>>> >>>>>>> + @Deprecated >>>>>>> protected void createAdminGroup(String dnOfGroupContext, String >>>>>>> adminUserDN, >>>>>>> DirContext initialDirContext) >>>>>>> throws UserStoreException { >>>>>>> >>>>>>> On Wed, Dec 3, 2014 at 12:53 PM, Godwin Amila Shrimal < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi Carbon Team, >>>>>>>> >>>>>>>> Please commit the diff attached with [1] >>>>>>>> >>>>>>>> >>>>>>>> [1] - https://wso2.org/jira/browse/IDENTITY-2915 >>>>>>>> >>>>>>>> >>>>>>>> Thanks >>>>>>>> Godwin >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Godwin Amila Shrimal* >>>>>>>> Senior Software Engineer >>>>>>>> WSO2 Inc.; http://wso2.com >>>>>>>> lean.enterprise.middleware >>>>>>>> >>>>>>>> mobile: *+94772264165* >>>>>>>> linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* >>>>>>>> twitter: https://twitter.com/godwinamila >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Dev mailing list >>>>>>>> [email protected] >>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Kishanthan Thangarajah* >>>>>>> Senior Software Engineer, >>>>>>> Platform Technologies Team, >>>>>>> WSO2, Inc. >>>>>>> lean.enterprise.middleware >>>>>>> >>>>>>> Mobile - +94773426635 >>>>>>> Blog - *http://kishanthan.wordpress.com >>>>>>> <http://kishanthan.wordpress.com>* >>>>>>> Twitter - *http://twitter.com/kishanthan >>>>>>> <http://twitter.com/kishanthan>* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Godwin Amila Shrimal* >>>>>> Senior Software Engineer >>>>>> WSO2 Inc.; http://wso2.com >>>>>> lean.enterprise.middleware >>>>>> >>>>>> mobile: *+94772264165* >>>>>> linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* >>>>>> twitter: https://twitter.com/godwinamila >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Kishanthan Thangarajah* >>>>> Senior Software Engineer, >>>>> Platform Technologies Team, >>>>> WSO2, Inc. >>>>> lean.enterprise.middleware >>>>> >>>>> Mobile - +94773426635 >>>>> Blog - *http://kishanthan.wordpress.com >>>>> <http://kishanthan.wordpress.com>* >>>>> Twitter - *http://twitter.com/kishanthan >>>>> <http://twitter.com/kishanthan>* >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> >>>> *Johann Dilantha Nallathamby* >>>> Associate Technical Lead & Product Lead of WSO2 Identity Server >>>> Integration Technologies Team >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - *+94777776950* >>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>> >>> >>> >>> >>> -- >>> *Kishanthan Thangarajah* >>> Senior Software Engineer, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >> >> >> >> -- >> *Godwin Amila Shrimal* >> Senior Software Engineer >> WSO2 Inc.; http://wso2.com >> lean.enterprise.middleware >> >> mobile: *+94772264165* >> linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* >> twitter: https://twitter.com/godwinamila >> > > > > -- > *Kishanthan Thangarajah* > Senior Software Engineer, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > -- *Godwin Amila Shrimal* Senior Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: *+94772264165* linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* twitter: https://twitter.com/godwinamila
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
