Hi Ajith, Above mentioned hard corded URL is in a deprecated method therefore I just evaluate the uses of getSolrUrl() method. I found only single use of this method. After that We check the use of that method which is getSolrUrl(int tenantId), but when we search uses of that method we couldn't find any. After having a discussion with Danesh We decide to remove these 2 methods from the code base. Other than that we could find any test-cases either. Please advice if we have missed something.
Thanks, Thushara. On Wed, Mar 4, 2015 at 10:04 PM, Ajith Vitharana <[email protected]> wrote: > Hi Thushara, > > Could you please explain the fix here ? what we need to do is construct > the solrServerUrl without hardcore. But I see you have completely removed > the getSolrUrl() method. > > > solrServerUrl = "https://localhost:9443/registry/resourcesolr/solr";; > > -Ajith > > Thushara Kasun Ranawaka > <https://wso2.org/jira/secure/ViewProfile.jspa?name=thusharak%40wso2.com> > commented on [image: Bug] REGISTRY-2431 > <https://wso2.org/jira/browse/REGISTRY-2431> > *Hard code URL* <https://wso2.org/jira/browse/REGISTRY-2431> > > Since these methods are deprecated and not in use, removed them after > checking integration tests > PR sent : https://github.com/wso2/carbon-registry/pull/35 > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira > > > > -- > Ajith Vitharana. > WSO2 Inc. - http://wso2.org > Email : [email protected] > Mobile : +1-812-360-5335 > > -- Thanks, Thushara Kasun Ranawaka Software Engineer WSO2 Inc.; <http://www.wso2.com> lean.enterprise.middleware Mobile : *+94 (0) 773438949 <%2B94%20%280%29%20773438949>* *[email protected] <[email protected]>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
