Hi Krishantha / NuwanD, I have created and updated [1] the pull request with relevant changes and also fixed failing tests.
[1] https://github.com/wso2/product-apim/pull/42 Regards On Fri, Mar 6, 2015 at 3:23 PM, Krishantha Samaraweera <[email protected]> wrote: > Hi Dimuthu, > > We need to get rid of these duplicate classes and stick to correct module > structure. > > Please refactor the code and fix all tests. > > Thanks, > Krishantha. > > On Fri, Mar 6, 2015 at 3:08 PM, Dimuthu De Lanerolle <[email protected]> > wrote: > >> Hi NuwanD/ Krishantha, >> >> While migrating git's APIM integration tests (to be compatible with TAF >> 4.3.1) to tests-integration module , I noticed that several utility and >> admin client classes are duplicated in the APIM git (Some of these are >> identical and some are not, however they serve same purposes) . Can we >> remove these unwanted classes by keeping a one copy only since I noticed >> that tests are written using all over these duplicate classes and these >> might cause some dependency problems. >> >> eg: >> >> [1] >> https://github.com/wso2/product-apim/blob/master/modules/integration/tests-common/admin-clients/src/main/java/org/wso2/am/integration/admin/clients/logging/LoggingAdminClient.java >> >> >> https://github.com/wso2/product-apim/tree/master/modules/integration/tests-common/admin-clients/src/main/java/org/wso2/am/admin/clients/logging/LoggingAdminClient.java >> >> [2] >> https://github.com/wso2/product-apim/blob/master/modules/integration/tests-common/integration-test-utils/src/main/java/org/wso2/am/integration/test/utils/publisher/utils/APIPublisherRestClient.java >> >> >> https://github.com/wso2/product-apim/blob/master/modules/integration/tests-common/integration-test-utils/src/main/java/org/wso2/am/integration/test/utils/clients/APIPublisherRestClient.java >> >> >> Regards >> >> -- >> Dimuthu De Lanerolle >> Software Engineer >> WSO2 Inc. >> lean . enterprise . middlewear. >> http://wso2.com/ >> Tel. : +94 11 2145345 Fax : +94 11 2145300 email : [email protected] >> >> > > > -- > Krishantha Samaraweera > Senior Technical Lead - Test Automation > Mobile: +94 77 7759918 > WSO2, Inc.; http://wso2.com/ > lean . enterprise . middlewear. > -- Dimuthu De Lanerolle Software Engineer WSO2 Inc. lean . enterprise . middlewear. http://wso2.com/ Tel. : +94 11 2145345 Fax : +94 11 2145300 email : [email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
