Hi Supun, Can you do a KT on how to write a test and also a code review ?
On Mon, Mar 23, 2015 at 1:57 PM, Nirmal Fernando <[email protected]> wrote: > Got it ! thanks. > > On Mon, Mar 23, 2015 at 1:51 PM, Supun Sethunga <[email protected]> wrote: > >> Hi Nirmal, >> >> The tests are checking only up to the spark-job submission point, so far. >> This error is thrown after the job submission, and hence the test is >> passing despite this error. Anyway as we discussed offline, It was due to >> a bug in the product, and is fixed now. >> >> Regards, >> >> >> On Mon, Mar 23, 2015 at 8:35 AM, Nirmal Fernando <[email protected]> wrote: >> >>> Hi Supun, >>> >>> I see following errors when running the integration tests (tests were >>> successful though). Are these expected? >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - >>> [2015-03-23 08:33:08,133] ERROR >>> {org.wso2.carbon.ml.core.impl.MLModelHandler} - Failed to build the model >>> [id] 4 >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - >>> org.wso2.carbon.ml.core.exceptions.MLModelBuilderException: An error >>> occurred while building supervised machine learning model: An error >>> occurred while building logistic regression model: null >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> org.wso2.carbon.ml.core.spark.algorithms.SupervisedModel.buildModel(SupervisedModel.java:118) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> org.wso2.carbon.ml.core.impl.MLModelHandler$ModelBuilder.run(MLModelHandler.java:336) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> java.lang.Thread.run(Thread.java:745) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - >>> Caused by: org.wso2.carbon.ml.core.exceptions.MLModelBuilderException: An >>> error occurred while building logistic regression model: null >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> org.wso2.carbon.ml.core.spark.algorithms.SupervisedModel.buildLogisticRegressionModel(SupervisedModel.java:159) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> org.wso2.carbon.ml.core.spark.algorithms.SupervisedModel.buildModel(SupervisedModel.java:90) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - ... >>> 4 more >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - >>> Caused by: java.lang.NullPointerException >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1017) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> java.lang.Double.parseDouble(Double.java:540) >>> >>> INFO >>> [org.wso2.carbon.integration.common.extensions.utils.ServerLogReader] - at >>> org.wso2.carbon.ml.core.spark.algorithms.SupervisedModel.buildLogisticRegressionModel(SupervisedModel.java:143) >>> >>> INFO [org.wso2.carbon.integration.common.extensions.utils.S >>> >>> On Sun, Mar 22, 2015 at 10:39 PM, Nirmal Fernando <[email protected]> >>> wrote: >>> >>>> Great work on this Supun !! >>>> >>>> On Sun, Mar 22, 2015 at 6:31 PM, Supun Sethunga <[email protected]> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> Current Tests Status : 03/22/2015 >>>>> >>>>> OVERALL COVERAGE SUMMARYnameline, %block, %method, %class, % >>>>> all classes40% (1500.5/3748)33% (5735/17202)51% (372/725) >>>>> 50% (57/115) >>>>> >>>>> >>>>> Additionally Covered Workflows: >>>>> >>>>> - Analysis >>>>> - Creating/Deleting/Retrieving Analyses >>>>> - Adding Features >>>>> - Adding Model Configurations >>>>> - Setting Hyperparameters >>>>> - Model >>>>> - Creating/Retrieving Models >>>>> - Setting Model Storage >>>>> - Model Building: >>>>> - Logistic Regression >>>>> >>>>> >>>>> Regards, >>>>> Supun >>>>> >>>>> >>>>> On Thu, Mar 19, 2015 at 6:15 PM, Supun Sethunga <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> Im in the process of writing Automated Integration Tests for Product >>>>>> ML. Follow is the current status of the Tests. >>>>>> >>>>>> Covered Workflows: >>>>>> >>>>>> - Dataset Flow: >>>>>> - Dataset Creation/Retrieval. >>>>>> - Versionsets Creation/Retrieval. >>>>>> >>>>>> >>>>>> - Project Flow: >>>>>> - Projects Creation/Retrieval/Deletion. >>>>>> >>>>>> >>>>>> >>>>>> *OVERALL COVERAGE SUMMARY* >>>>>> nameline, %block, %method, %class, %all classes24% (849.9/3546) >>>>>> 20% (3286/16088)30% (219/719)32% (36/114)OVERALL STATS SUMMARY >>>>>> total packages:15total executable files:97total classes:114 >>>>>> total methods:719total executable lines:3546 >>>>>> COVERAGE BREAKDOWN BY PACKAGEnameline, %block, %method, %class, % >>>>>> org.wso2.carbon.ml.database.exceptions <http://_files/0.html> >>>>>> 100% (4/4)100% (9/9)100% (2/2)100% (1/1) >>>>>> org.wso2.carbon.ml.commons.domain.config <http://_files/1.html> >>>>>> 63% (52/82)59% (126/214)58% (31/53)83% (5/6) >>>>>> org.wso2.carbon.ml.core.utils <http://_files/2.html>63% (87.3/138) >>>>>> 57% (284/499)61% (22/36)67% (4/6) >>>>>> org.wso2.carbon.ml.database.internal.ds <http://_files/3.html> >>>>>> 45% (17/38)30% (38/127)53% (8/15)67% (2/3) >>>>>> org.wso2.carbon.ml.core.internal <http://_files/4.html>44% (34/78) >>>>>> 44% (97/220)28% (10/36)25% (1/4)org.wso2.carbon.ml.core.spark >>>>>> <http://_files/5.html>36% (9/25)27% (23/85)39% (7/18)67% (2/3) >>>>>> org.wso2.carbon.ml.commons.domain <http://_files/6.html> >>>>>> 35% (111.7/318)35% (380/1096)36% (72/199)33% (6/18) >>>>>> org.wso2.carbon.ml.core.impl <http://_files/7.html>34% (225.9/669) >>>>>> 32% (1141/3544)42% (40/96)60% (9/15) >>>>>> org.wso2.carbon.ml.database.internal <http://_files/8.html>18% (301/ >>>>>> 1699)15% (1171/7735)22% (23/106)100% (3/3) >>>>>> org.wso2.carbon.ml.core.exceptions <http://_files/9.html>12% (8/68) >>>>>> 11% (17/149)12% (4/34)21% (3/14) >>>>>> org.wso2.carbon.ml.commons.constants <http://_files/a.html>0% (0/6) >>>>>> 0% (0/123)0% (0/10)0% (0/3) >>>>>> org.wso2.carbon.ml.core.spark.algorithms <http://_files/b.html> >>>>>> 0% (0/292)0% (0/1739)0% (0/68)0% (0/23) >>>>>> org.wso2.carbon.ml.core.spark.summary <http://_files/c.html> >>>>>> 0% (0/34)0% (0/81)0% (0/25)0% (0/4) >>>>>> org.wso2.carbon.ml.core.spark.transformations <http://_files/d.html> >>>>>> 0% (0/93)0% (0/464)0% (0/20)0% (0/10) >>>>>> org.wso2.carbon.ml.database.internal.constants <http://_files/e.html> >>>>>> 0% (0/2)0% (0/3)0% (0/1)0% (0/1) >>>>>> >>>>>> >>>>>> Regards, >>>>>> Supun >>>>>> >>>>>> -- >>>>>> *Supun Sethunga* >>>>>> Software Engineer >>>>>> WSO2, Inc. >>>>>> http://wso2.com/ >>>>>> lean | enterprise | middleware >>>>>> Mobile : +94 716546324 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Supun Sethunga* >>>>> Software Engineer >>>>> WSO2, Inc. >>>>> http://wso2.com/ >>>>> lean | enterprise | middleware >>>>> Mobile : +94 716546324 >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Thanks & regards, >>>> Nirmal >>>> >>>> Senior Software Engineer- Platform Technologies Team, WSO2 Inc. >>>> Mobile: +94715779733 >>>> Blog: http://nirmalfdo.blogspot.com/ >>>> >>>> >>>> >>> >>> >>> -- >>> >>> Thanks & regards, >>> Nirmal >>> >>> Senior Software Engineer- Platform Technologies Team, WSO2 Inc. >>> Mobile: +94715779733 >>> Blog: http://nirmalfdo.blogspot.com/ >>> >>> >>> >> >> >> -- >> *Supun Sethunga* >> Software Engineer >> WSO2, Inc. >> http://wso2.com/ >> lean | enterprise | middleware >> Mobile : +94 716546324 >> > > > > -- > > Thanks & regards, > Nirmal > > Senior Software Engineer- Platform Technologies Team, WSO2 Inc. > Mobile: +94715779733 > Blog: http://nirmalfdo.blogspot.com/ > > > -- Thanks & regards, Nirmal Senior Software Engineer- Platform Technologies Team, WSO2 Inc. Mobile: +94715779733 Blog: http://nirmalfdo.blogspot.com/
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
