On Thu, Apr 23, 2015 at 3:43 PM, Tharik Kanaka <[email protected]> wrote:
> Adding Dev group > > > Hi All, > > Following are the code review feedbacks for RDBMS Event Table. > > - Use Execution creation exception when adding event table which is a > runtime exception > > > - Use bloom filter enabled instead to making value true > > > - Load configurations in a static block instead of loading inside the > init method > > > - When there are aliases for streams, there will be a high priority > for aliases than the name of the stream (specially when joining 2 streams > > > - Remove cloning event when deletion of bloom filter (It is expensive > and it is done in cache) > > > - Partial updates (On specified properties) should be able to done > instead of updating all the properties > > > - No need to synchronise methods (In bloom filter) since Siddhi is not > concurrently accessed. > > Above fixes and suggestions are incorporated.. Thanks, Mohan > Regards, > > On Thu, Apr 23, 2015 at 10:27 AM, Mohanadarshan Vivekanandalingam < > [email protected]> wrote: > >> This event has been changed. >> more details » >> <https://www.google.com/calendar/event?action=VIEW&eid=YTRyaGl0dG9tMzY1cHJsdXRmbDdsNmZydDQgdGhhcmlrQHdzbzIuY29t&tok=MTQjbW9oYW5Ad3NvMi5jb204NGVkZDBhYjEyNjdhNWVmMWNmZjlhNDQ1NDhmYzkwM2I0YzhkZTA4&ctz=Asia/Colombo&hl=en> >> RDBMS Event Table Code Review / Discussion >> *When* >> *Changed: *Thu Apr 23, 2015 2pm – 3pm Colombo >> *Where* >> LK Trace Mezzanine Floor Board Room - Mordor Ext:1036211 (map >> <https://maps.google.lk/maps?q=LK+Trace+Mezzanine+Floor+Board+Room+-+Mordor+Ext:1036211&hl=en> >> ) >> *Video call* >> https://plus.google.com/hangouts/_/wso2.com/mohan >> <https://plus.google.com/hangouts/_/wso2.com/mohan?hceid=bW9oYW5Ad3NvMi5jb20.a4rhittom365prlutfl7l6frt4> >> *Calendar* >> [email protected] >> *Who* >> • >> Mohanadarshan Vivekanandalingam - organizer >> • >> Dilini Muthumala >> • >> Sachini Jayasekara >> • >> Tharik Kanaka >> • >> Rajeev Sampath >> • >> Damith Wickramasinghe >> • >> Sriskandarajah Suhothayan >> • >> Thilini Anoratna >> • >> Ramindu De Silva >> • >> Lasantha Fernando >> >> Going? *Yes >> <https://www.google.com/calendar/event?action=RESPOND&eid=YTRyaGl0dG9tMzY1cHJsdXRmbDdsNmZydDQgdGhhcmlrQHdzbzIuY29t&rst=1&tok=MTQjbW9oYW5Ad3NvMi5jb204NGVkZDBhYjEyNjdhNWVmMWNmZjlhNDQ1NDhmYzkwM2I0YzhkZTA4&ctz=Asia/Colombo&hl=en> >> - Maybe >> <https://www.google.com/calendar/event?action=RESPOND&eid=YTRyaGl0dG9tMzY1cHJsdXRmbDdsNmZydDQgdGhhcmlrQHdzbzIuY29t&rst=3&tok=MTQjbW9oYW5Ad3NvMi5jb204NGVkZDBhYjEyNjdhNWVmMWNmZjlhNDQ1NDhmYzkwM2I0YzhkZTA4&ctz=Asia/Colombo&hl=en> >> - No >> <https://www.google.com/calendar/event?action=RESPOND&eid=YTRyaGl0dG9tMzY1cHJsdXRmbDdsNmZydDQgdGhhcmlrQHdzbzIuY29t&rst=2&tok=MTQjbW9oYW5Ad3NvMi5jb204NGVkZDBhYjEyNjdhNWVmMWNmZjlhNDQ1NDhmYzkwM2I0YzhkZTA4&ctz=Asia/Colombo&hl=en>* >> more options » >> <https://www.google.com/calendar/event?action=VIEW&eid=YTRyaGl0dG9tMzY1cHJsdXRmbDdsNmZydDQgdGhhcmlrQHdzbzIuY29t&tok=MTQjbW9oYW5Ad3NvMi5jb204NGVkZDBhYjEyNjdhNWVmMWNmZjlhNDQ1NDhmYzkwM2I0YzhkZTA4&ctz=Asia/Colombo&hl=en> >> >> Invitation from Google Calendar <https://www.google.com/calendar/> >> >> You are receiving this email at the account [email protected] because you >> are subscribed for updated invitations on calendar [email protected]. >> >> To stop receiving these emails, please log in to >> https://www.google.com/calendar/ and change your notification settings >> for this calendar. >> > > > > > > > > -- > > *Tharik Kanaka* | Associate Software Engineer > > WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka > > Email: [email protected] | Web: www.wso2.com > -- *V. Mohanadarshan* *Software Engineer,* *Data Technologies Team,* *WSO2, Inc. http://wso2.com <http://wso2.com> * *lean.enterprise.middleware.* email: [email protected] phone:(+94) 771117673
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
