Hi, Please find the review notes below.
invert parameter regex to come first in the method Iterate InEvents in the test case and use. check for data is null and data is not the correct type for possible exception scenarios make each variable private Check for current state returning value Regards, Damith On Fri, Apr 24, 2015 at 12:20 PM, Ramindu De Silva <[email protected]> wrote: > This event has been changed. > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=MGtsam80MnNkcWNjdnE5bGs5Z2trbXNvdTQgZGFtaXRobkB3c28yLmNvbQ&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21mNGJhZDkyNDYwNTgzZmZkZjI2ZDRkODhhYzgyOGFiYjc0Y2Y1YmEx&ctz=Asia/Colombo&hl=en> > Code Review - Siddhi RegEx Function Extension > *When* > *Changed: *Fri Apr 24, 2015 2pm – 3pm Colombo > *Where* > LK Trace Mezzanine Floor Meeting Room - Gondor Ext:1036212 (map > <https://maps.google.lk/maps?q=LK+Trace+Mezzanine+Floor+Meeting+Room+-+Gondor+Ext:1036212&hl=en> > ) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/code-review > <https://plus.google.com/hangouts/_/wso2.com/code-review?hceid=cmFtaW5kdXNAd3NvMi5jb20.0kljo42sdqccvq9lk9gkkmsou4> > *Calendar* > [email protected] > *Who* > • > Ramindu De Silva - organizer > • > Dilini Muthumala > • > Sriskandarajah Suhothayan > • > Thilini Anoratna > • > Mohanadarshan Vivekanandalingam > • > Sachini Jayasekara > • > Rajeev Sampath > • > [email protected] > • > Lasantha Fernando > • > Tharik Kanaka > • > Damith Wickramasinghe > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=MGtsam80MnNkcWNjdnE5bGs5Z2trbXNvdTQgZGFtaXRobkB3c28yLmNvbQ&rst=1&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21mNGJhZDkyNDYwNTgzZmZkZjI2ZDRkODhhYzgyOGFiYjc0Y2Y1YmEx&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=MGtsam80MnNkcWNjdnE5bGs5Z2trbXNvdTQgZGFtaXRobkB3c28yLmNvbQ&rst=3&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21mNGJhZDkyNDYwNTgzZmZkZjI2ZDRkODhhYzgyOGFiYjc0Y2Y1YmEx&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=MGtsam80MnNkcWNjdnE5bGs5Z2trbXNvdTQgZGFtaXRobkB3c28yLmNvbQ&rst=2&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21mNGJhZDkyNDYwNTgzZmZkZjI2ZDRkODhhYzgyOGFiYjc0Y2Y1YmEx&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=MGtsam80MnNkcWNjdnE5bGs5Z2trbXNvdTQgZGFtaXRobkB3c28yLmNvbQ&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21mNGJhZDkyNDYwNTgzZmZkZjI2ZDRkODhhYzgyOGFiYjc0Y2Y1YmEx&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for updated invitations on calendar [email protected]. > > To stop receiving these emails, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- Software Engineer WSO2 Inc.; http://wso2.com <http://www.google.com/url?q=http%3A%2F%2Fwso2.com&sa=D&sntz=1&usg=AFQjCNEZvyc0uMD1HhBaEGCBxs6e9fBObg> lean.enterprise.middleware mobile: *+94728671315*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
