Hi Prabath, Yest its the plan. This is added as temporarily until we get that code portion working.
Regards, Dilshan On Thu, Apr 30, 2015 at 2:57 PM, Prabath Abeysekera <praba...@wso2.com> wrote: > > On Thu, Apr 30, 2015 at 2:54 PM, Dulitha Wijewantha <duli...@wso2.com> > wrote: > >> >> >> On Thu, Apr 30, 2015 at 2:35 PM, Prabath Abeysekera <praba...@wso2.com> >> wrote: >> >>> Hi Milan, >>> >>> On Thu, Apr 30, 2015 at 2:13 PM, Milan Perera <mi...@wso2.com> wrote: >>> >>>> Hi Dulitha, >>>> >>>> I have added features to the relevant table. Please find the PR[1]. >>>> >>> >>> The way this's already been done doesn't seem to be right. IMO, >>> persisting the feature metadata corresponding to a particular device >>> platform needs to be done at the point where the plugin gets registered >>> into the device management framework. The current approach hides some part >>> of business logic (registering device specific feature metadata) within the >>> database layer as the same is done through a SQL script, which should >>> ideally have been captured in the plug-in implementation itself. Please >>> review this again and try to get things improved along the approach >>> suggested above. >>> >> Are you saying to have another script to register features separately >> for each plugin? >> > > What I am suggesting is to get rid of all the "scripts" that are currently > used to persist metadata altogether. > > Cheers, > Prabath > > >> >> Also Dilshan/Milan can you please update this sheet [1] with the >> Operation Constants so that we can make it similar as much as possible. >> >> [1] - >> https://docs.google.com/a/wso2.com/spreadsheets/d/1MSKfzHigj6JBgW5EiH4O08A7s4owl43S9oUlx-T8Gvo/edit?usp=sharing >> >> >>> >>> Cheers, >>> Prabath >>> >>> >>>> >>>> [1] https://github.com/wso2/carbon-device-mgt-plugins/pull/4 >>>> >>>> Regards, >>>> >>>> On Thu, Apr 30, 2015 at 9:51 AM, Milan Perera <mi...@wso2.com> wrote: >>>> >>>>> Hi Dulitha, >>>>> >>>>> Features have not been added yet. Will do ASAP. >>>>> >>>>> Regards, >>>>> >>>>> On Thu, Apr 30, 2015 at 7:51 AM, Dulitha Wijewantha <duli...@wso2.com> >>>>> wrote: >>>>> >>>>>> Hi Milan, >>>>>> Have the features been added to the database? (Last time I checked, >>>>>> features weren't available in the database). >>>>>> Cheers~ >>>>>> >>>>>> On Thu, Apr 30, 2015 at 3:12 AM, Prabath Abeysekera < >>>>>> praba...@wso2.com> wrote: >>>>>> >>>>>>> Milan, please share this via dev@. >>>>>>> >>>>>>> On Thu, Apr 30, 2015 at 1:12 AM, Milan Perera <mi...@wso2.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> $subject can be found here: >>>>>>>> https://docs.google.com/a/wso2.com/document/d/1D5tcSh-uAT28e2nDLUzd4TQ-ohH27onekgS0E73CVHg/edit?usp=sharing >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> -- >>>>>>>> Milan Harindu Perera >>>>>>>> Software Engineer >>>>>>>> *WSO2, Inc* >>>>>>>> (+94) 77 309 7088 >>>>>>>> lean . enterprise . middleware >>>>>>>> <http://lk.linkedin.com/in/milanharinduperera> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Prabath Abeysekara >>>>>>> Technical Lead >>>>>>> WSO2 Inc. >>>>>>> Email: praba...@wso2.com >>>>>>> Mobile: +94774171471 >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dulitha Wijewantha (Chan) >>>>>> Software Engineer - Mobile Development >>>>>> WSO2 Inc >>>>>> Lean.Enterprise.Middleware >>>>>> * ~Email duli...@wso2.com <duli...@wso2mobile.com>* >>>>>> * ~Mobile +94712112165 <%2B94712112165>* >>>>>> * ~Website dulitha.me <http://dulitha.me>* >>>>>> * ~Twitter @dulitharw <https://twitter.com/dulitharw>* >>>>>> *~Github @dulichan <https://github.com/dulichan>* >>>>>> *~SO @chan <http://stackoverflow.com/users/813471/chan>* >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Milan Harindu Perera >>>>> Software Engineer >>>>> *WSO2, Inc* >>>>> (+94) 77 309 7088 >>>>> lean . enterprise . middleware >>>>> <http://lk.linkedin.com/in/milanharinduperera> >>>>> >>>> >>>> >>>> >>>> -- >>>> Milan Harindu Perera >>>> Software Engineer >>>> *WSO2, Inc* >>>> (+94) 77 309 7088 >>>> lean . enterprise . middleware >>>> <http://lk.linkedin.com/in/milanharinduperera> >>>> >>> >>> >>> >>> -- >>> Prabath Abeysekara >>> Technical Lead >>> WSO2 Inc. >>> Email: praba...@wso2.com >>> Mobile: +94774171471 >>> >> >> >> >> -- >> Dulitha Wijewantha (Chan) >> Software Engineer - Mobile Development >> WSO2 Inc >> Lean.Enterprise.Middleware >> * ~Email duli...@wso2.com <duli...@wso2mobile.com>* >> * ~Mobile +94712112165 <%2B94712112165>* >> * ~Website dulitha.me <http://dulitha.me>* >> * ~Twitter @dulitharw <https://twitter.com/dulitharw>* >> *~Github @dulichan <https://github.com/dulichan>* >> *~SO @chan <http://stackoverflow.com/users/813471/chan>* >> > > > > -- > Prabath Abeysekara > Technical Lead > WSO2 Inc. > Email: praba...@wso2.com > Mobile: +94774171471 > -- Dilshan Edirisuriya Senior Software Engineer - WSO2 Mob: + 94 777878905 http://wso2.com/ https://www.linkedin.com/profile/view?id=50486426
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
