Looping @Dev group On Mon, May 18, 2015 at 2:09 PM, Tharik Kanaka <[email protected]> wrote:
> Hi All, > > Please refer following code review feedbacks. > > *Component.xml* > > - Use a "manage" permission for siddhi try it instead if using "login" > permission > > *SiddhiTryItClient.java* > > - Change variable name beginTime to startTime to keep the consistency > - Add data source support and check extensions are working. > - Do not check only for first annotations there could be multiple > annotations in a siddhi query > - Use the common method to use read annotation instead of getting by > elements. > - Define event related variables inside the for loop block since those > are used inside the for loop > - Test for two types of streams (such as a join of streams) > - catch throwable since there could be execution plan validation > exceptions > - In the finally block check for null before checking shutdown > execution plan runtime > > *pom.xml (tryit feature)* > > - Add siddhi dependencies of core, compiler and api > > > Regards, > > On Fri, May 15, 2015 at 10:28 AM, Thilini Anoratna <[email protected]> > wrote: > >> more details » >> <https://www.google.com/calendar/event?action=VIEW&eid=ZXIyanU0NTNnNjcwbmxpc2VzNms4bW1zc2sgdGhhcmlrQHdzbzIuY29t&tok=MTcjdGhpbGluaWFAd3NvMi5jb20wZTYwNGYyZGMzYjc5YjA0ZDE5NTVhZDQzYThkZmUwNTE1YzU0ODky&ctz=Asia/Colombo&hl=en> >> Invitation: [Code Review][CEP] Siddhi Try It Feature >> *When* >> Mon May 18, 2015 12pm – 1pm Colombo >> *Where* >> LK Trace Mezzanine Floor Meeting Room - Gondor Ext:1036212 (map >> <https://maps.google.lk/maps?q=LK+Trace+Mezzanine+Floor+Meeting+Room+-+Gondor+Ext:1036212&hl=en> >> ) >> *Video call* >> https://plus.google.com/hangouts/_/wso2.com/invitation-code >> <https://plus.google.com/hangouts/_/wso2.com/invitation-code?hceid=dGhpbGluaWFAd3NvMi5jb20.er2ju453g670nlises6k8mmssk> >> *Calendar* >> [email protected] >> *Who* >> • >> Thilini Anoratna - organizer >> • >> Sachini Jayasekara >> • >> Dilini Muthumala >> • >> Sriskandarajah Suhothayan >> • >> Mohanadarshan Vivekanandalingam >> • >> Ramindu De Silva >> • >> Sajith Ravindra >> • >> Tharik Kanaka >> • >> Tishan Dahanayakage >> • >> Ayashkantha Ramasinghe >> • >> Damith Wickramasinghe >> • >> Lasantha Fernando >> • >> Rajeev Sampath >> >> Going? *Yes >> <https://www.google.com/calendar/event?action=RESPOND&eid=ZXIyanU0NTNnNjcwbmxpc2VzNms4bW1zc2sgdGhhcmlrQHdzbzIuY29t&rst=1&tok=MTcjdGhpbGluaWFAd3NvMi5jb20wZTYwNGYyZGMzYjc5YjA0ZDE5NTVhZDQzYThkZmUwNTE1YzU0ODky&ctz=Asia/Colombo&hl=en> >> - Maybe >> <https://www.google.com/calendar/event?action=RESPOND&eid=ZXIyanU0NTNnNjcwbmxpc2VzNms4bW1zc2sgdGhhcmlrQHdzbzIuY29t&rst=3&tok=MTcjdGhpbGluaWFAd3NvMi5jb20wZTYwNGYyZGMzYjc5YjA0ZDE5NTVhZDQzYThkZmUwNTE1YzU0ODky&ctz=Asia/Colombo&hl=en> >> - No >> <https://www.google.com/calendar/event?action=RESPOND&eid=ZXIyanU0NTNnNjcwbmxpc2VzNms4bW1zc2sgdGhhcmlrQHdzbzIuY29t&rst=2&tok=MTcjdGhpbGluaWFAd3NvMi5jb20wZTYwNGYyZGMzYjc5YjA0ZDE5NTVhZDQzYThkZmUwNTE1YzU0ODky&ctz=Asia/Colombo&hl=en>* >> more options » >> <https://www.google.com/calendar/event?action=VIEW&eid=ZXIyanU0NTNnNjcwbmxpc2VzNms4bW1zc2sgdGhhcmlrQHdzbzIuY29t&tok=MTcjdGhpbGluaWFAd3NvMi5jb20wZTYwNGYyZGMzYjc5YjA0ZDE5NTVhZDQzYThkZmUwNTE1YzU0ODky&ctz=Asia/Colombo&hl=en> >> >> Invitation from Google Calendar <https://www.google.com/calendar/> >> >> You are receiving this email at the account [email protected] because you >> are subscribed for invitations on calendar [email protected]. >> >> To stop receiving these emails, please log in to >> https://www.google.com/calendar/ and change your notification settings >> for this calendar. >> > > > > -- > > *Tharik Kanaka* | Associate Software Engineer > > WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka > > Email: [email protected] | Web: www.wso2.com > -- *Tharik Kanaka* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: [email protected] | Web: www.wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
