Hi Shakila, Yes I agree transport.vfs.MoveTimestampFormat is missing in the UI and needs to be added.
But there is no code fix required to support requirement given in the jira. Simple you can achieve this via following. transport.vfs.SubFolderTimestampFormat=yyyy/MM/dd transport.vfs.CreateFolder=true WDYT? However i am not sure this is the case for axis2 vfs. If not we may have to fix that. On Tue, May 19, 2015 at 2:29 PM, Shakila Sivagnanarajah <[email protected]> wrote: > Hi Malaka, > > I am not using transport.vfs.MoveTimestampFormat on this feature. But > VFSConstants.TRANSPORT_FILE_MOVE_TIMESTAMP_FORMAT is used in [1]. There > is no way to add this property via UI. > > [1] > https://github.com/Shakila/carbon-mediation/blob/develop/components/inbound-endpoints/org.wso2.carbon.inbound.endpoint/src/main/java/org/wso2/carbon/inbound/endpoint/protocol/file/FilePollingConsumer.java > > Thank you. > > On Tue, May 19, 2015 at 2:23 PM, Malaka Silva <[email protected]> wrote: > >> Hi Shakila, >> >> Where are you using transport.vfs.MoveTimestampFormat parameter? >> >> According to the PR it seems you are giving the functinality >> when transport.vfs.CreateFolder is true. >> >> >> - if (strSubfoldertimestamp != null) {+ if(vfsProperties.getProperty( >> VFSConstants.FORCE_CREATE_FOLDER).toLowerCase().equals("true")) { >> >> On Tue, May 19, 2015 at 2:07 PM, Shakila Sivagnanarajah <[email protected] >> > wrote: >> >>> Hi Malaka, >>> >>> I am not using transport.vfs.MoveTimestampFormat. But this property is >>> missing from UI. So I added. [1] is the new pull request. And I will do >>> this for axis2. >>> >>> [1] https://github.com/wso2/carbon-mediation/pull/162 >>> >>> Thank you >>> >>> On Tue, May 19, 2015 at 9:44 AM, Malaka Silva <[email protected]> wrote: >>> >>>> Hi Shakila, >>>> >>>> Yes Please do so. >>>> >>>> So basically your fix should only include >>>> transport.vfs.MoveTimestampFormat parameter? >>>> >>>> I guess they are referring to axis2 VFS in the jira. We may need to do >>>> the same for both. (Inbound and VFS) >>>> >>>> On Tue, May 19, 2015 at 9:28 AM, Shakila Sivagnanarajah < >>>> [email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> Yes I have done that with transport.vfs.SubFolderTimestampFormat, >>>>> transport.vfs.CreateFolder parameters only. And added one another >>>>> parameter. But the feature that already written will create only one >>>>> sub-folder with date. But the expected feature from the JIRA is creating >>>>> sub-folders with year, month and date like, >>>>> >>>>> 2013 >>>>> 09 >>>>> 29 >>>>> File1 >>>>> File2 >>>>> File3 >>>>> 30 >>>>> File4 >>>>> File5 >>>>> File6 >>>>> >>>>> So I moderated that accordingly. Can I give the PR again? >>>>> >>>>> Thank you >>>>> >>>>> >>>>> >>>>> On Tue, May 19, 2015 at 9:06 AM, Malaka Silva <[email protected]> wrote: >>>>> >>>>>> Hi Shakila, >>>>>> >>>>>> I have reviewed your fix. >>>>>> >>>>>> Basically their requirement is to create a folder for the date to >>>>>> move the processed file. >>>>>> >>>>>> I think we can do the same by using following parameter combination. >>>>>> WDYT? We may not need to patch it? >>>>>> >>>>>> 1. transport.vfs.SubFolderTimestampFormat >>>>>> 2. transport.vfs.CreateFolder >>>>>> >>>>>> Also observed that the PR you send does not contain the latest from >>>>>> develop branch. If we merge this we may loose some commits already done. >>>>>> eg:- >>>>>> PR says, >>>>>> *-file.optional=20* >>>>>> +file.optional=23 >>>>>> >>>>>> But actually in develop branch, >>>>>> *file.optional=22* >>>>>> >>>>>> On Mon, May 18, 2015 at 12:47 PM, Shakila Sivagnanarajah < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I added the feature mentioned in ESBJAVA-2509 and added one missing >>>>>>> vfs parameter. Please find the pull request at [1]. >>>>>>> >>>>>>> [1] https://github.com/wso2/carbon-mediation/pull/159/ >>>>>>> >>>>>>> Thank you >>>>>>> -- >>>>>>> Shakila Sivagnanarajah >>>>>>> Associate Software Engineer >>>>>>> Mobile :+94 (0) 770 760240 >>>>>>> [email protected] >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Best Regards, >>>>>> >>>>>> Malaka Silva >>>>>> Senior Tech Lead >>>>>> M: +94 777 219 791 >>>>>> Tel : 94 11 214 5345 >>>>>> Fax :94 11 2145300 >>>>>> Skype : malaka.sampath.silva >>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>>> >>>>>> WSO2, Inc. >>>>>> lean . enterprise . middleware >>>>>> http://www.wso2.com/ >>>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>>> <http://wso2.com/about/team/malaka-silva/> >>>>>> >>>>>> Save a tree -Conserve nature & Save the world for your future. Print >>>>>> this email only if it is absolutely necessary. >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Shakila Sivagnanarajah >>>>> Associate Software Engineer >>>>> Mobile :+94 (0) 770 760240 >>>>> [email protected] >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Best Regards, >>>> >>>> Malaka Silva >>>> Senior Tech Lead >>>> M: +94 777 219 791 >>>> Tel : 94 11 214 5345 >>>> Fax :94 11 2145300 >>>> Skype : malaka.sampath.silva >>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>> Blog : http://mrmalakasilva.blogspot.com/ >>>> >>>> WSO2, Inc. >>>> lean . enterprise . middleware >>>> http://www.wso2.com/ >>>> http://www.wso2.com/about/team/malaka-silva/ >>>> <http://wso2.com/about/team/malaka-silva/> >>>> >>>> Save a tree -Conserve nature & Save the world for your future. Print >>>> this email only if it is absolutely necessary. >>>> >>> >>> >>> >>> -- >>> Shakila Sivagnanarajah >>> Associate Software Engineer >>> Mobile :+94 (0) 770 760240 >>> [email protected] >>> >> >> >> >> -- >> >> Best Regards, >> >> Malaka Silva >> Senior Tech Lead >> M: +94 777 219 791 >> Tel : 94 11 214 5345 >> Fax :94 11 2145300 >> Skype : malaka.sampath.silva >> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >> Blog : http://mrmalakasilva.blogspot.com/ >> >> WSO2, Inc. >> lean . enterprise . middleware >> http://www.wso2.com/ >> http://www.wso2.com/about/team/malaka-silva/ >> <http://wso2.com/about/team/malaka-silva/> >> >> Save a tree -Conserve nature & Save the world for your future. Print this >> email only if it is absolutely necessary. >> > > > > -- > Shakila Sivagnanarajah > Associate Software Engineer > Mobile :+94 (0) 770 760240 > [email protected] > -- Best Regards, Malaka Silva Senior Tech Lead M: +94 777 219 791 Tel : 94 11 214 5345 Fax :94 11 2145300 Skype : malaka.sampath.silva LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 Blog : http://mrmalakasilva.blogspot.com/ WSO2, Inc. lean . enterprise . middleware http://www.wso2.com/ http://www.wso2.com/about/team/malaka-silva/ <http://wso2.com/about/team/malaka-silva/> Save a tree -Conserve nature & Save the world for your future. Print this email only if it is absolutely necessary.
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
