Hi Udara, I have fixed them now.
Thanks, On Tue, May 26, 2015 at 12:07 PM, Udara Liyanage <ud...@wso2.com> wrote: > Hi Anurudda, > > I put some comments for the pull request. Please consider/fix them. > > On Tue, May 26, 2015 at 11:56 AM, Anuruddha Liyanarachchi < > anurudd...@wso2.com> wrote: > >> Hi Imesh, >> >> I have now created configurator feature. >> Can you please review and merge [1] for the same. >> >> [1] https://github.com/wso2/product-private-paas/pull/73 >> >> Thanks >> >> On Tue, May 26, 2015 at 10:24 AM, Imesh Gunaratne <im...@wso2.com> wrote: >> >>> Hi Anuruddha, >>> >>> I think we also need to create a feature for the Configurator and use >>> that to build its product distribution. In addition we need to make sure >>> that Configurator maven artifacts are uploaded to Nexus on maven deploy >>> command. >>> >>> Thanks >>> >>> On Mon, May 25, 2015 at 9:20 PM, Imesh Gunaratne <im...@wso2.com> wrote: >>> >>>> Thanks Anuruddha! I reviewed your pull request and merged. >>>> >>>> >>>> On Mon, May 25, 2015 at 5:30 PM, Anuruddha Liyanarachchi < >>>> anurudd...@wso2.com> wrote: >>>> >>>>> Hi Imesh, >>>>> >>>>> I have now completed $subject. Can you please review and merge [1] >>>>> >>>>> [1]https://github.com/wso2/product-private-paas/pull/72 >>>>> >>>>> On Mon, May 25, 2015 at 12:25 PM, Imesh Gunaratne <im...@wso2.com> >>>>> wrote: >>>>> >>>>>> Hi Anuruddha, >>>>>> >>>>>> I think we need to move the Configurator to components folder [1] and >>>>>> rename it to org.wso2.ppaas.configurator. In addition we need to create a >>>>>> product inside products folder [2] for generating its distribution >>>>>> (wso2ppaas-configurator-4.1.0.zip). >>>>>> >>>>>> We need to follow the standard guidelines when creating the folder >>>>>> structure and maven modules. >>>>>> >>>>>> [1] >>>>>> https://github.com/wso2/product-private-paas/tree/master/components >>>>>> [2] https://github.com/wso2/product-private-paas/tree/master/products >>>>>> >>>>>> Thanks >>>>>> >>>>>> -- >>>>>> *Imesh Gunaratne* >>>>>> Senior Technical Lead >>>>>> WSO2 Inc: http://wso2.com >>>>>> T: +94 11 214 5345 M: +94 77 374 2057 >>>>>> W: http://imesh.gunaratne.org >>>>>> Lean . Enterprise . Middleware >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks and Regards,* >>>>> Anuruddha Lanka Liyanarachchi >>>>> Software Engineer - WSO2 >>>>> Mobile : +94 (0) 712762611 >>>>> Tel : +94 112 145 345 >>>>> a <thili...@wso2.com>nurudd...@wso2.com >>>>> >>>> >>>> >>>> >>>> -- >>>> *Imesh Gunaratne* >>>> Senior Technical Lead >>>> WSO2 Inc: http://wso2.com >>>> T: +94 11 214 5345 M: +94 77 374 2057 >>>> W: http://imesh.gunaratne.org >>>> Lean . Enterprise . Middleware >>>> >>>> >>> >>> >>> -- >>> *Imesh Gunaratne* >>> Senior Technical Lead >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: http://imesh.gunaratne.org >>> Lean . Enterprise . Middleware >>> >>> >> >> >> -- >> *Thanks and Regards,* >> Anuruddha Lanka Liyanarachchi >> Software Engineer - WSO2 >> Mobile : +94 (0) 712762611 >> Tel : +94 112 145 345 >> a <thili...@wso2.com>nurudd...@wso2.com >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > Udara Liyanage > Software Engineer > WSO2, Inc.: http://wso2.com > lean. enterprise. middleware > > web: http://udaraliyanage.wordpress.com > phone: +94 71 443 6897 > -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a <thili...@wso2.com>nurudd...@wso2.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
