Hi Imesh, I have changed the template extension and config.ini to module.ini in PR [1]. Can you please review and merge PR [1]
[1]https://github.com/wso2/product-private-paas/pull/77 Thanks, On Tue, May 26, 2015 at 7:52 PM, Anuruddha Liyanarachchi < [email protected]> wrote: > Hi Imesh, > > It is not a must to use .jinja extension. We can directly use axis.xml. I > used .jinja extension to indicate that it is a template file. > > +1 for renaming file to carbon.xml.template file. > > I will do the necessary changes and send a PR. > > Thanks > > > > On Tue, May 26, 2015 at 7:15 PM, Imesh Gunaratne <[email protected]> wrote: > >> In addition I think we could also include the actual file name in >> template files: >> >> >> Example: carbon.xml -> carbon.xml.jinja >> Then again is it a must to use jinja as the extension? Can't we rename it >> to template (carbon.xml.template)? >> >> Thanks >> >> >> On Tue, May 26, 2015 at 6:51 PM, Imesh Gunaratne <[email protected]> wrote: >> >>> Hi Devs, >>> >>> Currently in configurator, the template module's configuration file is >>> named as "configs.ini". IMO this is not appropriate. >>> >>> Shall we rename this to some thing similar to "module.ini"? If so it >>> would imply that each folder inside templates folder is a template module. >>> WDYT? >>> >>> Thanks >>> >>> -- >>> *Imesh Gunaratne* >>> Senior Technical Lead >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: http://imesh.gunaratne.org >>> Lean . Enterprise . Middleware >>> >>> >> >> >> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.gunaratne.org >> Lean . Enterprise . Middleware >> >> > > > -- > *Thanks and Regards,* > Anuruddha Lanka Liyanarachchi > Software Engineer - WSO2 > Mobile : +94 (0) 712762611 > Tel : +94 112 145 345 > a <[email protected]>[email protected] > -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a <[email protected]>[email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
