Hi Harsha,

This is not a ES specific config file. This is specific to the social
component which any product can install as a feature. Eg:- App Manager/App
Factory are currently using.
As I mentioned, without above change people need to modify their own
master-datasources.xml after installing social feature, Which is not right.


On Tue, Jun 9, 2015 at 1:06 PM, Harsha Kumara <[email protected]> wrote:

> Hi Udara,
>
> Will change the APIM side accordingly.
>
Ideally you don't have to do anything. If you guys going to use social
framework for comments/rating in future, just feature installation should
be enough.


> Since this data source config file contains only single data source, I
> think in future if ES side needs to add additional data sources, we can
> rename this data source file name to ES specific name and add data sources
> there.
>
> Thanks,
> Harsha
>
> On Tue, Jun 9, 2015 at 8:40 AM, Udara Rathnayake <[email protected]> wrote:
>
>> Hi All,
>>
>> $Subject. Previously we had the WSO2_SOCIAL_DB configuration within
>> master-datasources.xml hence we need to manually configure this after
>> installing the social feature(Or keep custom master-datasources.xml within
>> distribution source).
>>
>> With the following changes[1][2] we moved above configuration to a
>> separate config social-datasources.xml
>>
>> [1]
>> https://github.com/wso2/carbon-store/commit/45761aa7617050d82cf94489dcdb906af14a984c
>> [2]
>> https://github.com/wso2/product-es/commit/5c66139770e934d32a32a3ad4bdf6597f390a72d
>>
>> Regards,
>> UdaraR
>>
>> _______________________________________________
>> Dev mailing list
>> [email protected]
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Harsha Kumara
> Software Engineer, WSO2 Inc.
> Mobile: +94775505618
> Blog:harshcreationz.blogspot.com
>
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to