Hi,

I had a look at Docker best practices
<http://docs.docker.com/v1.2/articles/dockerfile_best-practices/#add-or-copy>
which
recommend to use COPY instead of ADD unless it is a tar.

"For other items (files, directories) that do not require ADD’s tar
auto-extraction capability, you should always use COPY."

With that we can improve WSO2 ESB cartridge by replacing ADD by COPY. Below
are some sample places which can be replaced.

ADD scripts/init.sh /usr/local/bin/init.sh
ADD scripts/export-envs.sh /tmp/export-envs.sh

ADD packages/${CONFIGURATOR_NAME}.zip /opt/
ADD packages/wso2esb-${WSO2_ESB_VERSION}.zip /opt/
ADD plugins /${PCA_HOME}/plugins

WDYT?


-- 

Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware

web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to