Hi Manoj, I got this fix reviewed by Carbon and Registry teams ((Kishanthan, Sagara, Chandana). In the fix review it was decided to add this DataHolder class.
Thanks, Bhathiya On Tue, Jun 9, 2015 at 5:05 PM, Manoj Kumara <[email protected]> wrote: > Hi Bhathiya, > > I can see that you have introduced a new DataHolder class with the fix. > Even though this is the proper pattern to follow since we are not allowing > introducing such changes with patches how to proceed on this. > > Regards, > Manoj > > > *Manoj Kumara |* Senior Software Engineer > Inc. *| **lean. enterprise. middleware.* > #20, Palm Grove, Colombo 03, Sri Lanka > *Mobile:* +94 713 448188 *|** Work:* +94 112 145345 > > > On Tue, Jun 9, 2015 at 1:41 PM, Bhathiya Jayasekara <[email protected]> > wrote: > >> Hi Kishanthan, >> >> Please review and commit the fix[1] to patch 11. Fix diff is attached to >> the JIRA itself. >> >> [1] https://wso2.org/jira/browse/REGISTRY-2561 >> >> Thanks, >> -- >> *Bhathiya Jayasekara* >> *Senior Software Engineer,* >> *WSO2 inc., http://wso2.com <http://wso2.com>* >> >> *Phone: +94715478185 <%2B94715478185>* >> *LinkedIn: http://www.linkedin.com/in/bhathiyaj >> <http://www.linkedin.com/in/bhathiyaj>* >> *Twitter: https://twitter.com/bhathiyax <https://twitter.com/bhathiyax>* >> *Blog: http://movingaheadblog.blogspot.com >> <http://movingaheadblog.blogspot.com/>* >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > -- *Bhathiya Jayasekara* *Senior Software Engineer,* *WSO2 inc., http://wso2.com <http://wso2.com>* *Phone: +94715478185* *LinkedIn: http://www.linkedin.com/in/bhathiyaj <http://www.linkedin.com/in/bhathiyaj>* *Twitter: https://twitter.com/bhathiyax <https://twitter.com/bhathiyax>* *Blog: http://movingaheadblog.blogspot.com <http://movingaheadblog.blogspot.com/>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
