Thanks Anjana for merging the carbon-analytics-common PR. I've just finished running DAS integration tests and no errors recorded. I think you can merge the other 2 PRs now.
On Mon, Jun 22, 2015 at 5:16 PM, Nirmal Fernando <[email protected]> wrote: > Hi Everyone, > > So, I have done basic testing in ML with this change and also verified > that DAS server starts up without any OSGi issue. > > Please see the following set of PRs for respective repos, and please read > the comments on the PR before merging. > Appreciate a quick merge on PR to Carbon-analytics-common repository. > > Carbon-analytics-common: > https://github.com/wso2/carbon-analytics-common/pull/50 > Carbon-analytics: https://github.com/wso2/carbon-analytics/pull/84 > Product-bam: https://github.com/wso2/product-bam/pull/15 > > On Mon, Jun 22, 2015 at 1:47 PM, Anjana Fernando <[email protected]> wrote: > >> Hi Niranda, >> >> Please check on this. >> >> Cheers, >> Anjana. >> >> On Mon, Jun 22, 2015 at 11:27 AM, Nirmal Fernando <[email protected]> >> wrote: >> >>> Hi DAS team, >>> >>> Can you please test DAS with the spark commons feature and see whether >>> there're any issues? >>> https://github.com/wso2/carbon-analytics-common/pull/50 >>> >>> Please note that you should remove spark bundling from the analytics >>> features in order to test this properly. >>> >>> On Wed, Jun 17, 2015 at 4:49 PM, Nirmal Fernando <[email protected]> >>> wrote: >>> >>>> Yes, Anjana! ML uses spark sql too, so, it can go to commons. >>>> >>>> On Wed, Jun 17, 2015 at 4:36 PM, Anjana Fernando <[email protected]> >>>> wrote: >>>> >>>>> Hi Nirmal, >>>>> >>>>> +1. Here, common Spark feature would contain I guess, the core Spark >>>>> libraries, that are common to both ML and DAS. And, our respective repos >>>>> will have our own specific Spark features like Spark SQL and MLlib. >>>>> >>>>> Cheers, >>>>> Anjana. >>>>> >>>>> On Wed, Jun 17, 2015 at 3:08 PM, Nirmal Fernando <[email protected]> >>>>> wrote: >>>>> >>>>>> Shall we maintain this in analytics-commons >>>>>> https://github.com/wso2/carbon-analytics-common ? >>>>>> >>>>>> On Wed, Jun 17, 2015 at 2:27 PM, Srinath Perera <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> +1 >>>>>>> >>>>>>> On Wed, Jun 17, 2015 at 11:44 AM, Nirmal Fernando <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> Currently, we do not have a common Spark feature, and ML bundles >>>>>>>> Spark bundles and related dependencies with ML core and DAS bundles the >>>>>>>> same in a DAS feature. Since, ML features can be installed in DAS and >>>>>>>> vice >>>>>>>> versa, to avoid conflicts that could occur due to the bundling of 2 >>>>>>>> versions of same Jar, we better build a common spark *feature*. >>>>>>>> Wdyt? >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> Thanks & regards, >>>>>>>> Nirmal >>>>>>>> >>>>>>>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>>>>>>> Mobile: +94715779733 >>>>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> ============================ >>>>>>> Blog: http://srinathsview.blogspot.com twitter:@srinath_perera >>>>>>> Site: http://people.apache.org/~hemapani/ >>>>>>> Photos: http://www.flickr.com/photos/hemapani/ >>>>>>> Phone: 0772360902 >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & regards, >>>>>> Nirmal >>>>>> >>>>>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>>>>> Mobile: +94715779733 >>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Anjana Fernando* >>>>> Senior Technical Lead >>>>> WSO2 Inc. | http://wso2.com >>>>> lean . enterprise . middleware >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Thanks & regards, >>>> Nirmal >>>> >>>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>>> Mobile: +94715779733 >>>> Blog: http://nirmalfdo.blogspot.com/ >>>> >>>> >>>> >>> >>> >>> -- >>> >>> Thanks & regards, >>> Nirmal >>> >>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>> Mobile: +94715779733 >>> Blog: http://nirmalfdo.blogspot.com/ >>> >>> >>> >> >> >> -- >> *Anjana Fernando* >> Senior Technical Lead >> WSO2 Inc. | http://wso2.com >> lean . enterprise . middleware >> > > > > -- > > Thanks & regards, > Nirmal > > Associate Technical Lead - Data Technologies Team, WSO2 Inc. > Mobile: +94715779733 > Blog: http://nirmalfdo.blogspot.com/ > > > -- Thanks & regards, Nirmal Associate Technical Lead - Data Technologies Team, WSO2 Inc. Mobile: +94715779733 Blog: http://nirmalfdo.blogspot.com/
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
