Hi Kasun/Nirmal, As I remember some of the Lucene jars have SPI files with the same name. Thats why we embed the jars. Now I am creating Lucene 5.2.1 bundles without embedding jars and proper SPI loading. So there wont be these issues.
On Thu, Jul 2, 2015 at 11:26 AM, KasunG Gajasinghe <[email protected]> wrote: > Hi Gimantha, > > Is there any particular reason to embed the jars instead of including all > the packages in-line? > > On Thu, Jul 2, 2015 at 10:58 AM, Nirmal Fernando <[email protected]> wrote: > >> Gimantha, >> >> I think we have to follow the proper way of doing it. This orbit bundle >> shouldn't be any different to other orbits IMO and more importantly it >> doesn't work if we don't package classes in an external Spark environment. >> >> @Kernel team please advice. >> >> On Sun, Jun 28, 2015 at 9:19 PM, Nirmal Fernando <[email protected]> wrote: >> >>> Thanks Gimantha, but when this jar runs on a non-OSGi environment like >>> an external Spark, it failed to find the packages without the above diff. >>> >>> On Sun, Jun 28, 2015 at 9:13 PM, Gimantha Bandara <[email protected]> >>> wrote: >>> >>>> Hi Nirmal, >>>> >>>> Since we have embedded the jar files, exporting the packages would have >>>> duplicated the classes by packing the classes. '_exportcontents' exposes >>>> the classes of the embedded jars without packing them. >>>> >>>> On Sun, Jun 28, 2015 at 11:16 AM, Nirmal Fernando <[email protected]> >>>> wrote: >>>> >>>>> Noticed $subject. Any reason for this? Following patch, did pack the >>>>> class files. >>>>> >>>>> *diff --git a/lucene/4.10.3.wso2v2/pom.xml >>>>> b/lucene/4.10.3.wso2v2/pom.xml* >>>>> >>>>> *index 5ba4669..84cf7ce 100644* >>>>> >>>>> *--- a/lucene/4.10.3.wso2v2/pom.xml* >>>>> >>>>> *+++ b/lucene/4.10.3.wso2v2/pom.xml* >>>>> >>>>> @@ -109,6 +109,9 @@ >>>>> >>>>> >>>>> <Bundle-SymbolicName>${project.artifactId}</Bundle-SymbolicName> >>>>> >>>>> >>>>> <Bundle-Name>${project.artifactId}</Bundle-Name> >>>>> >>>>> >>>>> <_exportcontents>org.apache.lucene.*;version="4.10.3"</_exportcontents> >>>>> >>>>> + <Export-Package> >>>>> >>>>> + org.apache.lucene.*;version="4.10.3"; >>>>> -split-package:=merge-first, >>>>> >>>>> + </Export-Package> >>>>> >>>>> <Import-Package> >>>>> >>>>> !org.apache.lucene.*, >>>>> >>>>> org.antlr.runtime.*; >>>>> version="[3.2.0,3.3.0)", >>>>> >>>>> -- >>>>> >>>>> Thanks & regards, >>>>> Nirmal >>>>> >>>>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>>>> Mobile: +94715779733 >>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Gimantha Bandara >>>> Software Engineer >>>> WSO2. Inc : http://wso2.com >>>> Mobile : +94714961919 >>>> >>> >>> >>> >>> -- >>> >>> Thanks & regards, >>> Nirmal >>> >>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>> Mobile: +94715779733 >>> Blog: http://nirmalfdo.blogspot.com/ >>> >>> >>> >> >> >> -- >> >> Thanks & regards, >> Nirmal >> >> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >> Mobile: +94715779733 >> Blog: http://nirmalfdo.blogspot.com/ >> >> >> > > > -- > > *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. > email: kasung AT spamfree wso2.com > linked-in: http://lk.linkedin.com/in/gajasinghe > blog: http://kasunbg.org > > > -- Gimantha Bandara Software Engineer WSO2. Inc : http://wso2.com Mobile : +94714961919
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
