Thanks Vanjikumaran, Now I have removed the file.
On Tue, Jul 21, 2015 at 1:43 AM, Vanjikumaran Sivajothy <[email protected]> wrote: > in your pull request i can see unwanted binary file (.DS_Store) . Please > remove it from the PR > > On Mon, Jul 20, 2015 at 11:23 AM, Kathees Rajendram <[email protected]> > wrote: > >> Hi Shakila, >> >> You can run the ESB Kafka Inbound sample 904 and make sure other Kafka >> functionality is not affected. >> >> Thanks, >> Kathees >> >> On Mon, Jul 20, 2015 at 9:51 PM, Shakila Sivagnanarajah <[email protected] >> > wrote: >> >>> Yes Malaka, I have tested with this change. This does not affect others. >>> >>> >>> On Mon, Jul 20, 2015 at 5:47 PM, Malaka Silva <[email protected]> wrote: >>> >>>> Have you tested the other inbound type after the change? >>>> >>>> On Mon, Jul 20, 2015 at 10:50 AM, Shakila Sivagnanarajah < >>>> [email protected]> wrote: >>>> >>>>> Hi Malaka, >>>>> >>>>> I have modified the code according to your comment. Please find the PR >>>>> [1]. >>>>> [1] https://github.com/wso2/carbon-mediation/pull/294 >>>>> >>>>> Thank you >>>>> >>>>> On Fri, Jul 17, 2015 at 5:21 PM, Malaka Silva <[email protected]> wrote: >>>>> >>>>>> Hi Shakila, >>>>>> >>>>>> Added some comments. >>>>>> >>>>>> Did you check other inbound protocols with this change? >>>>>> >>>>>> Don't we need to apply the same for update page as well? >>>>>> >>>>>> On Fri, Jul 17, 2015 at 4:55 PM, Shakila Sivagnanarajah < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Malaka, >>>>>>> >>>>>>> Please review and merge PR[1] for $subject. >>>>>>> >>>>>>> [1] https://github.com/wso2/carbon-mediation/pull/294 >>>>>>> >>>>>>> >>>>>>> Thank you >>>>>>> -- >>>>>>> Shakila Sivagnanarajah >>>>>>> Associate Software Engineer >>>>>>> Mobile :+94 (0) 770 760240 >>>>>>> [email protected] >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Best Regards, >>>>>> >>>>>> Malaka Silva >>>>>> Senior Tech Lead >>>>>> M: +94 777 219 791 >>>>>> Tel : 94 11 214 5345 >>>>>> Fax :94 11 2145300 >>>>>> Skype : malaka.sampath.silva >>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>>> >>>>>> WSO2, Inc. >>>>>> lean . enterprise . middleware >>>>>> http://www.wso2.com/ >>>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>>> <http://wso2.com/about/team/malaka-silva/> >>>>>> >>>>>> Save a tree -Conserve nature & Save the world for your future. Print >>>>>> this email only if it is absolutely necessary. >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Shakila Sivagnanarajah >>>>> Associate Software Engineer >>>>> Mobile :+94 (0) 770 760240 >>>>> [email protected] >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Best Regards, >>>> >>>> Malaka Silva >>>> Senior Tech Lead >>>> M: +94 777 219 791 >>>> Tel : 94 11 214 5345 >>>> Fax :94 11 2145300 >>>> Skype : malaka.sampath.silva >>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>> Blog : http://mrmalakasilva.blogspot.com/ >>>> >>>> WSO2, Inc. >>>> lean . enterprise . middleware >>>> http://www.wso2.com/ >>>> http://www.wso2.com/about/team/malaka-silva/ >>>> <http://wso2.com/about/team/malaka-silva/> >>>> >>>> Save a tree -Conserve nature & Save the world for your future. Print >>>> this email only if it is absolutely necessary. >>>> >>> >>> >>> >>> -- >>> Shakila Sivagnanarajah >>> Associate Software Engineer >>> Mobile :+94 (0) 770 760240 >>> [email protected] >>> >> >> >> >> -- >> Kathees >> Software Engineer, >> email: [email protected] >> mobile: +94772596173 >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Vanjikumaran Sivajothy > *Associate Technical Lead* > *WSO2 Inc. http://wso2.com <http://wso2.com/>* > *USA Mobile **+1-812-361-1286* > *Srilanka Mobile:+94-777-219-209* > [image: Facebook] <https://www.facebook.com/vanjikumaran> [image: Twitter] > <https://twitter.com/vanjikumaran> [image: LinkedIn] > <http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> [image: > Blogger] <http://vanjikumaran.blogspot.com/> [image: SlideShare] > <http://www.slideshare.net/vanjikumaran> > > This communication may contain privileged or other > confidential information and is intended exclusively for the addressee/s. > If you are not the intended recipient/s, or believe that you may > have received this communication in error, please reply to the > sender indicating that fact and delete the copy you received and in > addition, you should not print, copy, re-transmit, disseminate, or > otherwise use the information contained in this communication. > Internet communications cannot be guaranteed to be timely, secure, error > or virus-free. The sender does not accept liability for any errors > or omissions > -- Shakila Sivagnanarajah Associate Software Engineer Mobile :+94 (0) 770 760240 [email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
