Hi Kasun, Please find the inline answers.
On Tue, Jul 21, 2015 at 8:39 PM, KasunG Gajasinghe <[email protected]> wrote: > Hi Nuwan, > > Can you please answer following questions regarding this PR? > > 1. Can you rename to module name "tests-with-ldap" to > "tests-ldap-userstores". I believe that's more meaningful. > Yes. This is more meaningful. will rename the module > > 2. Shouldn't the distribution-with-apache-ldap be placed under > tests-common module? We need a proper name for this module as well, since > for new eyes, the name seems to be less meaningful. How about > ldap-installed-wso2as-distribution? Please let me know if you have a better > name. :-) > I do not think the module which build distribution move into tests-common module. tests-common module contains the AS test utilities. Having a new distribution in integration level is fine. I will discuss and put a meaningful name for the module which built AS distribution having Apache Ldap server feature itself > > 3. What does it mean to have a test case with only a @Factory annotation - > ReadWriteLdapUserStoreAdminUserTestCase > I did not duplicate the UserManagement Test cases in this test module. I reuse the same user management test cases which are in the tests module already implemented for JDBC user store. So I implement a new class extending the existing class. Then same test methods are executing against the readwrite Ldap user store . In that class We have to implement a constructor with @Factory annotation referring the same data provider in order to execute the test class. > > 4. The sub-modules should not have the version tag in maven dependencies. > The version should be defined in the root pom. > Fixed it by removing version. Thanks, Nuwanw > > Thanks. > > > On Tue, Jul 21, 2015 at 2:53 PM, Nuwan Wimalasekara <[email protected]> > wrote: > >> Hi, >> >> We have integrate a tests module(tests-with-ldap)[1] in AS integration >> to test the user management in AS with apache Ldap server as the user >> store. Ldap server feature is installed on AS by building a distribution >> with ldap server feature and the built server is used by the >> tests-with-ldap module throughout the test execution. >> >> This module executes 100 test cases with the user store as ReadWrite and >> ReadOnly modes by changing the user-mgt.xml. All the user management test >> cases in tests module are executed against the ReadWrite Ldap user store >> and implemented a test class to test the ReadOnly Ldap functionalities as >> well. >> >> [1] https://github.com/wso2/product-as/pull/152 >> >> Please refer the attached surefire-reports.zip for test cases >> >> Thanks, >> Nuwanw >> >> -- >> Nuwan Wimalasekara >> Senior Software Engineer - Test Automation >> WSO2, Inc.: http://wso2.com >> lean. enterprise. middleware >> >> phone: +94 71 668 4620 >> >> >> >> > > > -- > > *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. > email: kasung AT spamfree wso2.com > linked-in: http://lk.linkedin.com/in/gajasinghe > blog: http://kasunbg.org > > > -- Nuwan Wimalasekara Senior Software Engineer - Test Automation WSO2, Inc.: http://wso2.com lean. enterprise. middleware phone: +94 71 668 4620
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
