Hi All, Please review and merge the revised fix.
https://github.com/wso2/carbon4-kernel/pull/327 Pls note: I have only used following since it'll resolve the tenant id internally. privilegedCarbonContext.setTenantDomain(tenantDomain, true); On Fri, Jul 24, 2015 at 12:31 PM, Malaka Silva <[email protected]> wrote: > Hi All, > > Please review and merge the revised fix. > > https://github.com/wso2/carbon4-kernel/pull/327 > > On Fri, Jul 24, 2015 at 9:52 AM, Malaka Silva <[email protected]> wrote: > >> Well we get the required info from the url and that logic is inside and >> cannot bring to the startup. >> >> On Fri, Jul 24, 2015 at 9:29 AM, Supun Malinga <[email protected]> wrote: >> >>> Hi Malaka, >>> >>> Fix looks better now.. Can you also check why the tenant domain is not >>> set when starting the tenant flow ?. Please see below on how to use CC.. >>> >>> https://docs.wso2.com/display/Carbon420/CarbonContext+API#CarbonContextAPI-Switchingtenantflows >>> >>> thanks, >>> >>> On Thu, Jul 23, 2015 at 8:49 PM, Malaka Silva <[email protected]> wrote: >>> >>>> Hi All, >>>> >>>> Please review and merge the revised fix. >>>> >>>> [1] https://github.com/wso2/carbon4-kernel/pull/325 >>>> >>>> On Thu, Jul 23, 2015 at 4:46 PM, Supun Malinga <[email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> We (Azeez, Sameera & me) had a chat on this. Seems >>>>> in MultitenantMessageReceiver it has violated the usage of >>>>> PrivilegedCarbonContext usages. Usually we should do >>>>> PrivilegedCarbonContext.getThreadLocalCarbonContext() startTenantFlow(), >>>>> PrivilegedCarbonContext.getThreadLocalCarbonContext(). >>>>> endTenantFlow() and put the required logic in between. Then it should >>>>> not be required to call PrivilegedCarbonContext.destroyCurrentContext(). >>>>> >>>>> We need to properly fix this in MultitenantMessageReceiver.. There are >>>>> several places MultitenantMessageReceiver has done the same mistake. >>>>> >>>>> However we are so close the kernel 4.4.1 RC and we might not have >>>>> enough time to do this. How should we proceed ?. >>>>> >>>>> thanks, >>>>> >>>>> On Thu, Jul 23, 2015 at 9:20 AM, Malaka Silva <[email protected]> wrote: >>>>> >>>>>> thx >>>>>> >>>>>> On Thu, Jul 23, 2015 at 8:54 AM, Supun Malinga <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> The fix seems appropriate. Will discuss with the team further and >>>>>>> merge this today.. >>>>>>> For the integration tests, is there no way to verify the fix without >>>>>>> doing load requests ?. >>>>>>> >>>>>>> thanks, >>>>>>> >>>>>>> On Wed, Jul 22, 2015 at 1:39 PM, Supun Malinga <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi Malaka, >>>>>>>> >>>>>>>> Can you point out the place where its being set in message context >>>>>>>> ?. Basically I want to understand why we cannot destroy the context at >>>>>>>> that >>>>>>>> level (after the usage of CC is done). >>>>>>>> >>>>>>>> thanks, >>>>>>>> >>>>>>>> On Tue, Jul 21, 2015 at 8:10 PM, Malaka Silva <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi Supun, >>>>>>>>> >>>>>>>>> This issue can only be reproduced if you do a load test parallel >>>>>>>>> with two or more tenants. >>>>>>>>> >>>>>>>>> Here tenant domain is set with the value from message context. >>>>>>>>> This fix will clean the thread context before setting the new context. >>>>>>>>> >>>>>>>>> On Tue, Jul 21, 2015 at 7:45 PM, Supun Malinga <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi Malaka, >>>>>>>>>> >>>>>>>>>> Can you explain the fix you have done pls ?. We need to >>>>>>>>>> understand that the fix is the optimal one. >>>>>>>>>> >>>>>>>>>> Also do we have integration tests for the fix in kernel or ESB >>>>>>>>>> level ?. Please note it is better if we can have a test case for >>>>>>>>>> this in >>>>>>>>>> kernel itself. >>>>>>>>>> >>>>>>>>>> thanks, >>>>>>>>>> >>>>>>>>>> On Tue, Jul 21, 2015 at 4:33 PM, Malaka Silva <[email protected]> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Carbon Team, >>>>>>>>>>> >>>>>>>>>>> Please review and merge this before the next release. >>>>>>>>>>> >>>>>>>>>>> On Tue, Jul 21, 2015 at 4:29 PM, Malaka Silva <[email protected]> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Any update on this? >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Jul 13, 2015 at 10:35 AM, Malaka Silva <[email protected] >>>>>>>>>>>> > wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Carbon Team, >>>>>>>>>>>>> >>>>>>>>>>>>> Any update on this? >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Jul 2, 2015 at 12:11 PM, Malaka Silva <[email protected] >>>>>>>>>>>>> > wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Carbon Team, >>>>>>>>>>>>>> >>>>>>>>>>>>>> I have reproduced the issue and have done a fix. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Please review and merge. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Related jira's [1] and [2]. Fix with [3] >>>>>>>>>>>>>> >>>>>>>>>>>>>> [1] https://wso2.org/jira/browse/ESBJAVA-3801 >>>>>>>>>>>>>> [2] https://wso2.org/jira/browse/CARBON-15294 >>>>>>>>>>>>>> [3] https://github.com/wso2/carbon4-kernel/pull/264 >>>>>>>>>>>>>> >>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Malaka Silva >>>>>>>>>>>>>> Senior Tech Lead >>>>>>>>>>>>>> M: +94 777 219 791 >>>>>>>>>>>>>> Tel : 94 11 214 5345 >>>>>>>>>>>>>> Fax :94 11 2145300 >>>>>>>>>>>>>> Skype : malaka.sampath.silva >>>>>>>>>>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>>>>>>>>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>>>>>>>>>>> >>>>>>>>>>>>>> WSO2, Inc. >>>>>>>>>>>>>> lean . enterprise . middleware >>>>>>>>>>>>>> http://www.wso2.com/ >>>>>>>>>>>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>>>>>>>>>>> <http://wso2.com/about/team/malaka-silva/> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Save a tree -Conserve nature & Save the world for your >>>>>>>>>>>>>> future. Print this email only if it is absolutely necessary. >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> >>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>> >>>>>>>>>>>>> Malaka Silva >>>>>>>>>>>>> Senior Tech Lead >>>>>>>>>>>>> M: +94 777 219 791 >>>>>>>>>>>>> Tel : 94 11 214 5345 >>>>>>>>>>>>> Fax :94 11 2145300 >>>>>>>>>>>>> Skype : malaka.sampath.silva >>>>>>>>>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>>>>>>>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>>>>>>>>>> >>>>>>>>>>>>> WSO2, Inc. >>>>>>>>>>>>> lean . enterprise . middleware >>>>>>>>>>>>> http://www.wso2.com/ >>>>>>>>>>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>>>>>>>>>> <http://wso2.com/about/team/malaka-silva/> >>>>>>>>>>>>> >>>>>>>>>>>>> Save a tree -Conserve nature & Save the world for your future. >>>>>>>>>>>>> Print this email only if it is absolutely necessary. >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> >>>>>>>>>>>> Best Regards, >>>>>>>>>>>> >>>>>>>>>>>> Malaka Silva >>>>>>>>>>>> Senior Tech Lead >>>>>>>>>>>> M: +94 777 219 791 >>>>>>>>>>>> Tel : 94 11 214 5345 >>>>>>>>>>>> Fax :94 11 2145300 >>>>>>>>>>>> Skype : malaka.sampath.silva >>>>>>>>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>>>>>>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>>>>>>>>> >>>>>>>>>>>> WSO2, Inc. >>>>>>>>>>>> lean . enterprise . middleware >>>>>>>>>>>> http://www.wso2.com/ >>>>>>>>>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>>>>>>>>> <http://wso2.com/about/team/malaka-silva/> >>>>>>>>>>>> >>>>>>>>>>>> Save a tree -Conserve nature & Save the world for your future. >>>>>>>>>>>> Print this email only if it is absolutely necessary. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> >>>>>>>>>>> Best Regards, >>>>>>>>>>> >>>>>>>>>>> Malaka Silva >>>>>>>>>>> Senior Tech Lead >>>>>>>>>>> M: +94 777 219 791 >>>>>>>>>>> Tel : 94 11 214 5345 >>>>>>>>>>> Fax :94 11 2145300 >>>>>>>>>>> Skype : malaka.sampath.silva >>>>>>>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>>>>>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>>>>>>>> >>>>>>>>>>> WSO2, Inc. >>>>>>>>>>> lean . enterprise . middleware >>>>>>>>>>> http://www.wso2.com/ >>>>>>>>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>>>>>>>> <http://wso2.com/about/team/malaka-silva/> >>>>>>>>>>> >>>>>>>>>>> Save a tree -Conserve nature & Save the world for your future. >>>>>>>>>>> Print this email only if it is absolutely necessary. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Supun Malinga, >>>>>>>>>> >>>>>>>>>> Senior Software Engineer, >>>>>>>>>> WSO2 Inc. >>>>>>>>>> http://wso2.com >>>>>>>>>> email: [email protected] <[email protected]> >>>>>>>>>> mobile: +94 (0)71 56 91 321 >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Best Regards, >>>>>>>>> >>>>>>>>> Malaka Silva >>>>>>>>> Senior Tech Lead >>>>>>>>> M: +94 777 219 791 >>>>>>>>> Tel : 94 11 214 5345 >>>>>>>>> Fax :94 11 2145300 >>>>>>>>> Skype : malaka.sampath.silva >>>>>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>>>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>>>>>> >>>>>>>>> WSO2, Inc. >>>>>>>>> lean . enterprise . middleware >>>>>>>>> http://www.wso2.com/ >>>>>>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>>>>>> <http://wso2.com/about/team/malaka-silva/> >>>>>>>>> >>>>>>>>> Save a tree -Conserve nature & Save the world for your future. >>>>>>>>> Print this email only if it is absolutely necessary. >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Supun Malinga, >>>>>>>> >>>>>>>> Senior Software Engineer, >>>>>>>> WSO2 Inc. >>>>>>>> http://wso2.com >>>>>>>> email: [email protected] <[email protected]> >>>>>>>> mobile: +94 (0)71 56 91 321 >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Supun Malinga, >>>>>>> >>>>>>> Senior Software Engineer, >>>>>>> WSO2 Inc. >>>>>>> http://wso2.com >>>>>>> email: [email protected] <[email protected]> >>>>>>> mobile: +94 (0)71 56 91 321 >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Best Regards, >>>>>> >>>>>> Malaka Silva >>>>>> Senior Tech Lead >>>>>> M: +94 777 219 791 >>>>>> Tel : 94 11 214 5345 >>>>>> Fax :94 11 2145300 >>>>>> Skype : malaka.sampath.silva >>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>>> >>>>>> WSO2, Inc. >>>>>> lean . enterprise . middleware >>>>>> http://www.wso2.com/ >>>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>>> <http://wso2.com/about/team/malaka-silva/> >>>>>> >>>>>> Save a tree -Conserve nature & Save the world for your future. Print >>>>>> this email only if it is absolutely necessary. >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Supun Malinga, >>>>> >>>>> Senior Software Engineer, >>>>> WSO2 Inc. >>>>> http://wso2.com >>>>> email: [email protected] <[email protected]> >>>>> mobile: +94 (0)71 56 91 321 >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Best Regards, >>>> >>>> Malaka Silva >>>> Senior Tech Lead >>>> M: +94 777 219 791 >>>> Tel : 94 11 214 5345 >>>> Fax :94 11 2145300 >>>> Skype : malaka.sampath.silva >>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>> Blog : http://mrmalakasilva.blogspot.com/ >>>> >>>> WSO2, Inc. >>>> lean . enterprise . middleware >>>> http://www.wso2.com/ >>>> http://www.wso2.com/about/team/malaka-silva/ >>>> <http://wso2.com/about/team/malaka-silva/> >>>> >>>> Save a tree -Conserve nature & Save the world for your future. Print >>>> this email only if it is absolutely necessary. >>>> >>> >>> >>> >>> -- >>> Supun Malinga, >>> >>> Senior Software Engineer, >>> WSO2 Inc. >>> http://wso2.com >>> email: [email protected] <[email protected]> >>> mobile: +94 (0)71 56 91 321 >>> >> >> >> >> -- >> >> Best Regards, >> >> Malaka Silva >> Senior Tech Lead >> M: +94 777 219 791 >> Tel : 94 11 214 5345 >> Fax :94 11 2145300 >> Skype : malaka.sampath.silva >> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >> Blog : http://mrmalakasilva.blogspot.com/ >> >> WSO2, Inc. >> lean . enterprise . middleware >> http://www.wso2.com/ >> http://www.wso2.com/about/team/malaka-silva/ >> <http://wso2.com/about/team/malaka-silva/> >> >> Save a tree -Conserve nature & Save the world for your future. Print this >> email only if it is absolutely necessary. >> > > > > -- > > Best Regards, > > Malaka Silva > Senior Tech Lead > M: +94 777 219 791 > Tel : 94 11 214 5345 > Fax :94 11 2145300 > Skype : malaka.sampath.silva > LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 > Blog : http://mrmalakasilva.blogspot.com/ > > WSO2, Inc. > lean . enterprise . middleware > http://www.wso2.com/ > http://www.wso2.com/about/team/malaka-silva/ > <http://wso2.com/about/team/malaka-silva/> > > Save a tree -Conserve nature & Save the world for your future. Print this > email only if it is absolutely necessary. > -- Best Regards, Malaka Silva Senior Tech Lead M: +94 777 219 791 Tel : 94 11 214 5345 Fax :94 11 2145300 Skype : malaka.sampath.silva LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 Blog : http://mrmalakasilva.blogspot.com/ WSO2, Inc. lean . enterprise . middleware http://www.wso2.com/ http://www.wso2.com/about/team/malaka-silva/ <http://wso2.com/about/team/malaka-silva/> Save a tree -Conserve nature & Save the world for your future. Print this email only if it is absolutely necessary.
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
