Hi Darshana, The p2.inf of tenant-mgt has been copying to the multitenancy folder since carbon 4.2.0 [1] and products have been copying this to the conf folder via their bin.xml which the carbon refers. Any reason as to why the tenant-mgt.xml needs to be copied to the multitenancy folder in the p2.inf?
[1] - https://svn.wso2.com/wso2/custom/projects/projects/carbon/turing/platform/trunk/features/stratos/common/org.wso2.carbon.stratos.common.server.feature/2.2.2/resources Regards, Nira On Mon, Aug 3, 2015 at 1:47 PM, Darshana Gunawardana <[email protected]> wrote: > According to pattern we keep config files, tenant-mgt.xml should be in > conf/multitenancy/ folder. Can't we have a third option to fix [1]? > > [1] - > https://github.com/wso2/carbon4-kernel/blame/v4.4.1-RC2/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/config/TenantMgtXMLProcessor.java#L137 > > Thanks, > Darshana. > > On Mon, Aug 3, 2015 at 1:23 PM, Danushka Fernando <[email protected]> > wrote: > >> IMO it should be in the feature. Hence +1 for the option #2. >> >> Thanks & Regards >> Danushka Fernando >> Senior Software Engineer >> WSO2 inc. http://wso2.com/ >> Mobile : +94716332729 >> >> On Mon, Aug 3, 2015 at 12:36 PM, Niranjan Karunanandham < >> [email protected]> wrote: >> >>> Hi all, >>> >>> In Carbon [1], it checks for the tenant-mgt.xml in the >>> <PRODUCT_HOME>/repository/conf directory, but in the p2.inf of the >>> tenant-mgt (carbon-multitenancy repo), it is copied to >>> <PRODUCT_HOME>/repository/conf/multitenancy. Therefore to fix this there >>> are two solutions: >>> >>> 1. Explicitly mention in the bin.xml of the product source to copy >>> the tenant-mgt.xml from the multitenancy to conf directory (or) >>> 2. Modify the p2.inf in tenant-mgt feature to copy the >>> tenant-mgt.xml to conf directly. >>> >>> Which one is correct? IMO, the latter fix will resolution the issue and >>> products need not mention this in their bin.xml. >>> >>> >>> [1] - >>> https://github.com/wso2/carbon4-kernel/blame/v4.4.1-RC2/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/config/TenantMgtXMLProcessor.java#L137 >>> [2] - >>> https://github.com/wso2/carbon-multitenancy/blob/master/features/tenant-mgt/org.wso2.carbon.tenant.common.server.feature/src/main/resources/p2.inf#L4 >>> >>> Regards, >>> Nira >>> -- >>> >>> *Niranjan Karunanandham* >>> Senior Software Engineer - WSO2 Inc. >>> WSO2 Inc.: http://www.wso2.com >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Regards, > > > *Darshana Gunawardana*Senior Software Engineer > WSO2 Inc.; http://wso2.com > > *E-mail: [email protected] <[email protected]>* > *Mobile: +94718566859 <%2B94718566859>*Lean . Enterprise . Middleware > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
