Hi Identity Team,

Please review and merge PR [1] after carbon-commons 4.4.4 is released.

[1] - https://github.com/wso2/carbon-identity/pull/735

Regards,
Nira

On Tue, Aug 4, 2015 at 3:32 PM, Niranjan Karunanandham <[email protected]>
wrote:

> Hi Identity Team,
>
> The com.google.code.gson in carbon-identity [1] needs update to 2.3.1.
> Previously jaggery server feature and datapublisher feature (as mentioned
> above) was installing different versions of com.google.code.gson. This is
> now moved to Kernel. I will send the PR with the changes.
>
> [1] - https://github.com/wso2/carbon-identity/blob/master/pom.xml#L1963
>
> Regards,
> Nira
>
> On Tue, Aug 4, 2015 at 10:05 AM, Niranjan Karunanandham <[email protected]
> > wrote:
>
>> Hi Supun,
>>
>> In order to merge this PR[1], we need to update the kernel version[2] in
>> carbon commons to 4.4.1.
>>
>> [1] - https://github.com/wso2/carbon-commons/pull/97
>> [2] - https://github.com/wso2/carbon-commons/blob/master/pom.xml#L1895
>>
>> Regards,
>> Nira
>>
>> On Mon, Aug 3, 2015 at 11:06 PM, Supun Malinga <[email protected]> wrote:
>>
>>> Niranjan,
>>>
>>>
>>> On Mon, May 25, 2015 at 9:58 AM, Niranjan Karunanandham <
>>> [email protected]> wrote:
>>>
>>>> Hi all,
>>>>
>>>> I have created jiras for jaggery [1] and data publisher [2] and updated
>>>> it with the pull requests. Please note that this should be merged only
>>>> after the pull request [3] for kernel is merged and the jaggery and carbon
>>>> commons is updated to kernel version 4.4.1.
>>>>
>>>
>>> Since we have release 4.4.1, pls go ahead and merge the PR
>>> https://github.com/wso2/carbon-commons/pull/97
>>>
>>>
>>>>
>>>> [1] - https://wso2.org/jira/browse/JAGGERY-406
>>>> [2] - https://wso2.org/jira/browse/COMMONS-120
>>>> [3] - https://github.com/wso2/carbon4-kernel/pull/204
>>>>
>>>> Regards,
>>>> Nira
>>>>
>>>> On Fri, May 22, 2015 at 10:25 PM, Sinthuja Ragendran <[email protected]
>>>> > wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> On Fri, May 22, 2015 at 11:19 AM, Niranjan Karunanandham <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Anjana,
>>>>>>
>>>>>> Kind reminder.
>>>>>>
>>>>>> Regards,
>>>>>> Nira
>>>>>>
>>>>>>
>>>>>> On Thu, May 21, 2015 at 4:49 PM, Ruchira Wageesha <[email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Tue, May 19, 2015 at 5:52 PM, Niranjan Karunanandham <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> When writing the integration test for axis2 gson [1], I came across
>>>>>>>> a runtime exception. This was because axis2 gson requires*
>>>>>>>> com.google.code.gson* which is not there in the kernel pack. Shall
>>>>>>>> I add "<bundleDef>com.google.code.gson:gson</bundleDef" in pom.xml of
>>>>>>>> features/org.wso2.carbon.core.common.feature ? Currently the latest 
>>>>>>>> version
>>>>>>>> is 2.3.1.
>>>>>>>>
>>>>>>>> @Anjana and Ruchira: I noticed that currently*
>>>>>>>> com.google.code.gson *is installed when *jaggery server feature*
>>>>>>>> [2] or* datapublisher feature* [3]. If this component is installed
>>>>>>>> along with kernel, can we remove it being installed by jaggery server 
>>>>>>>> and
>>>>>>>> datapublisher features? I also noticed that for jaggery depends on 2.1 
>>>>>>>> and
>>>>>>>> datapublisher depends on 2.2.4. If this is moved to kernel, can we 
>>>>>>>> have the
>>>>>>>> latest version, i.e., 2.3.1?
>>>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>
>>>>> +1, I don't see a problem in upgrading the version of gson in data
>>>>> publisher perspective.
>>>>>
>>>>> Thanks,
>>>>> Sinthuja.
>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> *Niranjan Karunanandham*
>>>>>> Senior Software Engineer - WSO2 Inc.
>>>>>> WSO2 Inc.: http://www.wso2.com
>>>>>>
>>>>>> _______________________________________________
>>>>>> Dev mailing list
>>>>>> [email protected]
>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Sinthuja Rajendran*
>>>>> Associate Technical Lead
>>>>> WSO2, Inc.:http://wso2.com
>>>>>
>>>>> Blog: http://sinthu-rajan.blogspot.com/
>>>>> Mobile: +94774273955
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> *Niranjan Karunanandham*
>>>> Senior Software Engineer - WSO2 Inc.
>>>> WSO2 Inc.: http://www.wso2.com
>>>>
>>>> _______________________________________________
>>>> Dev mailing list
>>>> [email protected]
>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>
>>>>
>>>
>>>
>>> --
>>> Supun Malinga,
>>>
>>> Senior Software Engineer,
>>> WSO2 Inc.
>>> http://wso2.com
>>> email: [email protected] <[email protected]>
>>> mobile: +94 (0)71 56 91 321
>>>
>>
>>
>>
>> --
>>
>> *Niranjan Karunanandham*
>> Senior Software Engineer - WSO2 Inc.
>> WSO2 Inc.: http://www.wso2.com
>>
>
>
>
> --
>
> *Niranjan Karunanandham*
> Senior Software Engineer - WSO2 Inc.
> WSO2 Inc.: http://www.wso2.com
>



-- 

*Niranjan Karunanandham*
Senior Software Engineer - WSO2 Inc.
WSO2 Inc.: http://www.wso2.com
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to