Hi Maduranga, Merged.
@Maheshika, can you release this orbit bundle? Regards, Aruna On Wed, Aug 5, 2015 at 6:36 PM, Maduranga Siriwardena <[email protected]> wrote: > Hi Aruna, > > This is an already existing orbit bundle. I needed to export a package > from the bundle. So I had to update the version. Approve is given to the > bundle in the mail titled with "[Dev] Adding apacheds/1.5.7.wso2v3 and > nimbus/2.26.1.wso2v3". > > I have added the export version as you have asked in the comments of the > PR. Embedded dependencies are already in the bundle. So I hope they need > not be changed. > > Thank you, > Maduranga > > On Wed, Aug 5, 2015 at 6:03 PM, Aruna Karunarathna <[email protected]> wrote: > >> Hi Maduranga, >> >> Added some comments to your PR, Can you check and update?. >> By the way, I believe that this was an approved library?.. >> >> Regards, >> Aruna >> >> On Wed, Aug 5, 2015 at 5:48 PM, KasunG Gajasinghe <[email protected]> >> wrote: >> >>> Hi Aruna, >>> >>> Can you review this? >>> >>> >>> On Wed, Aug 5, 2015 at 5:29 PM, Maduranga Siriwardena < >>> [email protected]> wrote: >>> >>>> Hi Carbon team, >>>> >>>> Please review and merge pull request [1] for orbit. >>>> >>>> This PR export org.apache.directory.server.constants from apacheds >>>> bundle, which is used by carbon-identity. This is needed to compile the >>>> carbon-identity with java 8. >>>> >>>> [1] https://github.com/wso2/orbit/pull/115 >>>> >>>> Thank you, >>>> Maduranga >>>> >>>> -- >>>> Maduranga Siriwardena >>>> Software Engineer >>>> WSO2 Inc. >>>> >>>> email: [email protected] >>>> mobile: +94718990591 >>>> >>> >>> >>> >>> -- >>> >>> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >>> email: kasung AT spamfree wso2.com >>> linked-in: http://lk.linkedin.com/in/gajasinghe >>> blog: http://kasunbg.org >>> >>> >>> >> >> >> >> -- >> >> *Aruna Sujith Karunarathna *| Software Engineer >> WSO2, Inc | lean. enterprise. middleware. >> #20, Palm Grove, Colombo 03, Sri Lanka >> Mobile: +94 71 9040362 | Work: +94 112145345 >> Email: [email protected] | Web: www.wso2.com >> >> > > > > -- > Maduranga Siriwardena > Software Engineer > WSO2 Inc. > > email: [email protected] > mobile: +94718990591 > -- *Aruna Sujith Karunarathna *| Software Engineer WSO2, Inc | lean. enterprise. middleware. #20, Palm Grove, Colombo 03, Sri Lanka Mobile: +94 71 9040362 | Work: +94 112145345 Email: [email protected] | Web: www.wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
