Hi Akila, Thanks for all the suggestions. Please find my inline comments.
- You can get rid of Java module from PHP node [1]. > This is the ESB module. - Improve the node pattern [2] with a proper regex. Refer to Stratos > archives for more information. IsuruH did a fix for this. > Since we are using new clustering module it wont be necessary to have that worker manager separation regex. > - docroot property is missing in PHP node Thanks for pointing it out I will add it. > - Get rid of docroot global variable [3] from all nodes and pass it as a > parameter to class modules > Yes. We can pass that as class variable to python agent in each class module since it is used by python agent. > - Try to integrate Hiera [4] with Puppet. > I will look in to this and check whether it is possible to integrate Hiera in this release. > [1] > https://github.com/anuruddhal/product-private-paas/blob/puppet_vm/cartridges/vm/puppet/manifests/nodes/esb.pp > [2] > https://github.com/anuruddhal/product-private-paas/blob/puppet_vm/cartridges/vm/puppet/manifests/nodes/esb.pp#L18 > [3] > https://github.com/anuruddhal/product-private-paas/blob/puppet_vm/cartridges/vm/puppet/manifests/nodes/appserver.pp#L20 > [4] http://docs.puppetlabs.com/hiera/latest/ On Sun, Aug 9, 2015 at 1:10 AM, Akila Ravihansa Perera <[email protected]> wrote: > Hi Anuruddha, > > Couple of suggestions; > > - You can get rid of Java module from PHP node [1]. > - Improve the node pattern [2] with a proper regex. Refer to Stratos > archives for more information. IsuruH did a fix for this. > - docroot property is missing in PHP node > - Get rid of docroot global variable [3] from all nodes and pass it as a > parameter to class modules > - Try to integrate Hiera [4] with Puppet. > > [1] > https://github.com/anuruddhal/product-private-paas/blob/puppet_vm/cartridges/vm/puppet/manifests/nodes/esb.pp > [2] > https://github.com/anuruddhal/product-private-paas/blob/puppet_vm/cartridges/vm/puppet/manifests/nodes/esb.pp#L18 > [3] > https://github.com/anuruddhal/product-private-paas/blob/puppet_vm/cartridges/vm/puppet/manifests/nodes/appserver.pp#L20 > [4] http://docs.puppetlabs.com/hiera/latest/ > > Thanks. > > On Fri, Aug 7, 2015 at 1:47 PM, Imesh Gunaratne <[email protected]> wrote: > >> This design looks good. Shall we try to export payload parameters as >> environment variables and reuse a common set of scripts in both Docker and >> Puppet? >> >> Thanks >> >> On Fri, Aug 7, 2015 at 12:14 PM, Anuruddha Liyanarachchi < >> [email protected]> wrote: >> >>> Hi Devs, >>> >>> I am currently working on $subject and following is the proposed puppet >>> module structure. Please note that esb is an example product cartridge >>> reference. >>> >>> *Manifests:* >>> >>> base*.*pp - Contains all the mandatory parameters >>> >>> default*.*pp - Contains default setting for default cartridge and >>> execution order of modules. >>> >>> esb*.*pp - Contains ESB specific settings and execution order of >>> modules. >>> (Class['stratos_base'] -> Class['java'] -> >>> Class['configurator']-> >>> Class['python_agent'] -> Class['esb'] ) >>> >>> *Modules :* >>> >>> configurator : Copy and extract configurator zip file. >>> >>> esb : Copy and extract ESB pack, ESB template module and ESB cartridge >>> agent plugins. >>> Start the python agent. >>> >>> java : Copy and extract java zip file. >>> >>> python_agent : Copy and extract python agent zip file. >>> Install cartridge agent dependencies. (pip, >>> pahoo etc) >>> >>> stratos_base : Install basic utilities (curl, zip, tar etc. ) >>> >>> The implementation up to now can be found at [1]. >>> I will update this thread as I progress. Appreciate any suggestions and >>> thoughts towards $subject. >>> >>> [1] >>> https://github.com/anuruddhal/product-private-paas/tree/puppet_vm/cartridges/vm/puppet >>> >>> -- >>> *Thanks and Regards,* >>> Anuruddha Lanka Liyanarachchi >>> Software Engineer - WSO2 >>> Mobile : +94 (0) 712762611 >>> Tel : +94 112 145 345 >>> a <[email protected]>[email protected] >>> >> >> >> >> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.gunaratne.org >> Lean . Enterprise . Middleware >> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Akila Ravihansa Perera > WSO2 Inc.; http://wso2.com/ > > Blog: http://ravihansa3000.blogspot.com > -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a <[email protected]>[email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
