+ KasunG On Tue, Aug 18, 2015 at 5:13 PM, Prabath Ariyarathna <[email protected]> wrote:
> Hi Supun. > > Can you please revert the previous merged PR for URL validation since it > is breaking the existing API URL validations because API doesn't have > service context path and newly added validation checking that path as a > mandatory element. > Still we couldn't find the way to differentiate proxy services and APIs > inside the MultitenentDispatcher. So we decided to revert this and find the > proper solution. Please use following PR. > > https://github.com/wso2/carbon-multitenancy/pull/49 > > Thanks. > > > On Fri, Aug 7, 2015 at 12:21 PM, Supun Malinga <[email protected]> wrote: > >> >> >> On Wed, Aug 5, 2015 at 9:14 PM, Supun Malinga <[email protected]> wrote: >> >>> Hi, >>> >>> On Wed, Aug 5, 2015 at 12:59 PM, Prabath Ariyarathna <[email protected] >>> > wrote: >>> >>>> Hi Supun. >>>> >>>> I did small changes on PR to fix the few issues existing in the URL >>>> validation. Please check the new changes. >>>> >>>> Eg:- >>>> http://wso2s-MacBook-Pro-2.local:8280/xxxx/services/t/wso1.com/Proxy1 >>>> >>>> http://wso2s-MacBook-Pro-2.local:8280/services/xxxx/t/wso1.com/Proxy1 >>>> I checked basic scenarios like proxy service valid and invalid URLs >>>> with super tenant and tenant modes and ran available test cases which are >>>> related to the proxyServices/APIs in the ESB found no issues but >>>> unfortunately at the moment we don't have enough automated test cases to >>>> cover the multitenant edge cases. >>>> >>> >>> OK this is good. I'll merge the PR then. We should add test cases if >>> they are not there. Please create a jira for that. >>> >> >> Merged. >> >> thanks, >> >>> >>>> Thanks. >>>> >>>> >>>> On Wed, Aug 5, 2015 at 12:06 PM, Supun Malinga <[email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> We need to release carbon-identity and carbon-registry once the >>>>> commons is released. This is due to carbon-multitenancy being dependent on >>>>> identity and registry. >>>>> >>>>> Greg and IS teams as we discussed shall we start on those once the >>>>> commons is out ?. >>>>> >>>>> thanks, >>>>> >>>>> On Wed, Aug 5, 2015 at 9:14 AM, Supun Malinga <[email protected]> wrote: >>>>> >>>>>> Hi All, >>>>>> >>>>>> We will be releasing carbon-multitenancy today.. >>>>>> >>>>>> Hi Prabath AR, >>>>>> I looked at the diff and fix looks ok. Have we also verified this >>>>>> with ESB team in terms of the approach to the fix ?. If yes I can go >>>>>> ahead >>>>>> and merge this. >>>>>> >>>>>> thanks, >>>>>> >>>>>> On Tue, Aug 4, 2015 at 12:39 PM, Prabath Ariyarathna < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Supun. >>>>>>> >>>>>>> Please review and merge the PR[1] for this issue[2]. >>>>>>> >>>>>>> [1] = https://github.com/wso2/carbon-multitenancy/pull/46 >>>>>>> [2] = https://wso2.org/jira/browse/ESBJAVA-3992 >>>>>>> >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Tue, Aug 4, 2015 at 10:48 AM, Chanaka Fernando <[email protected] >>>>>>> > wrote: >>>>>>> >>>>>>>> Hi Supun, >>>>>>>> >>>>>>>> We have come across several issues[1], [2], [3] related to tenancy >>>>>>>> when testing the ESB 490 beta release. We are currently looking into >>>>>>>> these >>>>>>>> issues. Did you guys face any issue related to dispatching when >>>>>>>> testing the >>>>>>>> AS in multitenant scenarios? >>>>>>>> >>>>>>>> [1] https://wso2.org/jira/browse/ESBJAVA-3992 >>>>>>>> >>>>>>>> [2] https://wso2.org/jira/browse/ESBJAVA-3989 >>>>>>>> >>>>>>>> [3] https://wso2.org/jira/browse/ESBJAVA-3988 >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Chanaka >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Aug 3, 2015 at 10:13 PM, Supun Malinga <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi Devs, >>>>>>>>> >>>>>>>>> We are going to do $subject soon after carbon commons release. >>>>>>>>> Shout if you have any fixes to be added. >>>>>>>>> >>>>>>>>> thanks, >>>>>>>>> -- >>>>>>>>> Supun Malinga, >>>>>>>>> >>>>>>>>> Senior Software Engineer, >>>>>>>>> WSO2 Inc. >>>>>>>>> http://wso2.com >>>>>>>>> email: [email protected] <[email protected]> >>>>>>>>> mobile: +94 (0)71 56 91 321 >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Dev mailing list >>>>>>>>> [email protected] >>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> -- >>>>>>>> Chanaka Fernando >>>>>>>> Senior Technical Lead >>>>>>>> WSO2, Inc.; http://wso2.com >>>>>>>> lean.enterprise.middleware >>>>>>>> >>>>>>>> mobile: +94 773337238 >>>>>>>> Blog : http://soatutorials.blogspot.com >>>>>>>> LinkedIn:http://www.linkedin.com/pub/chanaka-fernando/19/a20/5b0 >>>>>>>> Twitter:https://twitter.com/chanakaudaya >>>>>>>> Wordpress:http://chanakaudaya.wordpress.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> *Prabath Ariyarathna* >>>>>>> >>>>>>> *Associate Technical Lead* >>>>>>> >>>>>>> *WSO2, Inc. * >>>>>>> >>>>>>> *lean . enterprise . middleware * >>>>>>> >>>>>>> >>>>>>> *Email: [email protected] <[email protected]>* >>>>>>> >>>>>>> *Blog: http://prabu-lk.blogspot.com <http://prabu-lk.blogspot.com>* >>>>>>> >>>>>>> *Flicker : https://www.flickr.com/photos/47759189@N08 >>>>>>> <https://www.flickr.com/photos/47759189@N08>* >>>>>>> >>>>>>> *Mobile: +94 77 699 4730 * >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Supun Malinga, >>>>>> >>>>>> Senior Software Engineer, >>>>>> WSO2 Inc. >>>>>> http://wso2.com >>>>>> email: [email protected] <[email protected]> >>>>>> mobile: +94 (0)71 56 91 321 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Supun Malinga, >>>>> >>>>> Senior Software Engineer, >>>>> WSO2 Inc. >>>>> http://wso2.com >>>>> email: [email protected] <[email protected]> >>>>> mobile: +94 (0)71 56 91 321 >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> *Prabath Ariyarathna* >>>> >>>> *Associate Technical Lead* >>>> >>>> *WSO2, Inc. * >>>> >>>> *lean . enterprise . middleware * >>>> >>>> >>>> *Email: [email protected] <[email protected]>* >>>> >>>> *Blog: http://prabu-lk.blogspot.com <http://prabu-lk.blogspot.com>* >>>> >>>> *Flicker : https://www.flickr.com/photos/47759189@N08 >>>> <https://www.flickr.com/photos/47759189@N08>* >>>> >>>> *Mobile: +94 77 699 4730 * >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >>> -- >>> Supun Malinga, >>> >>> Senior Software Engineer, >>> WSO2 Inc. >>> http://wso2.com >>> email: [email protected] <[email protected]> >>> mobile: +94 (0)71 56 91 321 >>> >> >> >> >> -- >> Supun Malinga, >> >> Senior Software Engineer, >> WSO2 Inc. >> http://wso2.com >> email: [email protected] <[email protected]> >> mobile: +94 (0)71 56 91 321 >> > > > > -- > > *Prabath Ariyarathna* > > *Associate Technical Lead* > > *WSO2, Inc. * > > *lean . enterprise . middleware * > > > *Email: [email protected] <[email protected]>* > > *Blog: http://prabu-lk.blogspot.com <http://prabu-lk.blogspot.com>* > > *Flicker : https://www.flickr.com/photos/47759189@N08 > <https://www.flickr.com/photos/47759189@N08>* > > *Mobile: +94 77 699 4730 * > > > > > > -- *Prabath Ariyarathna* *Associate Technical Lead* *WSO2, Inc. * *lean . enterprise . middleware * *Email: [email protected] <[email protected]>* *Blog: http://prabu-lk.blogspot.com <http://prabu-lk.blogspot.com>* *Flicker : https://www.flickr.com/photos/47759189@N08 <https://www.flickr.com/photos/47759189@N08>* *Mobile: +94 77 699 4730 *
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
