Sure will do. On Tue, Aug 25, 2015 at 9:31 AM, Imesh Gunaratne <[email protected]> wrote:
> Thanks for the response Lasindu!! IMO it would be better if we can add few > validations in the build.sh file to check whether necessary files are there > before building the docker image. > > On Tue, Aug 25, 2015 at 7:50 AM, Lasindu Charith <[email protected]> wrote: > >> >> >> On Tue, Aug 25, 2015 at 6:36 AM, Lasindu Charith <[email protected]> >> wrote: >> >>> Hi Imesh/Pubudu, >>> >>> Please find my comments inline. >>> >>> On Tue, Aug 25, 2015 at 12:31 AM, Pubudu Gunatilaka <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> build.sh file fails when there are no plugins in the {product/plugins} >>>> folder. We need to change the scripts as well. >>>> >>> pushd ${wso2_product_plugin_path} >>> cp * ${script_path}/plugins >>> popd >>> >>> The above 'cp *" command will not fail if there are no files inside ' >>> wso2_product_plugin_path'. But however it will fail if there's no ' >>> wso2_product_plugin_path'or'script_path}/plugins'which I guess is not >>> possible. >>> >>> >> My-bad. It will say *"cp: cannot stat ‘*’: No such file or directory"* >> which I think is ok since it acts as a warning. Building the docker image >> requires these plugins (that's the reason to include them in buil.sh) and >> shouldn't it log an error if the required files are not available? >> >> I don't think we should hide the errors by changing it to 'cp * >> ${script_path}/plugins 2>>/dev/null' >> >> >> I could see the same syntax errors in the other docker images as well. >>>> Will do the needful. >>>> >>>> Thank you! >>>> >>>> On Mon, Aug 24, 2015 at 11:47 PM, Imesh Gunaratne <[email protected]> >>>> wrote: >>>> >>>>> One other problem I noticed with this build.sh file is that it does >>>>> not copy the plugin files to plugins folder when executed with clean. >>>>> >>>>> On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I found the following issue in ESB 4.8.1 build.sh file and fixed: >>>>>> >>>>>> echo "-----------------------------------" >>>>>> - echo "Building" ${wso2_product_type^^} - ${wso2_product_version} >>>>>> "template module" >>>>>> + echo "Building" ${wso2_product_type} - ${wso2_product_version} >>>>>> "template module" >>>>>> echo "-----------------------------------" >>>>>> >>>>>> >>>>>> https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1 >>>>>> >>>>>> This in-fact will change the 'wso2_product_type' to uppercase. >>> However it will not work with bash versions below v4.0. >>> So it's ok to remove them for now. >>> >> >> >>> This will be a syntax error in mac since the default bash version is >>> v3.x.x. >>> >>> >>> >>>> -- >>>>>> *Imesh Gunaratne* >>>>>> Senior Technical Lead >>>>>> WSO2 Inc: http://wso2.com >>>>>> T: +94 11 214 5345 M: +94 77 374 2057 >>>>>> W: http://imesh.gunaratne.org >>>>>> Lean . Enterprise . Middleware >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Imesh Gunaratne* >>>>> Senior Technical Lead >>>>> WSO2 Inc: http://wso2.com >>>>> T: +94 11 214 5345 M: +94 77 374 2057 >>>>> W: http://imesh.gunaratne.org >>>>> Lean . Enterprise . Middleware >>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> >>>> *Pubudu Gunatilaka* >>>> Software Engineer >>>> WSO2, Inc.: http://wso2.com >>>> lean.enterprise.middleware >>>> mobile: +94 77 4078049 >>>> >>> >>> >>> Thanks, >>> -- >>> *Lasindu Charith* >>> Software Engineer, WSO2 Inc. >>> Committer & PMC Member, Apache Stratos >>> Mobile: +94714427192 | Web: blog.lasindu.com >>> >> >> >> >> -- >> *Lasindu Charith* >> Software Engineer, WSO2 Inc. >> Committer & PMC Member, Apache Stratos >> Mobile: +94714427192 | Web: blog.lasindu.com >> > > > > -- > *Imesh Gunaratne* > Senior Technical Lead > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 > W: http://imesh.gunaratne.org > Lean . Enterprise . Middleware > > -- *Lasindu Charith* Software Engineer, WSO2 Inc. Committer & PMC Member, Apache Stratos Mobile: +94714427192 | Web: blog.lasindu.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
